RoundCube Webmail Forum  

Go Back   RoundCube Webmail Forum > Third Party Contributions > Old Style Plug-Ins

For more information about the ads and why they're here, please see the FAQ

Reply
  #11  
Old 12-15-2008, 02:00 PM
Roundcube Newcomer
 
Join Date: Nov 2008
Posts: 9
Default

JohnDoh,

thanks for the new patch. The sieve plugin works fine now wrt to the IMAP root setting

However I encountered a new problem. Whenever I edit the rules created by roundcube within another application the ruleset disappears in roundcube. By editing I don't necessarily mean changing the ruleset. Just opening and saving it unchanged in e.g. smartsieve or the Thunderbird sieve add-on suffices. The rules won't show up in the Filters tab anymore then.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #12  
Old 12-15-2008, 02:44 PM
Registered User
 
Join Date: Oct 2007
Location: Germany, Schleswig-Holstein, Wielen
Posts: 3
Default

Hi,

Attached a little patch:
german (de_DE) localization for the last patch.

Regards,
Mike
Attached Files
File Type: patch sieverules.BETA.r2149.de_DE_v3.patch (4.9 KB, 8 views)

Last edited by vejoun; 12-16-2008 at 12:14 PM.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #13  
Old 12-15-2008, 06:05 PM
Super Moderator
 
Join Date: May 2007
Posts: 835
Default

hosenhans:
Quote:
Originally Posted by JohnDoh View Post
The rule files on the server are written in a certain way that this code can understand so editing rules with other clients will not work.
i think all GUIs for managesieve have the same problem unless support for multiply types of syntax has been built in.

vejoun:thanks for the translation, i will see if i can add it to the patch with the next update.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #14  
Old 12-15-2008, 06:19 PM
Registered User
 
Join Date: Oct 2007
Location: Germany, Schleswig-Holstein, Wielen
Posts: 3
Default

Hi JohnDoh,

do you plan to add an checkbox near the filter in the filter list to simply disable/enable them? Now the filter must be deleted and new created.

Should "multiple_actions" work? I get always "server error", the filter cannot be saved.
dovecot 1.1.7 with dovecot-managesieve

PS: I've reuploaded the translation (2 typos fixed)
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #15  
Old 12-15-2008, 07:11 PM
Roundcube Newcomer
 
Join Date: Nov 2008
Posts: 9
Default

JohnDoh,

sorry you had to quote yourself. It seems I have to stay with your sieve plugin only. Which isn't all that bad, because the user interface is well done
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #16  
Old 12-21-2008, 03:11 PM
Super Moderator
 
Join Date: May 2007
Posts: 835
Default

mk_asdf: I think I tracked down the problem with deleting rules, it only happened with the first rule and it should be fixed in the latest version of the patch (r2184).

Aoster: I had another look at the problem of putting “<” in the filter text. I have removed the stripping of HTML tags and instead encode/decode the characters as needed, this allows you to use “<” but I am not sure if it opens the script up to other problems.

Thanks again to everyone for their feedback. The new version also includes to possibility to disable a rule rather than delete it.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #17  
Old 01-05-2009, 11:45 PM
Registered User
 
Join Date: Jan 2009
Posts: 29
Default

ok, trying to add your plugin, and am getting an odd behavior.

It appears to have patched properly (I used the latest stable release and used your patch). The only thing I had to do was remove the two entries to create the png images, because somehow, those weren't working.

But, the real issue, is that now when I go to use the "Filters" tab, nothing gets triggered, meaning nothing happens. I can click around on the Identities and Folders tabs, but the Filters tab simply doesn't work.

I noticed the URL that gets created from those tabs, and changed the URL to point to ?_task=settings&_action=sieverules and it did go to your sive filter page...

Does anyone have any idea as to why the tab isn't clicking Is it not enabled?

Thanks,

Tim.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #18  
Old 01-05-2009, 11:57 PM
Registered User
 
Join Date: Jan 2009
Posts: 29
Default

wait...I found out that the patch to app.js failed.... not sure why, because I did it on the 0.2 stable release...

you may want to check your patches against that...I will see if I can find it...

Tim
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #19  
Old 01-06-2009, 12:28 AM
Registered User
 
Join Date: Jan 2009
Posts: 29
Default

ok, I found the issue.

I guess a recent development is to remove all of the comments and whitespace from the app.js to make it smaller, so there is now an app.js.src which has the full code that you patched against, and the app.js file is a stripped version.

So, not sure how you want to handle that....I suppose I can just change the patch locally to point to the src file and then remove the whitespace, or just copy the app.js.src file to the app.js file when finished...

Tim.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #20  
Old 01-06-2009, 10:26 AM
Super Moderator
 
Join Date: May 2007
Posts: 835
Default

yes you are quite right. the version of 0.2 stable in the svn has regular JS files while the tarball on the RC site has compacted ones. I wonder why they are different, no matter, I will try and make a new version of the patch later for the compacted js files.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


LinkBacks (?)
LinkBack to this Thread: http://www.roundcubeforum.net/7-third-party-contributions/25-old-style-plug-ins/3905-managesieve-patch.html
Posted By For Type Date
[WIKI][Erledigt] Installation Roundcube This thread Refback 10-08-2009 04:45 AM
#1485888 (password and sasl_password register_handler at wrong time) ? RoundCube Webmail This thread Refback 05-31-2009 11:11 AM
[WIKI][Erledigt] Installation Roundcube This thread Refback 03-11-2009 12:03 PM
RoundCube Patches & Plugins This thread Refback 03-11-2009 10:34 AM
[WIKI][Erledigt] Installation Roundcube This thread Refback 02-25-2009 06:56 AM

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On



All times are GMT. The time now is 09:18 PM.


Powered by vBulletin® Version 3.8.4
Copyright ©2000 - 2010, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO 3.3.0
Copyright © 2006-2008 RoundCube Webmail Community