Thread: Managesieve patch

Hi,

Attached a little patch:
german (de_DE) localization for the last patch.

Regards,
Mike

hosenhans:

Originally Posted by JohnDoh

The rule files on the server are written in a certain way that this code can understand so editing rules with other clients will not work.

i think all GUIs for managesieve have the same problem unless support for multiply types of syntax has been built in.

vejoun:thanks for the translation, i will see if i can add it to the patch with the next update.

Hi JohnDoh,

do you plan to add an checkbox near the filter in the filter list to simply disable/enable them? Now the filter must be deleted and new created.

Should "multiple_actions" work? I get always "server error", the filter cannot be saved.
dovecot 1.1.7 with dovecot-managesieve

PS: I've reuploaded the translation (2 typos fixed)

JohnDoh,

sorry you had to quote yourself. It seems I have to stay with your sieve plugin only. Which isn't all that bad, because the user interface is well done

mk_asdf: I think I tracked down the problem with deleting rules, it only happened with the first rule and it should be fixed in the latest version of the patch (r2184).

Aoster: I had another look at the problem of putting “<” in the filter text. I have removed the stripping of HTML tags and instead encode/decode the characters as needed, this allows you to use “<” but I am not sure if it opens the script up to other problems.

Thanks again to everyone for their feedback. The new version also includes to possibility to disable a rule rather than delete it.

ok, trying to add your plugin, and am getting an odd behavior.

It appears to have patched properly (I used the latest stable release and used your patch). The only thing I had to do was remove the two entries to create the png images, because somehow, those weren't working.

But, the real issue, is that now when I go to use the "Filters" tab, nothing gets triggered, meaning nothing happens. I can click around on the Identities and Folders tabs, but the Filters tab simply doesn't work.

I noticed the URL that gets created from those tabs, and changed the URL to point to ?_task=settings&_action=sieverules and it did go to your sive filter page...

Does anyone have any idea as to why the tab isn't clicking Is it not enabled?

Thanks,

Tim.

wait...I found out that the patch to app.js failed.... not sure why, because I did it on the 0.2 stable release...

you may want to check your patches against that...I will see if I can find it...

Tim

ok, I found the issue.

I guess a recent development is to remove all of the comments and whitespace from the app.js to make it smaller, so there is now an app.js.src which has the full code that you patched against, and the app.js file is a stripped version.

So, not sure how you want to handle that....I suppose I can just change the patch locally to point to the src file and then remove the whitespace, or just copy the app.js.src file to the app.js file when finished...

Tim.

yes you are quite right. the version of 0.2 stable in the svn has regular JS files while the tarball on the RC site has compacted ones. I wonder why they are different, no matter, I will try and make a new version of the patch later for the compacted js files.