Thread: Managesieve patch

Originally Posted by JohnDoh

are there any JS errors or errors in the RC log? the file with .rl. in the name is the right one for the 0.2stable release. did it apply cleanly? it is possible that all you need to do is clear you cache, without any errors i cant tell what is wrong.

Looks like you're right.
After cleaning my cache it worked perfectly...
Sorry for the noob error...

Attached are my translating files.
Hope it fits good, if an other French guy could review them to be sure it looks great regarding the sieve stuff (I'm totally new with that, so the French term could be different)

thats great thanks, i have added them to the site

I use dbmail-timsieved which is compatible with cyrus-timsieve. I discovered that Sender is not working to filter emails based on sender. I discovered that roundcube used X-Sender. I tried to use that to filter mails by sender and it works.

How to adjust it to Sender by default. I mean Sender is actually means filter by X-Sender and users shouldn't be bothered to select other header?

i use dbmail 2.2.10 and roundcube 0.2stable.

Keep up with the good work John!.

Thanks.

Look in program/steps/settings/edit_sieverule.inc. Find `'from' => 'address::Sender',` and replace it with `'from' => 'header::X-Sender',`. I cant test it right now but I think it will work.

I had not realised that RC always uses X-Sender. Perhaps I should modify the code so when you look for Sender it checks both Sender and X-Sender automatically. What does everyone think? Can any one think of a better solution?

Well i think you should put X-Sender instead of Sender in the dropdown list by default and get rid of Sender. Maybe in the future if RC revert to Sender, you can change it accordingly.

Any better idea?

I dont want to do that for 2 reasons, the first is a, slightly stupid, UI one, the option is called Sender not X-Sender and the second is that although RC uses X-Sender other clients use Sender, so simply switching from one to the other will solve nothing. ATM I am really not sure what the best solution is.

Do u think RC shoud use Sender instead of X-Sender?

I applied sieverules.BETA.r2264.patch into http://nightly.roundcube.net/trunk/r...2-20090306.tgz successfully.

patching file index.php
patching file plugins/sieverules/add.png
patching file plugins/sieverules/config.inc.php
patching file plugins/sieverules/help.png
patching file plugins/sieverules/Net_Sieve.php
patching file plugins/sieverules/rcube_sieve.php
patching file plugins/sieverules/rcube_sieve_script.php
patching file plugins/sieverules/sieverules_func.inc
patching file plugins/sieverules/sieverules.php
patching file program/js/app.js
Hunk #4 succeeded at 2839 (offset 4 lines).
patching file program/js/sieverules.js
patching file program/localization/en_US/labels.inc
patching file program/localization/en_US/messages.inc
patching file program/steps/settings/delete_sieverule.inc
patching file program/steps/settings/edit_sieverule.inc
patching file program/steps/settings/save_sieverule.inc
patching file program/steps/settings/sieverules_ajax.inc
patching file program/steps/settings/sieverules.inc
patching file skins/default/functions.js
patching file skins/default/includes/settingstabs.html
patching file skins/default/sieverules.css
patching file skins/default/templates/editsieverule.html
patching file skins/default/templates/sieverules.html

When I clicked on the filter tab nothing happened. The reason I want to use this RC trunk is because it loads faster and many bugs have been fixed since 0.2stable.

well you can see from the output that the patch did not apply cleanly but i expect it is simply a caching issue, clear your cache and try again.

Also version 0.2.1 of RC has just been realsed, there are new versions of the patches for that.

about the X-Sender thing, no i dont think RC should use Sender, that should only be used when you are sure what you are putting in there is a valid email address.