Thread: Right Click Functionality

thanks lacri, i think the delete function really doesnt like me very much. I have made a fix similar to your suggestion. the new version is available now. hopefully that is all the bugs squished.....

Thanks John works realy good, only the Internet Explorer not like this and will not display the context menu after klicking on a folder.

i use the listupdate Event to reinitilize the rcm_contextmenu_init('messagelist tbody tr');

PHP Code:

rcmail.addEventListener('listupdate', function(evt, props) { rcm_contextmenu_init('messagelist tbody tr'); } ); 


and after this works fine in all browsers for me i hope this is correct

thanks again lacri. I have made the change as you suggested. I am not overly happy with it as i think it means the events are added twice in most cases but i dont have time to look for a better solution right now, if any one has any suggestions please let me know.

Really nice to see suggestions being implemented, things like this are what makes Roundcube (IMHO) the best opensource webmail client available.

Keep up the good work guys.

i honestly believe that using jQuery would simplify much of this complex javascript code in roundcube. There would be significantly less code, that is also easier to read. We could need things like: "return rcmail.folder_mouse_up('[Gmail]/All Mail')" on every folder link because we could bind classes with jQuery. jQuery has excellent AJAX methods and it works cross browser. There are hundreds of plugins easily enabling right-click functionality. Also skins could take advantage of jQuery, creating more dynamic and rich themes. I know all of my themes that I am going to make will include jQuery because of its advantages. If this has been discussed before, I am sorry because I am new to the forums (but not to RoundCube).

jQuery is being used in the trunk and will be in the next release i think, but there are some things that (at the moment) jQuery is slow at so it cant be used for everything. there is a little bit of discussion here RoundCube Mailing Lists

as for the right click stuff you are correct, that is why i waited until RC was jQueryfied before i did any thing.

i have been tinkering with RC for a long time now and IMO the JS is great and its really easy to understand once you get your head round the basic structure.

I have used jQuery for over a year, and I have never run into a case where jQuery's ajax methods are slower. There must have been some other varible involved as in not using proper jQuery techniques etc.

Also with jQuery even if it is a little slower, I don't think that should put us off of it. The ability to easily bind keys and run animations with ease is rather helpful. It also allows us to do more mundane things that are useful. (adding odd and even classes to the message list can be just 2 or 3 lines) It does look like the devs have done a good job with the rcmail object, but so much code could be elimitated by effectively using jQuery.

Just my two cents.

as an update: i did some tests myself, jQuery is just as fast at ajax after I ran my own tests, which makes sense since the jQuery $.ajax method is just a way to easily do the DOM ajax.

Great plugin! Only thing I miss, is the message row is selected (displayed in red colour) on right click.