Right Click Functionality

**JohnDoh** · 05-10-2009 10:28 AM

Thanks

. I wondered about the message highlighting thing. I think it would actually make the code simplier if that was done but I decided not to mainly because I thought it was possible that some one might have message open in the preview pane and want to do something to another message, say one that just arrived while still keeping the current message open. does that make sense?

What do people think? should right clicking select that message or just let you do stuff to it.

I just tried in Outlook and it seems to use the same approach as this, although there is a little dotted box around the right clicked message. May be doing something like that, just altering the border around the right clicked message so it is clear which one was clicked would be a good compromise.

**rosali** · 05-11-2009 05:53 PM

Is it necessary to patch lists.js (rc_context_menu.patch ::: lists.js ::: rcm_contextmenu_init)? It seems to work without the patch (at least for IE7). In additon the patch gives me a js error when entering folder administration.

**JohnDoh** · 05-11-2009 07:36 PM

That confused me. you are correct the patch is not needed at all any more, it was only a temporary thing until plugin hooks were available. It should have been removed from the tar.gz and zip files, it has been now.

**rosali** · 05-11-2009 08:33 PM

OK - shouldn't we move this thread please to plugins? If you disagree, feel free to delete this post.

**JohnDoh** · 05-12-2009 01:03 PM

sounds like a plan, i have move it.

**lacri** · 05-26-2009 12:43 PM

Hi John,

i found little things the icons unflagged, print and forwardreplyall are not display.

here is my little workaround.

can you fix this with the rcmail.env i have hardcoded the path.

Code:

$('<a>').attr('href', '#unflagged').addClass('active').html('&nbsp;&nbsp;' + rcmail.gettext('markunflagged')).css('background-image', 'url(' + 'skins/default/images/icons/unflagged.png' + ')').appendTo(menuUnflagged);
$('<a>').attr('href', '#reply-all').addClass('active').html(rcmail.gettext('replytoallmessage')).css('background-image', 'url(' + rcmail.env.forwardedrepliedicon + ')').appendTo(menuReplyall);
$('<a>').attr('href', '#print').addClass('active').html(rcmail.gettext('printmessage')).css('background-image', 'url(' + 'skins/default/images/icons/print.png' + ')').appendTo(menuPrint);

and can you add the new commands from the SVN messagemenu to your plugin for Message download as eml, show source and open in new window

Thanks in advance

**JohnDoh** · 05-26-2009 02:14 PM

I added the icons and the new actions yesterday but following r2541 it doesnt work right any more so i will have to update it again :/

UPDATE: the updated plugin is going to be a bit delayed until r2541 is fixed, its still very buggy in IE and there is no point in rewriting stuff until the new code is sorted.

**lacri** · 05-28-2009 10:46 AM

thanks John yes in the current svn after 2541 dosnt work anymore r2541 breaks completly the context menu in IE FF ...

**marklittle** · 05-30-2009 03:43 AM

FYI - Context menu is working 95% fine for me with latest SVN (r2573). Only thing that is broken are the icons for print, save and source, because they were moved to images/buttons with the 3 versions.

Cheers,
Mark

**rosali** · 05-30-2009 07:09 AM

Please do not include contextmenu.js in "preview pane" or "show message". Both are in task "mail" but don't need the plugin.

If $_GET['_uid'] is not empty, do not trigger things.

View Poll Results: Do you think right click funtionality is a good idea?

Thread: Right Click Functionality

LinkBack

Thread Tools

Display

LinkBacks (?)

RoundCube Patches & Plugins

Thread Information

Users Browsing this Thread

Posting Permissions