Thread: Right Click Functionality

Don't know if it is good style, but this fixed it for me:

Code:

if(typeof props.row == 'object')
  rcmail.addEventListener('insertrow', function(evt, props) { rcm_contextmenu_init(props.row.id); } );

... strange, I never got js error on my local test environment. Issues started since uploaded the stuff to RoundCube Webmail :: Welcome to RoundCube Webmail on my dedicated server.

EDIT: It does not fix it. New rows inserted by a AJAX request are not initialized this way --- :-(

by me work this no errors and also ajax calls work

Code:

rcmail.addEventListener('listupdate', function(evt, props) { rcm_contextmenu_load(true); rcm_contextmenu_init('messagelist tbody tr'); } );
rcmail.addEventListener('insertrow', function(props) { rcm_contextmenu_init(props.row.id); } );

see attachment the working version

Rosali: are you trying to use the 0.3b version of the plugin with a more recent version of RC? Those listeners have changed a little in trunk and I tried with the latest version of both the plugin and RC and i get no errors from empty mailboxes. If it works on one machine and not the other could it be a caching issue?

Hello everybody,

This plugin works perfect now! Very handy it is indeed!
One question I have though: when I login with a secured connection (HTTPS) the browser ( ie8 ) states that not all content can be delivered securerly. Proberly that is due to some pictures in the context menu.

How can it be changed in a way the browser can deliver everything securely?

There should not be any problem with the images, the CSS is almost identical to that for the toolbars. I had a look with IE7 but I didnt get any errors (I dont know, may be I have turned them off somewhere). If you could track down what is causing the message that would be great, then we can get it fixed. Thanks

Here is an updated function for contextmenu.js which detects if archivefolder and/or forward_as_attachment plugin is installed/enabled to make to archive/forward as attachment command accessible by right click:

HTML Code:

function rcm_contextmenu_load(update) {
  if (update) {
    if (rcmail.env.trash_mailbox && rcmail.env.mailbox != rcmail.env.trash_mailbox)
      $("#rcm_delete").html(rcmail.gettext('movemessagetotrash'));
    else
      $("#rcm_delete").html(rcmail.gettext('deletemessage'));
  }
  else {
    var menu = $('<ul>').attr('id', 'rcmContextMenu').addClass('toolbarmenu');
    $('<li>').addClass('conmentitle').html(rcmail.gettext('markmessages')).appendTo(menu);
    var menuRead = $('<li>').addClass('read').appendTo(menu);
    var menuUnread = $('<li>').addClass('unread').appendTo(menu);
    var menuFlagged = $('<li>').addClass('flagged').appendTo(menu);
    var menuUnflagged = $('<li>').addClass('unflagged separator_below').appendTo(menu);
    var menuReply = $('<li>').addClass('reply').appendTo(menu);
    var menuReplyall = $('<li>').addClass('replyall').appendTo(menu);
    var menuForward = $('<li>').addClass('forward').appendTo(menu);
    if(rcmail.env.plugin_forward_as_attachment)
      var menuForwardatt = $('<li>').addClass('forward').appendTo(menu);
    if(rcmail.env.plugin_archive)
      var menuArchive = $('<li>').addClass('archive').appendTo(menu);
    var menuDelete = $('<li>').addClass('delete separator_below').appendTo(menu);
    var menuPrint = $('<li>').addClass('print').appendTo(menu);
    var menuSave = $('<li>').addClass('save').appendTo(menu);
    var menuSource = $('<li>').addClass('source separator_below').appendTo(menu);
    var menuOpen = $('<li>').addClass('open').appendTo(menu);

    $('<a>').attr('href', '#read').addClass('active').html('&nbsp;&nbsp;' + rcmail.gettext('markread')).appendTo(menuRead);
    $('<a>').attr('href', '#unread').addClass('active').html('&nbsp;&nbsp;' + rcmail.gettext('markunread')).appendTo(menuUnread);
    $('<a>').attr('href', '#flagged').addClass('active').html('&nbsp;&nbsp;' + rcmail.gettext('markflagged')).appendTo(menuFlagged);
    $('<a>').attr('href', '#unflagged').addClass('active').html('&nbsp;&nbsp;' + rcmail.gettext('markunflagged')).appendTo(menuUnflagged);
    $('<a>').attr('href', '#reply').addClass('active').html(rcmail.gettext('replytomessage')).appendTo(menuReply);
    $('<a>').attr('href', '#reply-all').addClass('active').html(rcmail.gettext('replytoallmessage')).appendTo(menuReplyall);
    $('<a>').attr('href', '#forward').addClass('active').html(rcmail.gettext('forwardmessage')).appendTo(menuForward);
    if(rcmail.env.plugin_forward_as_attachment)
      $('<a>').attr('href', '#plugin.forwardatt').addClass('active').html(rcmail.gettext('forward_as_attachment.buttontitle')).appendTo(menuForwardatt);
    if(rcmail.env.plugin_archive)
      $('<a>').attr('href', '#plugin.archive').addClass('active').html(rcmail.gettext('archivefolder.buttontitle')).appendTo(menuArchive);
    if (rcmail.env.trash_mailbox && rcmail.env.mailbox != rcmail.env.trash_mailbox)
      $('<a>').attr({href: '#delete', id: 'rcm_delete'}).addClass('active').html(rcmail.gettext('movemessagetotrash')).appendTo(menuDelete);
    else
      $('<a>').attr({href: '#delete', id: 'rcm_delete'}).addClass('active').html(rcmail.gettext('deletemessage')).appendTo(menuDelete);
    $('<a>').attr('href', '#print').addClass('active').html(rcmail.gettext('printmessage')).appendTo(menuPrint);
    $('<a>').attr('href', '#download').addClass('active').html(rcmail.gettext('emlsave')).appendTo(menuSave);
    $('<a>').attr('href', '#viewsource').addClass('active').html(rcmail.gettext('viewsource')).appendTo(menuSource);
    $('<a>').attr('id', 'contextmenu_open').attr('href', '#open').attr('target', '_blank').addClass('active').html(rcmail.gettext('openinextwin')).appendTo(menuOpen);

    $("body").append(menu);
  }
}

thx rosali i have try to port your code to latest version of context menue (John moves the menu generation from JS to PHP see Changelog)

http://www.tehinterweb.co.uk/roundcu....CHANGELOG.txt

your changes not work ;( i have add to contextmenu.php

PHP Code:

$li .= html::tag('li', array('class' => 'forward'), html::a(array('href' => "#plugin.forwardatt", 'class' => 'active'), Q($this->gettext('forward_as_attachment.buttontitle'))));

$li .= html::tag('li', array('class' => 'forward'), html::a(array('href' => "#plugin.archive", 'class' => 'active'), Q($this->gettext('archivefolder.buttontitle')))); 


and to contextmenu.js

PHP Code:

case 'plugin.forwardatt':
case 'plugin.archive': 


and i have change the regexp for commands and i have add #plugin.forwardatt to rcmail.contextmenu_disable_multi array in contextmenu.js

can you try to port this to latest version of Johns nice Context Menu

i have no idea whats wrong

@ lacri:

I will update and release new RoundCube v0.3 stable plugins on sunday. Please use new "forward_as_attachment" and "archivefolder" plugins. Thanks to JohnDoh's help they now automatically integrate in the contextmenu.

I have added a folder menu context menu to the plugin. Its only just been finished so it might be a little buggy still but you can get the latest version from the repo if you want to give it a try.

folder list context menu has the following options:
mark all as read
compact
empty
collapse all folders
expand all folders
open in new window