Thread: Sieverules plugin

hey JohnDoh
yep, thanks, already did some predefined rules and an example rule. the predefined ones are ok, but if i put an example rule, it's the same problem again with the identities. to have them show up, i need to put something like this in the example script:

Code:

require ["vacation"];
# rule:[ABWESEND]
if allof (not exists ["list-help", "list-unsubscribe", "list-subscribe", "list-owner", "list-post", "list-archive", "list-id"],
	not header :is "Precedence" "list, bulk")
{
	vacation
		:days 7
		:addresses ["",""]
		:subject "ABWESEND"
		text:
*NOT AVAILABLE*
;
}

if i omit the ':addresses ["",""]' part, then the advanced options checkbox is again disabled and no identities checked by default. if it is like this, the adv. box is checked but the identities are still unchecked.
any thoughts?
thanks again for the patience

hmmm yes example rules should probably override the protection, it cant test it right now but i have put an update in the repo which should fix it.

just tryed it out. sorry, no difference, same behaviour.

hmmm i have had a chance to try it now, i made a few other changes though. try the repo version, not user if you need to removed the :addresses line or not from your example it worked for me with both.

when i add a new rule to filter by body, i get a message saying it is not supported by the server. im running dovecot 1.2.6 and managesieve server and it seems like filtering by body is supported. what gives?

@bambam i did see that but your options seems to be a little different from mine.
plugins/sieverules/config.inc.php

Mine is
$rcmail_config['sieverules_port'] = 2000;

Your seems to be
$sieverules_config['managesieve_port'] = 12000;

Maybe its nothing. but something to look into.

Also, what version of sieverules are you running?

When you start dovecot, do you see any errors? What does 'dovecot -n' return?

Originally Posted by periferral

when i add a new rule to filter by body, i get a message saying it is not supported by the server. im running dovecot 1.2.6 and managesieve server and it seems like filtering by body is supported. what gives?

there is a bug in how it writes the body rule. its fixed in the repo here: Commit 18155a8184960d9a4b023984143703e32f088589 to JohnDoh's RoundCube-Plugin-SieveRules-Managesieve - GitHub

Just incase there is any confusing about the config variables mentioned in the previous post. They have changed between the last released version and the repo version to fit in better with improvemnts to the RC plugin API.

@johndoh. great. upgrading seems to have fixed the problem.

I have a couple of suggestions for this plugin if you would be so kind.

1. Currently the contents within div boxcontent have no margen and hence stick to the edges. Maybe a CSS addition of margin 15px all round would make this more attractive.

2. I quite like how the managesieve plugin (that is checked into roundcube) has the buttons on the top of the filters to add, delete, move up and move down. There are quite attactive rather than having the button below to add filters and the little up down arrows on the filter name and the delete is within the filter details.
While this request is mostly for asthetic reasons, there is one functional element that is annoying in the current design. Lets say I want to move a filter up a few places. In the way it currently works, I select the filter I want to move and then press the up button. Now the rule has moved up, but I now need to move my mouse up to the new location to click the up button next to move it up again. By having the move up button outside, you just select the rule and click the move up button 3 times and its up 3 locations. No move moves required between moves. I hope this is clear.

3. This is something I'm not entirely sure how things work. If I select a non-default roundcube skin, it seems like I need to add stuff into plugins to add support for this. For example, I tried using mvision and I realized that mvision sources settings.css (when I click on the settings page) to get a consistent look between tabs etc. However, when I click the Filters tab, settings.css isn't sourced because it calls sieverules. I would have thought that roundcube should have sourced settings.css before handing in control to the plugin. But I don't know if there is a consitent rule. Again this is not something you need to do, but I'd like to know more about it.

I can code but php isn't something I'm comfortable with but let me know if you need any help with the plugins.

Originally Posted by periferral

1. Currently the contents within div boxcontent have no margen and hence stick to the edges. Maybe a CSS addition of margin 15px all round would make this more attractive.

I cannot see where exactly you are talking about. What browser are you talking about? Could you attach a screenshot please?

Originally Posted by periferral

2. I quite like how the managesieve plugin (that is checked into roundcube) has the buttons on the top of the filters to add, delete, move up and move down. There are quite attactive rather than having the button below to add filters and the little up down arrows on the filter name and the delete is within the filter details.
While this request is mostly for asthetic reasons, there is one functional element that is annoying in the current design. Lets say I want to move a filter up a few places. In the way it currently works, I select the filter I want to move and then press the up button. Now the rule has moved up, but I now need to move my mouse up to the new location to click the up button next to move it up again. By having the move up button outside, you just select the rule and click the move up button 3 times and its up 3 locations. No move moves required between moves. I hope this is clear.

I don't like the buttons at the top, its one of the reasons I made my own version so I wont be adding those. In my opinion the bottons at the top dont fit in with the style of the other settings tabs in the core. About the moving, you dont have to press the arrows, you can drag 'n drop.

Originally Posted by periferral

3. This is something I'm not entirely sure how things work. If I select a non-default roundcube skin, it seems like I need to add stuff into plugins to add support for this. For example, I tried using mvision and I realized that mvision sources settings.css (when I click on the settings page) to get a consistent look between tabs etc. However, when I click the Filters tab, settings.css isn't sourced because it calls sieverules. I would have thought that roundcube should have sourced settings.css before handing in control to the plugin. But I don't know if there is a consitent rule. Again this is not something you need to do, but I'd like to know more about it.

The plugin was made for the default skin. The skin documentation is still being worked on so right now it is impossible to know what should always be in the skin and what should be in the plugin.