+ Reply to Thread
Results 1 to 10 of 10

Thread: New plugin: Shared Address Books (more than one!)

  1. #1
    imente is offline Registered User
    Join Date
    Oct 2009
    Posts
    3
    Downloads
    0
    Uploads
    0

    Default New plugin: Shared Address Books (more than one!)

    Today I create a simple plugin based on Philipp Weir's Global Address Book [GPL Licence]

    It's the SharedAddressBooks 0.9 plugin for RC 0.3-stable
    [download ZIP file 3kb]


    *FEATURE*
    - all the GlobalAddressBook feature and...
    - one or more SQL address books
    - elastic visibility rules (performs username matching)
    - autocompletion (joining all the address books the user can view)
    - read only flag with a defined admin (who can manage the address book even if readonly is TRUE)

    (In the config file there are all the information about configuration.
    if you find a bug or any other problem please contact me)

    This plugin is very useful for me and so, I hope, for someone else

    Bye from Italy (sorry for my english :P)
    Last edited by imente; 10-17-2009 at 04:06 AM.

  2. #2
    rosali's Avatar
    rosali is offline Super Moderator
    Join Date
    Dec 2007
    Location
    Germany
    Posts
    2,392
    Downloads
    36
    Uploads
    0

    Default

    @ JohnDoh,

    Could you please review this plugin? If this extensions looks fine to you, please merge them into your plugin. We should avoid forking. Also please make the 'Global Addressbook' localized.

    $this->add_texts('localization/');
    $this->name = $this->gettext($rcmail->config->get('globaladdressbook_name'));

    $labels['Global Addresses'] = 'Global Addresses';
    Last edited by rosali; 10-17-2009 at 10:38 AM.
    Regards,
    Rosali

    __________________
    MyRoundcube Project http://myroundcube.googlecode.com
    MyRoundcube Online Demo - Free Email Address http://mail4us.net
    MyRoundcube Plugins Generic Installation Guide http://mail4us.net/myroundcube/index.php
    Mailing List http://mail4us.net/?_action=plugin.nabble

  3. #3
    JohnDoh is offline Super Moderator
    Join Date
    May 2007
    Posts
    1,206
    Downloads
    6
    Uploads
    0

    Default

    rosali, imente....

    rosali is right, having 2 almost identical coppies of the same plugin is pointless. The only really difference I can see between yours and mine is that yours allows for multiple address books where as mine only allows for 1. Would you be interested in working together?
    Roundcube Patches: Sieverules, SpamAssassin Prefs, and more…

  4. #4
    imente is offline Registered User
    Join Date
    Oct 2009
    Posts
    3
    Downloads
    0
    Uploads
    0

    Talking

    absolutely yes.

    let me explain: I did this because I needed a more flexible global adbook that I could't find. So when it was ready I published because I like to share.
    I understand why you want to avoid forking and I agree.

    I accept your propose to work together.
    If you like how i coded that, I can merge in your global address and present it to you so you can review it.

    sorry if it seemed that I wanted to bypass you and I wanted to create a parallel version, simply I do not know if the development was active.

    let me know
    bye

  5. #5
    JohnDoh is offline Super Moderator
    Join Date
    May 2007
    Posts
    1,206
    Downloads
    6
    Uploads
    0

    Default

    excelent, i'll send you a PM with more information.

    rosali: about localising the address book name. The problem is that i think different people will want to call it different things in their setup so localising it becomes a little pointless. Also if we draw a parallel with the ldap address book, the name for this is set in the config, not in the localisation and it does not appear to cause any problems. I'm not sure which is better.
    Roundcube Patches: Sieverules, SpamAssassin Prefs, and more…

  6. #6
    rosali's Avatar
    rosali is offline Super Moderator
    Join Date
    Dec 2007
    Location
    Germany
    Posts
    2,392
    Downloads
    36
    Uploads
    0

    Default

    I really would like to see it to localized. I think it does not hurt to provide a default en_US with...

    $labels['Global Addresses'] = 'Global Addresses';

    ...but it is your decision.

    I don't think you should consider the LDAP behaviour. I use LDAP for dedicated LDAP servers (e.g. UNI Hamburg). The global addresses are local things which are not associated with real external addressbooks. At least I use it that way. You understand what I mean/expect?
    Regards,
    Rosali

    __________________
    MyRoundcube Project http://myroundcube.googlecode.com
    MyRoundcube Online Demo - Free Email Address http://mail4us.net
    MyRoundcube Plugins Generic Installation Guide http://mail4us.net/myroundcube/index.php
    Mailing List http://mail4us.net/?_action=plugin.nabble

  7. #7
    imente is offline Registered User
    Join Date
    Oct 2009
    Posts
    3
    Downloads
    0
    Uploads
    0

    Default

    sorry, maybe I do not understand but

    why create a localization of a plugin name?
    I'm Italian and I have no problem with this plugin.

    Where will that string appear?
    And, this is a name, and names are not translated.

    "Adobe Photoshop" is "Adobe Photoshop" in other languages

    If I misunderstood the topic I sorry in advance.

  8. #8
    JohnDoh is offline Super Moderator
    Join Date
    May 2007
    Posts
    1,206
    Downloads
    6
    Uploads
    0

    Default

    As I said I think it depends very much on exactly what people want to use the plugin for. I have changed the repo version so it uses a localised string, my thinking was this:

    If someone wants to have the name localised, like the "Personal Addresses" title then they can, if some one wants it called something else then they can still do this, they just have to change it in the localisation file rather than the cofig AND they can still have their new name in multiple languages if they want - or just one - change in the en_US and delete all the other files.
    Roundcube Patches: Sieverules, SpamAssassin Prefs, and more…

  9. #9
    dziobak is offline Registered User
    Join Date
    Dec 2009
    Location
    Poland
    Posts
    184
    Downloads
    4
    Uploads
    0

    Default

    Is this plugin working? Is there a newer version?

  10. #10
    jmeander is offline Registered User
    Join Date
    Apr 2009
    Posts
    7
    Downloads
    0
    Uploads
    0

    Default

    Is this plugin active?

+ Reply to Thread

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

     

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts