Thread: RoundCube Calendar (jQuery Calendar)

Originally Posted by rosali

solved

use that:

Code:

  function get_events()
  {
    $rcmail = rcmail::get_instance();

    $tz = isset($_SESSION['timezone']) ? $_SESSION['timezone'] : date('Z')/3600;

mmm, not quite. This shifts all events that are not in the current timezone off by one hour -- so if it's july (during daylight saving time) and you're looking back at what happened in january (during which we observed standard time), or vice versa, events look fine in your current month but they are off by an hour during the months where the other tz was observed.

I have a fix, it's not pretty but it works better. I even try to determine whether DST is not observed where you are (or at least, where the server is, which is usually a good indication).

1. fix toGMT

Code:

  function toGMT($time) {
    $gmt_offset = date('Z');

    // current gmt offset may not match event's gmt offset
    // adjust accordingly
    if (date('I') && !date('I',$time)) {
      $gmt_offset -= 3600;
    } else if (!date('I') && date('I',$time)) {
      $gmt_offset += 3600;
    }

    return date('Y-m-d H:i:s',$time - $gmt_offset);
  }

2. fix getEvents (in database.php)

Code:

  public function getEvents($start, $end) {
    if (!empty($this->rcmail->user->ID)) {

      /* This was completely wrong -- the question is whether to adjust
         the EVENT's time for DST.
         Whether we are CURRENTLY observing DST is not really the issue.
         The question is (A) does the user observe DST? and if so,
         (B) does THIS EVENT fall on the calendar during DST or STD time?
      */

      if ($this->rcmail->config->get('timezone') === "auto") {
        $auto = TRUE;
        $tz = isset($_SESSION['timezone']) ? $_SESSION['timezone'] : date('Z')/3600;
      } else {
        $auto = FALSE;
        $tz = $this->rcmail->config->get('timezone');
        if($this->rcmail->config->get('dst_active')) {
          $dst_active = TRUE;
          $tz++;
        }
      }

      if (date('I') || (!$auto && $dst_active)) {
        $tz_std = $tz - 1;
        $tz_dst = $tz;
      } else {
        $tz_std = $tz;
        $tz_dst = $tz + 1;
      }

      // Server does not observe DST?  Then most likely the user doesn't either.
      if (($auto || !$dst_active) && !date('I',mktime(0,0,0,7,1,2010))) {
        // no DST adjustment
        $tz_std = $tz;
        $tz_dst = $tz;
      }

      $result = $this->rcmail->db->query(
        "SELECT * FROM events
         WHERE user_id=?",
         $this->rcmail->user->ID
       );

      $events = array();
      while ($result && ($event = $this->rcmail->db->fetch_assoc($result))) {
        $event['start'] = strtotime($event['start']);
        $event['end'] = strtotime($event['end']);

        // is/was the EVENT during daylight saving time?
        if (date('I',$event['start'] + $tz * 3600)) {
          $event['start'] += $tz_dst * 3600;
          $event['end'] += $tz_dst * 3600;
        } else {
          $event['start'] += $tz_std * 3600;
          $event['end'] += $tz_std * 3600;
        }

        $events[]=array(
          'id'    => $event['event_id'],
          'start' => date('c', $event['start']),
          'end'   => date('c', $event['end']),
          'title' => $event['summary'],
          'description'  => $event['description'],
          'className'  => $event['category'],
          'allDay'=> ($event['all_day'] == 1)?true:false,
        );
      }

      return json_encode($events);
    }
  }