Author Topic: A suggestion for "Display Images" in message  (Read 2408 times)

Offline rwilkins108

  • Jr. Member
  • **
  • Posts: 21
A suggestion for "Display Images" in message
« on: November 03, 2007, 01:24:30 PM »
Here's a suggestion:

When you click Display Images in a message, can it somehow store the fact that you enabled it for that message, so that if you select that message again, it'll automatically display the images?

spellegrin

  • Guest
Re: A suggestion for "Display Images" in message
« Reply #1 on: April 18, 2008, 12:24:07 AM »
If you are running Roundcube 0.1.1, maybe I can help.

I've patched the sources to add a user preference for blocking/allowing images in HTML messages. If you know how to run the patch utility, have a look here: http://www.convoglio.com/roundcube/

-Steve

p.s. I'll be contacting the developers about my changes. But, really, they don't need my help with something as easy as this. ;)

Offline rmc2000

  • Jr. Member
  • **
  • Posts: 40
how i install it?
« Reply #2 on: April 29, 2008, 04:39:19 PM »
how i add you patch i try make changes but not understand! file like:

show.inc.patch.txt

You put:

51c51,53
<   if ($MESSAGE['is_safe'] = intval($_GET['_safe']))
---
>   if ($CONFIG['allow_images'])
>     $MESSAGE['is_safe'] = 1;
>   else if ($MESSAGE['is_safe'] = intval($_GET['_safe']))
60c62
<   if ((bool)$MESSAGE['is_safe'])
---
>   if (!$CONFIG['allow_images'] && (bool)$MESSAGE['is_safe'])



What i need change exactly?


Replace this line if ($MESSAGE['is_safe'] = intval($_GET['_safe']))

to

   if ($CONFIG['allow_images'])
     $MESSAGE['is_safe'] = 1;
   else if ($MESSAGE['is_safe'] = intval($_GET['_safe']))


and

if ((bool)$MESSAGE['is_safe'])

to

if (!$CONFIG['allow_images'] && (bool)$MESSAGE['is_safe'])

What is 51c51,53 and 60c62 ?

Thanks

Offline TopQuark

  • Newbie
  • *
  • Posts: 7
Thank you Steve!
« Reply #3 on: June 03, 2008, 02:04:15 AM »
Quote from: spellegrin;11591
If you are running Roundcube 0.1.1, maybe I can help.

I've patched the sources to add a user preference for blocking/allowing images in HTML messages. If you know how to run the patch utility, have a look here: http://www.convoglio.com/roundcube/

-Steve

p.s. I'll be contacting the developers about my changes. But, really, they don't need my help with something as easy as this. ;)


My first post.

Excellent mod!  I tried it and it works perfectly.  Thank you!

Today is the first day I installed RoundCube (through the latest version of cPanel).  This is the first thing I checked just like when I started using SquirrelMail.  I was surprised to find out this is one of the most requested feature but it was totally neglected since year 2006.

There are exotic solutions like adding the sender in the "safe list" but I would vote to have your mod as a minimum.  It's a no brainer.  Really.

Offline TopQuark

  • Newbie
  • *
  • Posts: 7
A suggestion for "Display Images" in message
« Reply #4 on: June 03, 2008, 02:10:15 AM »
Quote from: rmc2000;11718

What is 51c51,53 and 60c62 ?

Those are the rows where to insert them to.  You can automate the patch or just manually delete and insert each line.

Offline TopQuark

  • Newbie
  • *
  • Posts: 7
A suggestion for "Display Images" in message
« Reply #5 on: August 15, 2008, 01:47:32 PM »
Any update on 0.2 version yet?

Offline dj2

  • Jr. Member
  • **
  • Posts: 40
A suggestion for "Display Images" in message
« Reply #6 on: August 15, 2008, 02:15:47 PM »
It's in the latest SVN release.