SVN 286 character encoding issue

[rene.s]

There seems to be a bug in charater encoding of the From:, To: and CC: header field.
Setting a non-ASCI Character under Identities, (e.g André, Müller,...) or even in the Adress Book breaks the encoding.

Example:

Setting André under Identities as sender name results in:

From: =?UTF-8?Q?Andr=C3=A9=20?=

Correct would be:

From: =?UTF-8?Q?Andr=C3=A9=20?=


René

[rjsalamanca]

I have the same problem. I commented out line 57 at /program/steps/mail/sendmail.inc but now I am sending mails an the sender's name does not appears, only the sender's address.

How can I put the sender's name?

[rene.s]

Same bug is still in SVN Rev. 327

At the moment I'm using rjsalamanca's workaround:

To resolve the issue with the "From:"-field:

Code: [Select]

56: $out['string'] = sprintf('%s <%s>',
57:  rcube_charset_convert($name, $CHARSET, $OUTPUT->get_charset()),
58:  $sql_arr['mailto']);

relace with

Code: [Select]

56: $out['string'] = sprintf('%s <%s>',
57:  $sql_arr['mailto'],
58:  $sql_arr['mailto']);


To resolve the issue with the "To:"-field:

Code: [Select]

112: $headers = array('Date' => date('D, j M Y G:i:s O'),
113: 'From' => $identity_arr['string'],
114: 'To'  => rcube_charset_convert($mailto, $input_charset, $message_charset));


Code: [Select]

112: $headers = array('Date' => date('D, j M Y G:i:s O'),
113: 'From' => $identity_arr['string'],
114: 'To'  => $mailto);


[Arabian]

I wish this could fixed soon too, I have the same problem with the Arabic chars windows-1256.

[enyone]

The problem is in file "program/lib/Mail/Mime.php" in local function "_encodeHeaders" (starts from line 788)..
It seems to be common error in regular expressions.. (I hate em..)

I'm solving this issue, but I don't know when I'm done.. Maybe I'll have some free time in next few days, maybe.. ;)


So see you soon,.. or maybe not ;)


Code snippet (function _encodeHeaders):

Code: [Select]

 function _encodeHeaders($input)
  {
    foreach ($input as $hdr_name => $hdr_value) {
      if (function_exists('iconv_mime_encode') && preg_match('#[\x80-\xFF]{1}#', $hdr_value)){
        $imePref = array();
        if ($this->_build_params['head_encoding'] == 'base64'){
          $imePrefs['scheme'] = 'B';
        }else{
          $imePrefs['scheme'] = 'Q';
        }
        $imePrefs['input-charset'] = $this->_build_params['head_charset'];
        $imePrefs['output-charset'] = $this->_build_params['head_charset'];
        $hdr_value = iconv_mime_encode($hdr_name, $hdr_value, $imePrefs);
        $hdr_value = preg_replace("#^{$hdr_name}\:\ #", "", $hdr_value);
      }elseif (preg_match('#[\x80-\xFF]{1}#', $hdr_value)){
        //This header contains non ASCII chars and should be encoded.
        switch ($this->_build_params['head_encoding']) {
        case 'base64':
          //Base64 encoding has been selected.
         
          //Generate the header using the specified params and dynamicly
          //determine the maximum length of such strings.
          //75 is the value specified in the RFC. The -2 is there so
          //the later regexp doesn't break any of the translated chars.
          $prefix = '=?' . $this->_build_params['head_charset'] . '?B?';
          $suffix = '?=';
          $maxLength = 75 - strlen($prefix . $suffix) - 2;
          $maxLength1stLine = $maxLength - strlen($hdr_name);
         
          //Base64 encode the entire string
          $hdr_value = base64_encode($hdr_value);

          //This regexp will break base64-encoded text at every
          //$maxLength but will not break any encoded letters.
          $reg1st = "|.{0,$maxLength1stLine}[^\=][^\=]|";
          $reg2nd = "|.{0,$maxLength}[^\=][^\=]|";
          break;
        case 'quoted-printable':
        default:
          //quoted-printable encoding has been selected
         
          //Generate the header using the specified params and dynamicly
          //determine the maximum length of such strings.
          //75 is the value specified in the RFC. The -2 is there so
          //the later regexp doesn't break any of the translated chars.
          $prefix = '=?' . $this->_build_params['head_charset'] . '?Q?';
          $suffix = '?=';
          $maxLength = 75 - strlen($prefix . $suffix) - 2;
          $maxLength1stLine = $maxLength - strlen($hdr_name);
         
          //Replace all special characters used by the encoder.
          $search = array("=",  "_",  "?",  " ");
          $replace = array("=3D", "=5F", "=3F", "_");
          $hdr_value = str_replace($search, $replace, $hdr_value);
         
          //Replace all extended characters (\x80-xFF) with their
          //ASCII values.
          $hdr_value = preg_replace(
            '#([\x80-\xFF])#e',
            '"=" . strtoupper(dechex(ord("\1")))',
            $hdr_value
          );
          //This regexp will break QP-encoded text at every $maxLength
          //but will not break any encoded letters.
          $reg1st = "|(.{0,$maxLength})[^\=]|";
          $reg2nd = "|(.{0,$maxLength})[^\=]|";
          break;
        }
        //Begin with the regexp for the first line.
        $reg = $reg1st;
        $output = "";
        while ($hdr_value) {
          //Split translated string at every $maxLength
          //But make sure not to break any translated chars.
          $found = preg_match($reg, $hdr_value, $matches);
         
          //After this first line, we need to use a different
          //regexp for the first line.
          $reg = $reg2nd;

          //Save the found part and encapsulate it in the
          //prefix & suffix. Then remove the part from the
          //$hdr_value variable.
          if ($found){
            $part = $matches[0];
            $hdr_value = substr($hdr_value, strlen($matches[0]));
          }else{
            $part = $hdr_value;
            $hdr_value = "";
          }
         
          //RFC 2047 specifies that any split header should be seperated
          //by a CRLF SPACE.
          if ($output){
            $output .= "\r\n ";
          }
          $output .= $prefix . $part . $suffix;
        }
        $hdr_value = $output;
      }
      $input[$hdr_name] = $hdr_value;
    }

    return $input;
  }

[enyone]

Temporary fix!

The problem is in file "program/lib/Mail/Mime.php" in local function "_encodeHeaders" (starts from line 788)..

This fix allows you to use only one (1) recipient !

OLD (starts from line 879):

Code: [Select]

         //RFC 2047 specifies that any split header should be seperated
          //by a CRLF SPACE.
          if ($output){
            $output .= "\r\n ";
          }
          $output .= $prefix . $part . $suffix;
        }
        $hdr_value = $output;
      }
      $input[$hdr_name] = $hdr_value;
    }
NEW (starts from line 879):

Code: [Select]

         //RFC 2047 specifies that any split header should be seperated
          //by a CRLF SPACE.
          if ($output){
            $output .= "\r\n ";
          }
          $output .= $prefix . $part . $suffix;
          $output = str_replace(">?=", ">", $output);
          $output = str_replace("_<", "?= <", $output);
        }
        $hdr_value = $output;
      }
      $input[$hdr_name] = $hdr_value;
    }
see above and replace your code ^^

If somebody is able to solve this issue completely, go ahead! ;)