Failed login not logged

[framelio]

Hello,
using RC 1.1.1 with

$config['log_session'] = true;
$config['log_logins'] = true;
$config['debug_level'] = 2;
$config['log_driver'] = 'file';

The unsuccessful logins are not logged in any of the log files while the successfull are.

I've also noticed that in the index.php file (in the root), you call the deprecated function (if it's deprecated) rcmail_log_login() instead of calling

$RCMAIL->log_login();

I've tested a patch and add in the else section (if the login fail) the code:

$RCMAIL->log_login($auth['user'], true, $error_code);

$error_message = $error_labels[$error_code] ? $error_labels[$error_code] : 'loginfailed';
$RCMAIL->log_login($auth['user'], true, $error_code);
$OUTPUT->show_message($error_message, 'warning');

And after this change, the log error message appears as expected.

[JohnDoh]

Code: [Select]

$error_message = $error_labels[$error_code] ? $error_labels[$error_code] : 'loginfailed';
there is no code like that in the (soon to be relased) roundcube 1.1.1 or in roundcube 1.1.0 and logging of failed loging was added in roundcube 1.0. Please make sure you are running an upto date index.php file. You should see the version in the comment block at the top of the file.

[alec]

And use debug_level=1 not 2.

[framelio]

Thank you very much guys!
It's indeed right, I had an old version of index.php (probably from 0..

With the new index.php everything is ok!