SVN Releases > Issues & Bugs

Change favicon for skin with extends

(1/2) > >>

beliy:
How is it possible to change favicon.ico for skin with using {"extends": "larry"} ?
With next includes/links.html:

--- Code: ---<meta name="viewport" content="" id="viewport" />
<link rel="shortcut icon" href="/images/favicon.ico"/>
<roundcube:include file="/includes/links.html" skinPath="skins/larry" />
<link rel="stylesheet" type="text/css" href="/styles.css" />
--- End code ---

roundcube generate 2 favicon block and use favicon from extends skin. Please help with it.  Thanks.

JohnDoh:
please could you explain what the issue is you are facing a bit more? it sounds like you have done it correctly and it should work - extend the skin, then either just put your own favicon.ico file in there or create your own includes/links.html and change the favicon link to what ever you like.

beliy:

--- Quote from: JohnDoh on October 04, 2018, 01:09:59 AM ---please could you explain what the issue is you are facing a bit more? it sounds like you have done it correctly and it should work - extend the skin, then either just put your own favicon.ico file in there or create your own includes/links.html and change the favicon link to what ever you like.

--- End quote ---

I tried to do it for skin harry, but it don't work. You can find current source code here - https://github.com/beliys/harry/tree/master/skins/harry

JohnDoh:
in your links.html you include the original version from Larry that is why you get 2 favicons - the one from your file and the one from the original.

BTW this change, included in 1.4-beta might help https://github.com/roundcube/roundcubemail/commit/4ea790ba37ee556db383a7ee48bfac182b2487a7#diff-f7910780eae15da9c450546603cf3e15 amognst other things it will let you define the favicon in meta.json (in the config section)

beliy:

--- Quote from: JohnDoh on October 04, 2018, 04:53:29 AM ---in your links.html you include the original version from Larry that is why you get 2 favicons - the one from your file and the one from the original.

BTW this change, included in 1.4-beta might help https://github.com/roundcube/roundcubemail/commit/4ea790ba37ee556db383a7ee48bfac182b2487a7#diff-f7910780eae15da9c450546603cf3e15 amognst other things it will let you define the favicon in meta.json (in the config section)

--- End quote ---

Is it possible to show example define the favicon in meta.json? Thanks.

Navigation

[0] Message Index

[#] Next page