Author Topic: Change favicon for skin with extends  (Read 1315 times)

Offline beliy

  • Jr. Member
  • **
  • Posts: 12
Change favicon for skin with extends
« on: October 03, 2018, 06:10:36 AM »
How is it possible to change favicon.ico for skin with using {"extends": "larry"} ?
With next includes/links.html:
Code: [Select]
<meta name="viewport" content="" id="viewport" />
<link rel="shortcut icon" href="/images/favicon.ico"/>
<roundcube:include file="/includes/links.html" skinPath="skins/larry" />
<link rel="stylesheet" type="text/css" href="/styles.css" />

roundcube generate 2 favicon block and use favicon from extends skin. Please help with it.  Thanks.
« Last Edit: October 04, 2018, 04:24:48 AM by beliy »

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,140
Re: Change favicon for skin with extends
« Reply #1 on: October 04, 2018, 01:09:59 AM »
please could you explain what the issue is you are facing a bit more? it sounds like you have done it correctly and it should work - extend the skin, then either just put your own favicon.ico file in there or create your own includes/links.html and change the favicon link to what ever you like.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline beliy

  • Jr. Member
  • **
  • Posts: 12
Re: Change favicon for skin with extends
« Reply #2 on: October 04, 2018, 04:23:57 AM »
please could you explain what the issue is you are facing a bit more? it sounds like you have done it correctly and it should work - extend the skin, then either just put your own favicon.ico file in there or create your own includes/links.html and change the favicon link to what ever you like.

I tried to do it for skin harry, but it don't work. You can find current source code here - https://github.com/beliys/harry/tree/master/skins/harry

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,140
Re: Change favicon for skin with extends
« Reply #3 on: October 04, 2018, 04:53:29 AM »
in your links.html you include the original version from Larry that is why you get 2 favicons - the one from your file and the one from the original.

BTW this change, included in 1.4-beta might help https://github.com/roundcube/roundcubemail/commit/4ea790ba37ee556db383a7ee48bfac182b2487a7#diff-f7910780eae15da9c450546603cf3e15 amognst other things it will let you define the favicon in meta.json (in the config section)
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline beliy

  • Jr. Member
  • **
  • Posts: 12
Re: Change favicon for skin with extends
« Reply #4 on: October 04, 2018, 06:30:13 AM »
in your links.html you include the original version from Larry that is why you get 2 favicons - the one from your file and the one from the original.

BTW this change, included in 1.4-beta might help https://github.com/roundcube/roundcubemail/commit/4ea790ba37ee556db383a7ee48bfac182b2487a7#diff-f7910780eae15da9c450546603cf3e15 amognst other things it will let you define the favicon in meta.json (in the config section)

Is it possible to show example define the favicon in meta.json? Thanks.

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,140
Re: Change favicon for skin with extends
« Reply #5 on: October 04, 2018, 01:35:12 PM »
assuming that /skins/myskin/images/myfavicon.ico exists then this will work with 1.4-beta:
Code: [Select]
{
"name": "My Skin",
"extends": "larry",
"config": {
"favicon": "/images/myfavicon.ico"
}
}
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline beliy

  • Jr. Member
  • **
  • Posts: 12
Re: Change favicon for skin with extends
« Reply #6 on: October 05, 2018, 03:50:32 AM »
Thanks, than 1.3.x will be with larry favicon)