Managesieve patch

[JohnDoh]

mk_asdf: I think I tracked down the problem with deleting rules, it only happened with the first rule and it should be fixed in the latest version of the patch (r2184).

Aoster: I had another look at the problem of putting “<” in the filter text. I have removed the stripping of HTML tags and instead encode/decode the characters as needed, this allows you to use “<” but I am not sure if it opens the script up to other problems.

Thanks again to everyone for their feedback. The new version also includes to possibility to disable a rule rather than delete it.

[timtraver]

ok, trying to add your plugin, and am getting an odd behavior.

It appears to have patched properly (I used the latest stable release and used your patch). The only thing I had to do was remove the two entries to create the png images, because somehow, those weren't working.

But, the real issue, is that now when I go to use the "Filters" tab, nothing gets triggered, meaning nothing happens. I can click around on the Identities and Folders tabs, but the Filters tab simply doesn't work.

I noticed the URL that gets created from those tabs, and changed the URL to point to ?_task=settings&_action=sieverules and it did go to your sive filter page...

Does anyone have any idea as to why the tab isn't clicking??? Is it not enabled?

Thanks,

Tim.

[timtraver]

wait...I found out that the patch to app.js failed.... not sure why, because I did it on the 0.2 stable release...

you may want to check your patches against that...I will see if I can find it...

Tim

[timtraver]

ok, I found the issue.

I guess a recent development is to remove all of the comments and whitespace from the app.js to make it smaller, so there is now an app.js.src which has the full code that you patched against, and the app.js file is a stripped version.

So, not sure how you want to handle that....I suppose I can just change the patch locally to point to the src file and then remove the whitespace, or just copy the app.js.src file to the app.js file when finished...

Tim.

[JohnDoh]

yes you are quite right. the version of 0.2 stable in the svn has regular JS files while the tarball on the RC site has compacted ones. I wonder why they are different, no matter, I will try and make a new version of the patch later for the compacted js files.

[JohnDoh]

added a patch for the release version from the RC website, please see top post.

[swartel]

Hi John,
I tried to patch RC 0.2 beta. All seem ok except for the file function.js that does not exist anymore in this release.
So, when I click on the tab, i get a blank page with the url ?_task=settings&_action=sieverules

What do I need to modify ? maybe something in app.js ?
Thanks by advance for your help

Stephane

[JohnDoh]

The patch is for version 0.2stable. It will not work with 0.2beta, the code uses functions that were not added until after 0.2beta was released.

[roe1234]

I can't seem to get roundcube to see an existing rule file, written by hand.  I have ensured it is "active", meaning .dovecot-sieve is pointing to it, and that it is named "roundcube.sieve.  Any thoughts?

[JohnDoh]

The rule files on the server are written in a certain way that this code can understand, if you wrote a rule by hand the script probably wont understand it unless you have used the right formatting.

[roe1234]

general pastebin - Mine - post number 1306161

this pastebin represent both the one "real" filter created by hand and a test one I created using your plugin.  I can't see a difference between the two formats.  It is altogether possible I am blind though.

[JohnDoh]

I cant see a difference either. I loaded your rules into my sieve file and the plugin recognised them fine. Are there any errors in the RC error log or in the dovecot log?

[roe1234]

The only thing that I can think is that we are not using the newest roundcube/patch combo.  We are still using the pre0.2stable version

[JohnDoh]

do you mean 0.2beta or an SVN version?

[roe1234]

and SVN version