Author Topic: Managesieve patch  (Read 56939 times)

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Managesieve patch
« Reply #30 on: January 12, 2009, 03:05:08 PM »
hmm it definatly loads for me, which SVN version is it? can you attach the actual roundcube.sieve file? may be i am loosing something in copy/paste.
« Last Edit: January 13, 2009, 08:36:08 AM by JohnDoh »
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline oscar

  • Newbie
  • *
  • Posts: 6
Managesieve patch
« Reply #31 on: January 15, 2009, 04:36:45 AM »
Hi JohnDoe!

Patched my RC with your patchset (are you collaborating with Alec btw?) without problems. I'm running Dovecot 1.0 with pysieved. Everything works okay, except when trying to use "setflag". I just get a server error. I haven't tried everything else, but it seems the other functions work.. Any ideas?

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Managesieve patch
« Reply #32 on: January 15, 2009, 01:43:52 PM »
Hi,

This patch is based on Alec's work but i am not actually colaborating with him. Could you send me any example of the rule you are trying to create and i will try it. I havent had any problems myself but i am testing using Dovecot Managesieve, may be there is something in the syntax pysieved doesnt like.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline oscar

  • Newbie
  • *
  • Posts: 6
Managesieve patch
« Reply #33 on: January 15, 2009, 06:19:17 PM »
Ok, it's always good to colaborate ;)

To reproduce for me:
"Match all messages"
"Mark message as" "whatever"

Would want to run ManageSieve for Dovecot, but I don't want to compile it myself just because of that.. So I'm using cmusieve, and it says that it supports a draft version of imapflags and notify (haven't tried notify myself):
LDA/Sieve - Dovecot Wiki

Please let me know if you want me to test anything.

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Managesieve patch
« Reply #34 on: January 16, 2009, 03:58:25 AM »
ah you are quite right. setflag doesnt work when you select all messages. It works fine with the other 2 options :/ I will look into it.

colaboration is good but i think Alec is busy at the moment, he hasnt made a lot of updates to his patch recently.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline oscar

  • Newbie
  • *
  • Posts: 6
Managesieve patch
« Reply #35 on: January 16, 2009, 05:13:02 AM »
Using cmusieve/pysieved I can't get any setflag to work (the filtering itself works if I create the rule manually, it's just when I use the web interface).

So, setting "match all/any"  "Subject contains 'aa'" -> "setflag read"  doesn't work here either.

Let me know if I need to test anything directly against sieve or sievec (I'm guessing that's how pysieve checks and rejects stuff?)

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Managesieve patch
« Reply #36 on: January 16, 2009, 05:22:14 AM »
Please try this: in plugins/sieverules/rcube_sieve_script.php, line 44, change 'imapflags' to 'setflag'.

I found a few JS bugs just now as well so I will release an updated version in the next few days any way.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline oscar

  • Newbie
  • *
  • Posts: 6
Managesieve patch
« Reply #37 on: January 16, 2009, 06:06:18 AM »
Nope sorry, still the same.

Offline roe1234

  • Jr. Member
  • **
  • Posts: 20
Feature Request
« Reply #38 on: January 18, 2009, 02:47:30 PM »
I would like to use sieve to give users the ability to build a vacation message.  The MDA is ideal for this so people can choose *not* to automatically respond to spam and mailing-lists etc.  Keeping this in mind, is there a way to extend this plug-in to allow users to build a rudimentary body message with a "reply" option?

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Managesieve patch
« Reply #39 on: January 19, 2009, 05:47:10 AM »
I'm sorry I dont understand.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline roe1234

  • Jr. Member
  • **
  • Posts: 20
Clarification
« Reply #40 on: January 19, 2009, 08:19:19 AM »
For clarification, here is the rfc:

RFC 5230 - Sieve Email Filtering: Vacation Extension

Offline vejoun

  • Newbie
  • *
  • Posts: 3
Problem with TLS
« Reply #41 on: January 21, 2009, 03:00:11 PM »
With this config all is ok. I can see the rules and add rules.
Code: [Select]
$sieverules_config['managesieve_host'] = 'ssl.foo.de';
$sieverules_config['managesieve_port'] = 2000;
$sieverules_config['usetls'] = false;
$sieverules_config['folder_delimiter'] = null;
$sieverules_config['include_imap_root'] = FALSE;
$sieverules_config['ruleset_name'] = 'roundcube';
$sieverules_config['multiple_actions'] = TRUE;

If I change the conf to
Code: [Select]
$sieverules_config['usetls'] = true;
I see no rules. No error. I can create a rule which will be saved with an ok, but the rules list stays empty.

If I switch back to non-TLS the new rule appears.

The server is an dovecot 1.1.8 with build-in ManageSieve. I tested the managesieve port with telnet and with  gnutls-cli --starttls -p 2000 ssl.foo.de.
It behave the same with non-TLS and TLS.

Mike

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Managesieve patch
« Reply #42 on: January 22, 2009, 03:22:51 AM »
This is a bug in the PEAR::Net_Sieve class (see PEAR :: Bug #14205 :: fetch the CAPABILITY string send after STARTTLS). There is a patch which fixes it so I will apply that in the next release.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline oscar

  • Newbie
  • *
  • Posts: 6
Managesieve patch
« Reply #43 on: January 22, 2009, 09:57:11 AM »
JohnDoh, did you have any further suggestions for the SetFlag issue?

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Managesieve patch
« Reply #44 on: January 22, 2009, 11:01:31 AM »
oscar: please check your private messages. :)
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…