Roundcube 0.2 Stable Signature Fix

[coolsilver]

In my experience, all these patches for moving the signature above the reply in HTML messages break the HTML word wrap. This one is no different.

Seems to me that if you have an HTML Signature, the body text and signature text does not leave a empty line without getting the font style i.e. Bold text. The very top line is the div tag for the signature and anything you type ends up in the div.

I have also seen the word wrap issues.

[zamri]

I just think this mod should be made a plugin.

[schroederman]

i will be the first to announce, sadly, this does NOT work with roundcube v 2.1

i have been playing with it all morning, not happening with my limited knowledge of .js files.

DO NOT upgrade your install if you want to keep this function.

[Napsty]

oh noo! really?
i was just going to install the patch to my 0.2.1 roundcube! but wanted to check for new posts here to not destroy my working 0.2.1.

@a_magoon: is it possible to have the modification only by single line changes? like an overview of all codes which were added and/or replaced?

[pjamedia]

Hi guys,

Here you go for the HTML part of the fix. Only need to update your app.js file.


Cheers.

Aaron M
YourHOST NZ

Aaron,

I must thank you for posting this - it's an excellent mod and I think RC developers should really consider adding this to the core code.

One small issue though using sig in HTML messages when replying, It puts the sig at the top as designed but doesn't leave a blank line above it or move the cursor above the sig as the place you would want to start typing. Is there any quick way to tweak the code to let this happen?

I am using v0.2.1 **UPDATE** It does work fine on my 0.2.1 version - not sure what the difference with my install and the one mentioed 2 posts above is! I had to also install the updated app.js file included in a separate post in this thread to get this working though.

Thanks again,

Paul A

[pjamedia]

Just noticed, When I reply to a HTML message with a HTML signature configured, when I start typing above the signature the words I type don't wrap in the window. I think its something to do with a

Code: [Select]

<pre></pre> tag which is wrapped around the signature. Any ideas how I could format the signature to avoid this?

Thanks, Paul

[pjamedia]

I resolved this issue by editing the html code of the signature in the database itself, removing the PRE tags. Using the Identities editor causes the signature to be wrapped in PRE tags, and these don't support word wrapping.

UPDATE - I didn't realise that you can actually edit the html in the Identities panel! Doh!

This of course would not be an issue if the sig is placed at the very foot of the document As RC is designed to do, but placing it at the top using this mod means that you intend to add your reply directly before your sig, which means you are typing your reply within the PRE tags which form part of the signature code. I can't find a way around this by formatting the signature any differently in the identities editor as PRE tags are always added. This is an oversight therefore on the mod's design. Editing the sig in the database directly is a work around.

Thanks, Paul A

[KenRJ]

Hi guys,

He has added another tick box inside Personal Settings where you can select to have the signature above the text or not. Here we are releasing it for the public to use as they'd like. There's a few modded files, but the originals are in the zip also.

Enjoy! Let me know how you all get on. Possibly add this to the actual package also Admins! Please read the readme also.

Cheers,

Aaron M
YourHOST NZ

I got on very well.

Just needed to discover two clarifications to the instructions:

1) don't forget to apply the patch.sql in the patches folder - another column is needed in the identities table:
ALTER TABLE `identities` ADD COLUMN `signature_above_quoted` tinyint(1) NOT NULL DEFAULT '0';

2) the tick box is under Personal Settings>Identities> and set the tick box for each identity.

Thank you Aaron and your freelancer.  It's a fix which should be in further releases even if only to stir discussion among purists.

[Anonymous]

I guess I am a newbie at this, but where do I edit these files? Thanks.

[mlgreene]

I went to the identities tab and selected the option to put signature at top of quoted message, but when i clicked save, the page just said "SERVICE CURRENTLY NOT AVAILABLE!  Error No. [0x01F4]"  

I replaced all files like explained.  I don't understand why it's not working though.

[rosali]

Did you update the database table identities?

ALTER TABLE `identities` ADD COLUMN `signature_above_quoted` tinyint(1) NOT NULL DEFAULT '0';

[pjamedia]

Will this mod work with the latest release 0.2.2 ??
I'd love it to work but looks like the code in the new app.js is a bit different from in 0.2.1

Thanks, Paul

[redmondtux]

and plugins are supported, can this be made into a plugin?

[ABerglund]

and plugins are supported, can this be made into a plugin?

I hope so...

http://www.roundcubeforum.net/api-based-plugins/5148-plugin-sig-above-reply-option.html

[cafeolai]

$rcmail_config['sig_above'] doesn't work anymore in version 0.3.1.
any idea ? the file app.js seems very different from 0.3

thanks for your help .

Joel