Poll

Do you think right click funtionality is a good idea?

es
181 (91.9%)
o
6 (3%)
aybe
10 (5.1%)
on\'t Care / Know
0 (0%)

Total Members Voted: 193

Author Topic: Right Click Functionality  (Read 70737 times)

Offline mfallon

  • Jr. Member
  • **
  • Posts: 15
Right Click Functionality
« on: February 28, 2009, 02:18:13 PM »
As RoundCube has been developed using AJAX, can I ask if there is any plan to add the ability to right click messages and show a list of functions, such as reply, forward, mark as read, delete, etc. when you right click on a message, or even a folder.

Don't know if anyone has already developed this as a plug-in or if it could only be included in the core build process.

Thanks, Matt

Offline george2390

  • Newbie
  • *
  • Posts: 1
Right Click Functionality
« Reply #1 on: March 05, 2009, 11:36:46 PM »
I think thats a great idea :). I hope they decide to add this to RoundCube:)

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Right Click Functionality
« Reply #2 on: April 27, 2009, 11:19:15 AM »
I have made a plugin which adds a context menu to the message list. You need to latest SVN trunk version to use it. take a look here RoundCube Patches & Plugins
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline lacri

  • Full Member
  • ***
  • Posts: 179
    • http://www.php-lexikon.de
Right Click Functionality
« Reply #3 on: April 28, 2009, 03:22:08 AM »
great work John and works perfect !!!

Can you extend the PlugIn still so far which one several message mark can and if a right click command is given this to all selected messages is applied.

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Right Click Functionality
« Reply #4 on: April 28, 2009, 07:50:27 AM »
lacri: making it work with multiple selection was a good idea, i have modifed the plugin to do this. you can get the new version from the site now.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline lacri

  • Full Member
  • ***
  • Posts: 179
    • http://www.php-lexikon.de
Right Click Functionality
« Reply #5 on: April 28, 2009, 08:03:00 AM »
wow John many many thanks !!!

that could be done fast and this works beautifull !!!

Offline lacri

  • Full Member
  • ***
  • Posts: 179
    • http://www.php-lexikon.de
Right Click Functionality
« Reply #6 on: April 28, 2009, 08:27:06 AM »
Another idea would be right click menu for the folder list is however somewhat more complicated as I thinks one only the messages in the background there for loading would have to those the command to be applied is.

E.g. folder emptying/all messages delete, mark all messages as read/unread …

what do you think?

Offline lacri

  • Full Member
  • ***
  • Posts: 179
    • http://www.php-lexikon.de
Right Click Functionality
« Reply #7 on: April 28, 2009, 09:15:59 AM »
hi John

i have found a little Bug,
Moving Messages to Trash dont work when selecting more than one message. I dont found why.

Thx in advance

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Right Click Functionality
« Reply #8 on: April 28, 2009, 09:54:00 AM »
D'oh you're quite right. Thats what happens when you do things too quickly! There is a new version with multiple delete working.

I'm not sure about context menu on the folder list. From a quick look at the code empty and compact should be possible, mark all as read/unread would be a bit more tricky as we dont have a message list until the folder is open.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline lacri

  • Full Member
  • ***
  • Posts: 179
    • http://www.php-lexikon.de
Right Click Functionality
« Reply #9 on: April 29, 2009, 02:34:57 AM »
Hello John,

a thing has I still discovered if man in the trash folder is should the text in context menu delete messages to have and in all other folder move massage to trash, the ENV Vars be correct and is however not seem set not to be evaluated.

Completely thank you for your assistance and the fantastic Plugin!!!

Offline lacri

  • Full Member
  • ***
  • Posts: 179
    • http://www.php-lexikon.de
Right Click Functionality
« Reply #10 on: April 29, 2009, 10:12:04 AM »
I have found a solution.

add in contextmenu.js after the line
rcmail.add_onload('rcm_contextmenu_load()');
this
rcmail.addEventListener('listupdate', function(evtprops) { rcm_contextmenu_load(); } );
with the Event listupdate reloads the contextmenu_load function and becomes the correct env.mailbox var to display the correct delete Message in context.

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Right Click Functionality
« Reply #11 on: April 29, 2009, 01:35:02 PM »
thanks lacri, i think the delete function really doesnt like me very much. I have made a fix similar to your suggestion. the new version is available now. hopefully that is all the bugs squished.....
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline lacri

  • Full Member
  • ***
  • Posts: 179
    • http://www.php-lexikon.de
Right Click Functionality
« Reply #12 on: April 30, 2009, 02:23:46 AM »
Thanks John works realy good, only the Internet Explorer not like this and will not display the context menu after klicking on a folder.

i use the listupdate Event to reinitilize the rcm_contextmenu_init('messagelist tbody tr');
rcmail.addEventListener('listupdate', function(evtprops) { rcm_contextmenu_init('messagelist tbody tr'); } );and after this works fine in all browsers for me :) i hope this is correct
« Last Edit: April 30, 2009, 08:05:04 AM by lacri »

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Right Click Functionality
« Reply #13 on: April 30, 2009, 12:58:34 PM »
thanks again lacri. I have made the change as you suggested. I am not overly happy with it as i think it means the events are added twice in most cases but i dont have time to look for a better solution right now, if any one has any suggestions please let me know.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more…

Offline mfallon

  • Jr. Member
  • **
  • Posts: 15
Great Work!
« Reply #14 on: May 04, 2009, 11:26:28 AM »
Really nice to see suggestions being implemented, things like this are what makes Roundcube (IMHO) the best opensource webmail client available.

Keep up the good work guys.