Author Topic: Plugin for sig-above-reply option?  (Read 20801 times)

Offline epinter

  • Jr. Member
  • **
  • Posts: 10
Plugin for sig-above-reply option?
« Reply #15 on: October 29, 2009, 01:52:42 PM »
Another version of my patch, this without database change, option per user, not per identity.

#1484272 (Signature above original message on reply) ? Roundcube Webmail

Offline ABerglund

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 673
Plugin for sig-above-reply option?
« Reply #16 on: October 29, 2009, 04:21:08 PM »
Quote from: epinter;22605
Another version of my patch, this without database change, option per user, not per identity.

#1484272 (Signature above original message on reply) ? Roundcube Webmail
This patch failed to install on 3078, failed on the last file. User Prefs are then broken.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

Offline epinter

  • Jr. Member
  • **
  • Posts: 10
Plugin for sig-above-reply option?
« Reply #17 on: October 29, 2009, 06:52:20 PM »
#1484272 (Signature above original message on reply) ? Roundcube Webmail

Quote from: ABerglund;22608
This patch failed to install on 3078, failed on the last file. User Prefs are then broken.

Offline ABerglund

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 673
Plugin for sig-above-reply option?
« Reply #18 on: October 30, 2009, 11:28:18 AM »
Still no joy with the later patch and a fresh copy of 3078. I may need to build a separate box to test this.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

Offline epinter

  • Jr. Member
  • **
  • Posts: 10
Plugin for sig-above-reply option?
« Reply #19 on: October 30, 2009, 01:13:13 PM »
I made the r3078 just after a svn checkout... Look at .rej files to see the rejected lines ...

Quote from: ABerglund;22624
Still no joy with the later patch and a fresh copy of 3078. I may need to build a separate box to test this.

Offline ABerglund

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 673
Plugin for sig-above-reply option?
« Reply #20 on: October 30, 2009, 01:16:54 PM »
There were no rejected lines the second time, all loaded fine. But it the Preferences were still all blank after patching.

I was building this as a second instance on my main RC box, may have something to do with it. When I get some time I'll throw a new VM together and try it there.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

Offline epinter

  • Jr. Member
  • **
  • Posts: 10
Plugin for sig-above-reply option?
« Reply #21 on: October 30, 2009, 07:19:07 PM »
The option is added in Composition options ... Only en_US and pt_BR translations ...
I will test de patch one more time ...
Quote from: ABerglund;22630
There were no rejected lines the second time, all loaded fine. But it the Preferences were still all blank after patching.

I was building this as a second instance on my main RC box, may have something to do with it. When I get some time I'll throw a new VM together and try it there.

Offline ABerglund

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 673
Plugin for sig-above-reply option?
« Reply #22 on: October 30, 2009, 07:43:21 PM »
OK, I built a new virtual machine and installed a totally new DB and installed 3079 on it. This one I was able to patch, and it appears to work fine. The only bug I see on this one is that the signature uses the '--' separator which will cause problems with replies to top-post replies. The patch should not insert the separator when top-posting.
« Last Edit: October 30, 2009, 07:52:37 PM by ABerglund »
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

Offline ABerglund

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 673
Plugin for sig-above-reply option?
« Reply #23 on: October 31, 2009, 06:25:49 PM »
Do we think that either of the non-db changing patches will work on 0.3.1-Stable, now that it has been released?
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

Offline ABerglund

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 673
Plugin for sig-above-reply option?
« Reply #24 on: October 31, 2009, 11:55:55 PM »
Quote from: epinter;22611
#1484272 (Signature above original message on reply) ? Roundcube Webmail
This patch works on 0.3.1-Stable if you use the uncompressed app.js.src in place of the compresses app.js prior to patching.

One last change needed is to remove the '--' signature separator. I did that manually on mine. If possible, perhaps the '--' could be used when bottom-posting, but not when top-posting?
« Last Edit: November 01, 2009, 12:00:06 AM by ABerglund »
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

Offline JohnDoh

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2,845
Plugin for sig-above-reply option?
« Reply #25 on: November 08, 2009, 05:28:19 AM »
the patch has now been applied to the svn trunk. please try it.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and moreā€¦

Offline axelsj

  • Newbie
  • *
  • Posts: 3
Plugin for sig-above-reply option?
« Reply #26 on: November 08, 2009, 06:12:57 PM »
Tested from latest trunk and seems to work great!

I prefer to bottom-post/quote correct on my personal mail, but have been waiting for this feature so we can switch to Roundcube at work... An option to remove the "-- " separator would be great. Maybe as a per-identity setting?

Offline ABerglund

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 673
Plugin for sig-above-reply option?
« Reply #27 on: November 08, 2009, 08:49:59 PM »
I'd recommend that the "-- " continue when bottom-posting, but be removed when top-posting.

But that's actually very niggly to me, I can hunt down the "-- " and remove it if necessary.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

Offline atjensen11

  • Newbie
  • *
  • Posts: 9
Plugin for sig-above-reply option?
« Reply #28 on: November 13, 2009, 09:34:11 PM »
I had just posted a topic in the forum for 0.3 prior to finding this thread.  I was asking if it was possible to configure an option to top/bottom post through the existing setup.

I have a stable version of 0.3.1 installed.  Can someone document for me  the steps required in order to apply this patch?

I have a lot of experience with plugins and patches on Squirrelmail.  But I am looking at moving to Roundcube in the very near future and this is one feature my users are going to demand.

Offline ABerglund

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 673
Plugin for sig-above-reply option?
« Reply #29 on: November 13, 2009, 09:59:02 PM »
The second patch found here can be applied to 0.3.1-stable, if you use the non-optimized app.js. In Linux, do the following:

1.) Backup the optimized program/js/app.js file.
Code: [Select]
$ mv app.js app.js-dist
$ cp -p app.js.src app.js

2.) Then apply the patch. I found that the file paths in the patch are goofy, so you'll need to manually enter the correct path as the files are patched.
Code: [Select]
$ patch -bi
3.) Last, edit the app.js to either remove the '-- ' signature separator or change it to something else. Leaving that separator in place will cause your top-posting users no end of grief.

Or you can take the simpler way - the patch has been incorporated into SVN release r3087 and later, and will be included in the next stable release. Although when I looked at the current SVN (3107) I noticed the '-- ' separator was still in place and will need fixing. I think I'll try to submit a bug report on that. That needs to be handled before it reaches general release.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA