Author Topic: addressbook in compose window (Read 92872 times)

corbosman · « **Reply #120 on:** July 03, 2010, 06:45:14 PM »

Just to see if this works, is this any better. Has search on top, and some css changes.

http://wa.ter.net/download/compose_addressbook-2.11.tgz

ABerglund · « **Reply #121 on:** July 03, 2010, 09:40:37 PM »

Quote from: corbosman;28492

Just to see if this works, is this any better. Has search on top, and some css changes.

http://wa.ter.net/download/compose_addressbook-2.11.tgz

The Copy and BCC buttons don't work for me - Safari 5 on Mac.

Edit - Just retested 2.1 - same there, no Copy or BCC function.

rosali · « **Reply #122 on:** July 04, 2010, 01:08:48 AM »

v2.11 looks fine to me.

Edit: I got cs_CZ translation from a user:

<?php
$labels = array();
$labels['compose_addressbook_buttontitle'] = 'Zobrazit adresář';
$labels['compose_addressbook_title'] = 'Adresář';
$labels['compose_addressbook_close'] = 'Zavřít';
$labels['compose_addressbook_noselect'] = 'Nevybral(a) jste adresu';
$labels['compose_addressbook_added'] = 'Adresy byly přidány';
?>

corbosman · « **Reply #123 on:** July 04, 2010, 05:43:57 AM »

Arne, let me guess, thats the latest SVN? There is something around 3798 that seems to mess things up. At 3797 it works fine for me on safari 5 on mac.

corbosman · « **Reply #124 on:** July 04, 2010, 06:09:14 AM »

Actually Arne, I cant reproduce this. I have Safari on a mac as well, and for me it works fine with latest SVN. What version of RC are you using?

corbosman · « **Reply #125 on:** July 04, 2010, 07:44:33 AM »

Rosali, I think something simple like this would work. Since you also use it for your calendar plugins, just want to make sure this would work for you. This includes the whole jquery UI package, and im using the smoothness theme since I think it looks almost identical to the roundcube default theme.

class jqueryui extends rcube_plugin
{

  public function init()
  {
    $this->add_hook('render_page', array($this, 'add_jqueryui'));
  }

  function add_jqueryui($args)
  {
    $skin_path = $this->local_skin_path();

    // jquery UI
    $this->include_script('js/jquery-ui-1.8.2.custom.min.js');

    // jquery UI stylesheet
    $this->include_stylesheet("$skin_path/css/smoothness/jquery-ui-1.8.2.custom.css");
  }
}

rosali · « **Reply #126 on:** July 04, 2010, 07:56:40 AM »

Thanks, this will do the job.

Do you have any idea how to solve css conflicts on a top level way? F.e. keyboard_shortcuts uses the darkness theme and I like that. Your compose_addressbook and my calendar plugin use smoothness theme.

I have no idea how to solve it on a top level. Currently I decide what css is included by checking _task / _action. There must be a way to change the css on the client side by js. But I'm not very skilled in js ...

corbosman · « **Reply #127 on:** July 04, 2010, 08:17:09 AM »

I think we should pick a default theme as the general theme. I think that should be smoothness as it's very very close to default RC theme.

If a plugin wants to use a different theme, I think it's possible by overriding the theme with their own, like this:

They can download their theme, and in advanced settings provide a scope. In this example I added the scope '.keyboard_shortcuts'. Then, the plugin would need to add the class .keyboard_shortcuts' to all their UI elements. Then they add that css from their own plugin.

I havent tested this, but this is how you should do this according to the jquery site.

corbosman · « **Reply #128 on:** July 04, 2010, 08:37:51 AM »

Ok, I have tested this at it seems to work at least for my specific test. I downloaded a jquery-ui theme with scope 'compose_addressbook_ui', and then added this to the dialog javascript:

dialogClass: 'compose_addressbook_ui'

And now my dialog uses the ui-lightness theme instead of smoothness, even though both themes are loaded. I can see in firebug that my dialogs are using the lightness scope (.compose_addressbook_ui .ui_dialog ... ) and are overriding the smoothness theme.

Im not sure about other jquery-UI elements, but as long as you can provide a class to your UI elements, you can use this method.

corbosman · « **Reply #129 on:** July 04, 2010, 09:14:38 AM »

I've released the jqueryui plugin, here's the thread:

http://www.roundcubeforum.net/7-third-party-contributions/46-api-based-plugins/6959-jquery-ui-roundcube-plugins.html

ABerglund · « **Reply #130 on:** July 04, 2010, 11:52:25 AM »

Quote from: corbosman;28502

Arne, let me guess, thats the latest SVN? There is something around 3798 that seems to mess things up. At 3797 it works fine for me on safari 5 on mac.

Quote from: corbosman;28503

Actually Arne, I cant reproduce this. I have Safari on a mac as well, and for me it works fine with latest SVN. What version of RC are you using?

Actually, I'm holding my almost-production system at r3786, until the compose window/attachment bug in the newer releases (Safari5 on Windows) is corrected. I do have a later SVN I can test on, but I'm having some problems today VPNing into the network core. I'll try on the newer version when I get a chance.

ABerglund · « **Reply #131 on:** July 04, 2010, 12:22:10 PM »

Duplicate post deleted.

corbosman · « **Reply #132 on:** July 07, 2010, 04:25:50 AM »

rosali, can you mail me the cs_CZ translation? I cant cut/paste those characters. I dont want to run the risk that they get mangled in copying.

cor at in.ter.net

corbosman · « **Reply #133 on:** July 07, 2010, 04:30:15 AM »

I just released version 2.2 of this plugin with some layout changes. IMPORTANT: this version depends on the jqueryui plugin, which you can get at the same download link

Roundcube Plugins | Underwater World

rosali · « **Reply #134 on:** July 07, 2010, 04:55:30 AM »

Sure, I'll mail you the file.