Author Topic: addressbook in compose window  (Read 60395 times)

Offline jeffshead

  • Full Member
  • ***
  • Posts: 71
addressbook in compose window
« Reply #180 on: May 02, 2011, 03:26:07 PM »
Quote from: sckramer;33961
confirmed that it shows Username <> in...


Can you please provide a fix for 0.5.2?

Offline corbosman

  • Sr. Member
  • ****
  • Posts: 260
addressbook in compose window
« Reply #181 on: May 02, 2011, 04:45:01 PM »
Did you try the latest version to see if it works?

Offline jeffshead

  • Full Member
  • ***
  • Posts: 71
addressbook in compose window
« Reply #182 on: May 02, 2011, 04:58:54 PM »
Quote from: corbosman;34561
Did you try the latest version to see if it works?


Do you mean try compose_addressbook-5.0beta1.tgz with RoundCube 0.5.2 or try RoundCube 0.6?

I did not want to use RC 0.6 because I believe some of the other plugins I use have not been updated to work with 0.6.

I did not try compose_addressbook-5.0beta1.tgz with RoundCube 0.5.2 because of your warning (only use with roundcube 0.6 svn+, do NOT use with roundcube 0.5.x)

Offline corbosman

  • Sr. Member
  • ****
  • Posts: 260
addressbook in compose window
« Reply #183 on: May 02, 2011, 05:00:53 PM »
You can try compose_addressbook-5.0beta1.tgz to see if it works for 0.5.2. Probably not.

and compose_addressbook-4.0 doesnt work?  What's not working?

Offline ABerglund

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 673
addressbook in compose window
« Reply #184 on: May 02, 2011, 05:06:32 PM »
compose_addressbook-4.0 is working for me just fine in roundcube 0.5.2.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

Offline jeffshead

  • Full Member
  • ***
  • Posts: 71
addressbook in compose window
« Reply #185 on: May 02, 2011, 05:29:08 PM »
Quote from: corbosman;34568
You can try compose_addressbook-5.0beta1.tgz to see if it works for 0.5.2. Probably not.

and compose_addressbook-4.0 doesnt work?  What's not working?


When using the 'compose_addressbook-4.0.tgz' with RC 0.5.2 trunk 4713, I have the same issue as others. When I select someone from the address book, it adds Displayname<> to the To field. It does not add the email address.

I just tested 'compose_addressbook-5.0beta1.tgz' with RC 0.5.2 trunk 4713 and that seems to have fixed that particular issue but I'm wondering if any other issues will become evident since this version is designed for RC 0.6.
« Last Edit: May 02, 2011, 05:31:43 PM by jeffshead »

Offline corbosman

  • Sr. Member
  • ****
  • Posts: 260
addressbook in compose window
« Reply #186 on: May 02, 2011, 05:35:55 PM »
4713 is newer than 0.5.2 (4699). You must have gotten 0.6 beta code, because the only changes between 4.0 and 5.0 of my plugin are vcard changes that were done in RC 0.6. If 5.0beta1 works, then you're safe to use it.

Offline jeffshead

  • Full Member
  • ***
  • Posts: 71
addressbook in compose window
« Reply #187 on: May 02, 2011, 06:00:25 PM »
Quote from: corbosman;34576
4713 is newer than 0.5.2 (4699). You must have gotten 0.6 beta code, because the only changes between 4.0 and 5.0 of my plugin are vcard changes that were done in RC 0.6. If 5.0beta1 works, then you're safe to use it.


Thanks! I'll keep testing.

Offline corbosman

  • Sr. Member
  • ****
  • Posts: 260
addressbook in compose window
« Reply #188 on: May 10, 2011, 02:33:33 AM »
I uploaded a new version of compose_addressbook, 5.0b2 that uses roundcube's version of jqueryui instead of my version by requiring it as per the new plugin_require function. No need to configure jqueryui in the main config anymore. Remember to stop using my jqueryui plugin, and use the one from roundcube core instead!

You can get the new compose_addressbook here:  Downloads - roundcube-plugins - Roundcube Plugins - Google Project Hosting

Offline ABerglund

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 673
addressbook in compose window
« Reply #189 on: May 10, 2011, 11:10:33 AM »
Quote from: ABerglund;34570
compose_addressbook-4.0 is working for me just fine in roundcube 0.5.2.
Just a quick note - while compose_addressbook-4.0 does function for me in RC 0.5.2, further testing has revealed one anomaly. Once the "Loading..." dialog drops down when the search begins, it never goes away throughout the remainder of the compose session.

I'm not certain if this is strictly a compose_addressbook issue, or part of a larger bug in RC 0.5.2. In general, I see a lot more "Loading", "Moving" and "Deleting" dialogs that are reluctant to go away in RC 0.5.2. And I've already gone into the code and disabled a few of the dialog prompts.

EDIT - I think this is in RC, not the plugin. I get the hanging "Loading..." too often in other places as well.
« Last Edit: May 10, 2011, 11:53:53 AM by ABerglund »
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

Offline corbosman

  • Sr. Member
  • ****
  • Posts: 260
addressbook in compose window
« Reply #190 on: May 10, 2011, 06:34:21 PM »
Try version 4.1, is that better?

Offline corbosman

  • Sr. Member
  • ****
  • Posts: 260
addressbook in compose window
« Reply #191 on: May 10, 2011, 06:40:02 PM »
Oh, btw, it is the plugin. Multiple plugins. Every plugin that tries to show the spinning busy ball. This is because RC a few versions ago changed the way you have to call that function, and in the process broke every plugin using it, resulting in the sticky loading msg.

Old code:

    rcmail.set_busy(true, 'loading');
    rcmail.http_post('plugin.get_addressbook', '', true);


New code:

    lock = rcmail.set_busy(true, 'loading');
    rcmail.http_post('plugin.get_addressbook', '', lock);

Offline ABerglund

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 673
addressbook in compose window
« Reply #192 on: May 10, 2011, 06:56:34 PM »
Ahh! That makes sense. I searched my install for the rcmail.set_busy string, and found it in two plugins. The version of compose_addressbook I'm using had two instance that were correct, but one that was not. After changing that, it works perfectly.

I also found the old code in contextmenu. I corrected that one too, we'll see if that makes me any happier with 0.5.2 in general. The spinning wheel has been very annoying.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

Offline cityhunter

  • Jr. Member
  • **
  • Posts: 15
addressbook in compose window
« Reply #193 on: May 11, 2011, 10:54:24 AM »
thanks for the nice plugin , have plan to add check box for address list choice?

Offline corbosman

  • Sr. Member
  • ****
  • Posts: 260
addressbook in compose window
« Reply #194 on: May 11, 2011, 10:58:26 AM »
I dont understand what you mean.