Author Topic: Signature Above Quoted Text in a Reply...  (Read 19486 times)

Offline Scubes13

  • Jr. Member
  • **
  • Posts: 48
Signature Above Quoted Text in a Reply...
« on: September 21, 2006, 04:12:01 PM »
It would be nice if one could set their preferences to place their signature above the quoted text when replying to an email.

I know it might not be the best Net-ettiquette (think I even spelled it wrong) - but in Thunderbird, I have my sig automatically placed above the quoted text.

In roundcube I have to scroll to the bottom of the message, grab the sig, then cut and paste it to the top of the new message.

Anyone have any suggestions as to how we might make this happen?

Kevin L.

Offline LeviFig

  • Newbie
  • *
  • Posts: 1
Re: Signature Above Quoted Text in a Reply...
« Reply #1 on: September 28, 2006, 06:25:24 PM »
I hear ya m8 =)
I do the same everywhere... can't stand the idea of someone having to scroll allllll the way down a long quote for ex. just to check my sig (which is something I definetly want people to look at - hence it's purpose :p)

Let's w8 and see if the devs check this =) (it can be a challenge code-wise... I don't know... maybe not:p)


ch33rs,
~Levi F. aka EinZteiN

Offline yllar

  • Full Member
  • ***
  • Posts: 106
Re: Signature Above Quoted Text in a Reply...
« Reply #2 on: September 29, 2006, 03:20:39 PM »
imho top-posting is not very comford to read and therefore cursor should go to the bottom of the mail when replying .. right where the signature is :)
irc://irc.freenode.net:6667/#roundcube

reefnet

  • Guest
Re: Signature Above Quoted Text in a Reply...
« Reply #3 on: September 29, 2006, 05:32:50 PM »
I agree...DOWN [sic] WITH TOP POSTING!! The default should be bottom posting, perhaps with an option to use top-posting if you really must (don't do it!).

Offline goettler

  • Newbie
  • *
  • Posts: 2
Re: Signature Above Quoted Text in a Reply...
« Reply #4 on: October 14, 2006, 12:35:52 AM »
Seems like this is a question of taste. I personally also prefer the signature above the quoted text...this makes it easier to read for long email chains with different senders.

For all those interested, this is an easy fix in 'app.js'. Simply modify the code as follows:

// add the new signature string
  if (this.env.signatures && this.env.signatures[id])
   {
   sig = this.env.signatures[id];
   if (sig.indexOf('--')!=0)
   sig = '--\n'+sig;
   message += '\n'+sig;
   message = '\n\n'+sig+'\n\n'+message;
   }

Offline zyzzyvas

  • Jr. Member
  • **
  • Posts: 20
Re: Signature Above Quoted Text in a Reply...
« Reply #5 on: October 14, 2006, 09:57:00 AM »
Top/bottom posting is partly an issue of taste, but mostly an issue of netiquette. And common sense.

because it breaks the flow of conversation.
The main reason you should NOT top post is...


But there are plenty of other good reasons [http://www.caliburn.nl/topposting.html]. Basically, remember that your email is written for someone ELSE to read, not you. Make it easy for the recipient to understand and reply to himself.

That also means not quoting the whoooole message in a reply. As a general rule, if the amount of quoted text in your email is more than your own text, you have probably quoted too much.

Offline DarthNerdus

  • Newbie
  • *
  • Posts: 1
Re: Signature Above Quoted Text in a Reply...
« Reply #6 on: November 16, 2007, 09:58:48 PM »
I agree with the arguments for bottom-posting. But is there a good script that would really make RoundCube set it's compose page up for bottom posting well?

I'd just like to see it maybe move the cursor below the quoted message and above the signature or something. Thanks for any input!


Offline delsurf

  • Newbie
  • *
  • Posts: 2
Re: Signature Above Quoted Text in a Reply...
« Reply #7 on: January 16, 2008, 09:20:28 AM »
Thanks for this fix, just what I was looking for!

Offline buglerroller

  • Newbie
  • *
  • Posts: 3
Re: Signature Above Quoted Text in a Reply...
« Reply #8 on: February 07, 2008, 03:12:16 PM »
Quote from: delsurf
Thanks for this fix, just what I was looking for!

are you using v0.1-rc2? if so what did you do. the code on v0.1-rc2 is;
Code: [Select]
// add the new signature string
   if (this.env.signatures && this.env.signatures[id])
    {
    sig = this.env.signatures[id]['text'];
    if (this.env.signatures[id]['is_html'])
     {
     sig = this.env.signatures[id]['plain_text'];
     }
    if (sig.indexOf('-- ')!=0)
     sig = '-- \n'+sig;
    message += '\n'+sig;
    }
   }

when i remove the line message += '\n'+sig; no signature appears.
my personal site www.buglerroller.com

Offline buglerroller

  • Newbie
  • *
  • Posts: 3
Re: Signature Above Quoted Text in a Reply...
« Reply #9 on: February 07, 2008, 03:22:42 PM »
ahh i get it now.. replace

message += '\n'+sig;

with
   message = '\n\n'+sig+'\n\n'+message;

my personal site www.buglerroller.com

Offline pinhead

  • Newbie
  • *
  • Posts: 1
Re: Signature Above Quoted Text in a Reply...
« Reply #10 on: March 16, 2008, 06:21:35 AM »
Tried this for the current version, 0.1, but it doesn't work. The signature keeps appearing at the bottom.

I have emptied my caches, logged out and back in but to no avail. Any ideas?

Nevermind, I made a typo...

Offline jimcavoli

  • Jr. Member
  • **
  • Posts: 37
Re: Signature Above Quoted Text in a Reply...
« Reply #11 on: March 27, 2008, 12:37:41 AM »
I think this should be the out-of-the-box default, especially since a)it reads easier, and b)clients like GMail which collapse quoted text will usually pull the sig into that as well.

Offline smultronstallet

  • Jr. Member
  • **
  • Posts: 11
Signature Above Quoted Text in a Reply...
« Reply #12 on: June 21, 2008, 01:28:19 AM »
Quote from: goettler;3200
Seems like this is a question of taste. I personally also prefer the signature above the quoted text...this makes it easier to read for long email chains with different senders.

For all those interested, this is an easy fix in 'app.js'. Simply modify the code as follows:

// add the new signature string
  if (this.env.signatures && this.env.signatures[id])
   {
   sig = this.env.signatures[id];
   if (sig.indexOf('--')!=0)
   sig = '--\n'+sig;
   message += '\n'+sig;
   message = '\n\n'+sig+'\n\n'+message;
   }


This only seem to work in plain-text mode. Is there anyway to get it working with HTML/TinyMCE too? (Using 0.1.1)

Offline Sam Treadway

  • Newbie
  • *
  • Posts: 1
HTML signatures appear at the top
« Reply #13 on: October 10, 2008, 10:44:49 PM »
To have HTML signatures appear at the top of replies and forwards do the following:
Find the file named: "app.js"

search for the following line:
Code: [Select]
editor.getBody().appendChild(sigElem);

Comment the line out or replace with the following code:
Code: [Select]
editor.getBody().insertBefore(sigElem, editor.getBody().firstChild );

If anyone wants to take a stab at a patch with this as an option (tick box) please post it here, thanks! ;D

Offline Sverre

  • Newbie
  • *
  • Posts: 1
For HTML emails
« Reply #14 on: November 10, 2008, 10:51:32 AM »
Sam beat me to it! I came here a few days ago, went away and came up with almost the same thing:

editor.getBody().insertBefore(sigElem, editor.getBody().getElementsByTagName("p")[0]);

I missed using firstChild!

Regards,
Sverre :-)
« Last Edit: November 10, 2008, 10:55:54 AM by Sverre »