Author Topic: RoundCube Calendar (jQuery Calendar)  (Read 55366 times)

Offline zlp

  • Newbie
  • *
  • Posts: 7
calendar event timing is wrong
« Reply #30 on: February 10, 2010, 12:14:47 PM »
Hi. Thanks for a great plugin.

When I add an event to the monthly view, it shows up on the day before. (the database contains this erroneous date too - it's not just a display problem). When I add an event to the weekly or daily view, it appears on the correct day but 2 hours earlier than intended. When I drag it to a new time, it appears 2 hours before the time where I drop it.

Regarding the timezone problem from a previous post: My client and server are in different time zones (server is GMT -8, client is GMT -6) but it is currently 12PM, so I don't understand why the day is wrong too.

my info:
Calendar 0.2 beta
Roundcube 0.3.1

I applied both patches mentioned by Lacri:
http://www.roundcubeforum.net/7-third-party-contributions/46-api-based-plugins/6161-roundcube-calendar-jquery-calendar-7.html#post25365

http://www.roundcubeforum.net/7-third-party-contributions/46-api-based-plugins/6161-roundcube-calendar-jquery-calendar-8.html#post25408

Offline Lazlo

  • Full Member
  • ***
  • Posts: 50
RoundCube Calendar (jQuery Calendar)
« Reply #31 on: February 10, 2010, 12:39:45 PM »
Please try the latest development version: LazloNL's roundcube-calendar at master - GitHub

There were some timezone changes.

Offline xrxca

  • Jr. Member
  • **
  • Posts: 22
RoundCube Calendar (jQuery Calendar)
« Reply #32 on: February 10, 2010, 05:04:34 PM »
The version from GitHub fixed the timeout issues I was having, but the code to get the skin directory is a problem,
    // add styles
    
$skin $rcmail->config->get('skin');
    
$this->include_stylesheet($skin 'calendar.css');


What your doing here is getting the current skin name and using it whether the skin exists for the calendar plugin or not and it is missing a / as well.

Would probably be better with something like this (basically taken from local_skin_path which has never worked for me under anything but the actual mail page)

  function skinPath($skinfile '') {
    
$rcmail rcmail::get_instance();
    
$skin_path 'skins/'.$rcmail->config->get('skin');
    if (!
is_dir(realpath(slashify($this->home) . $skin_path)))
          
$skin_path 'skins/default';
    return(
$skin_path '/' $skinfile);
  }


Then the above becomes:
    // add styles
    
$skin =  $this->skinPath();
    
$this->include_stylesheet($skin 'calendar.css');

or more succently:
$this->include_stylesheet($this->skinPath('calendar.css'));
« Last Edit: February 10, 2010, 05:15:09 PM by xrxca »

Offline zlp

  • Newbie
  • *
  • Posts: 7
still busted
« Reply #33 on: February 10, 2010, 07:13:12 PM »
I tried the GitHub version and the calendar formatting went crazy. (calendar icon was now the same as email icon, no table gridlines, just a jumble of numbers in the center of the screen.)

I made the changes suggested by xrxca and the icon came back but the formatting is still wrong. (screenshot attached)

I've never uses GitHub, so maybe I got the wrong files somehow?

Offline xrxca

  • Jr. Member
  • **
  • Posts: 22
RoundCube Calendar (jQuery Calendar)
« Reply #34 on: February 10, 2010, 09:45:23 PM »
Quote from: zlp;25428
I made the changes suggested by xrxca and the icon came back but the formatting is still wrong. (screenshot attached)


There is more than one place the change needs to be done:
The above change needs to be done as well as the following (sorry I should have been clearer)
From:
    $skin $rcmail->config->get('skin');
    
$this->include_stylesheet($skin 'jquery-ui.css');
    
$this->include_stylesheet($skin 'fullcalendar.css');

To:
    $skin =  $this->skinPath();
    
$this->include_stylesheet($skin.'jquery-ui.css');
    
$this->include_stylesheet($skin.'fullcalendar.css');


And the skinPath function isn't necessarily the best, it should really check the existence of the actual file in the custom skin directory and be used like the second example in my prior post, but as is it works with this second change.

Offline batemice

  • Newbie
  • *
  • Posts: 3
RoundCube Calendar (jQuery Calendar)
« Reply #35 on: February 10, 2010, 10:43:19 PM »
Here's a Bulgarian translation for the plugin ;)

Offline Lazlo

  • Full Member
  • ***
  • Posts: 50
RoundCube Calendar (jQuery Calendar)
« Reply #36 on: February 11, 2010, 01:12:10 PM »
Quote from: batemice;25434
Here's a Bulgarian translation for the plugin ;)


Added translation to development version. Thank you.

Offline Lazlo

  • Full Member
  • ***
  • Posts: 50
RoundCube Calendar (jQuery Calendar)
« Reply #37 on: February 11, 2010, 01:34:51 PM »
Quote from: zlp;25428
I tried the GitHub version and the calendar formatting went crazy. (calendar icon was now the same as email icon, no table gridlines, just a jumble of numbers in the center of the screen.)

I made the changes suggested by xrxca and the icon came back but the formatting is still wrong. (screenshot attached)

I've never uses GitHub, so maybe I got the wrong files somehow?


Check out latest development version. I think the skin problem is fixed now.

Offline zlp

  • Newbie
  • *
  • Posts: 7
RoundCube Calendar (jQuery Calendar)
« Reply #38 on: February 11, 2010, 01:35:26 PM »
(edited to reduce confusion)

Thanks xrxca and Lazlo. I can confirm that the time shifting event issues from my previous post + the skin problems are fixed in today's github version. Thanks.
« Last Edit: February 11, 2010, 03:16:10 PM by zlp »

Offline Lazlo

  • Full Member
  • ***
  • Posts: 50
RoundCube Calendar (jQuery Calendar)
« Reply #39 on: February 11, 2010, 06:15:36 PM »
Just released 0.2 BETA 2: RoundCube Calendar

CHANGELOG since 0.2 BETA:
- basic event categories
- export calendar to ICS
- default view option
- several small bug fixes

@Translators,
there are some new strings to translate. New translations are welcome!

Offline lacri

  • Full Member
  • ***
  • Posts: 179
    • http://www.php-lexikon.de
RoundCube Calendar (jQuery Calendar)
« Reply #40 on: February 12, 2010, 09:01:10 AM »
great great ... the categorys are cool :) many thanks

Offline sckramer

  • Jr. Member
  • **
  • Posts: 17
multiple / shared
« Reply #41 on: February 12, 2010, 01:28:26 PM »
looks really nice so far!!

With the db design etc, are you guys thinking about how in the future to add features like: multiple cals per account, and sharing cals with other accounts?

Thanks!
« Last Edit: February 16, 2010, 10:58:22 AM by sckramer »

Offline Lazlo

  • Full Member
  • ***
  • Posts: 50
RoundCube Calendar (jQuery Calendar)
« Reply #42 on: February 12, 2010, 06:23:43 PM »
Haven't planned to add sharing of cals with other users.

Only planned feature (before stable release) is a print feature (which rosali is working on), like Google Calendar's Agenda view. To easily print your events.

Offline batemice

  • Newbie
  • *
  • Posts: 3
RoundCube Calendar (jQuery Calendar)
« Reply #43 on: February 14, 2010, 07:43:52 PM »
Updated Bulgarian translation for Beta 2:

Offline Lazlo

  • Full Member
  • ***
  • Posts: 50
RoundCube Calendar (jQuery Calendar)
« Reply #44 on: February 15, 2010, 05:25:55 AM »
Thanks, updated in the development version.