Author Topic: Recipient To Contacts Plugin  (Read 11698 times)

Offline billstif

  • Jr. Member
  • **
  • Posts: 37
Bug fix for .5.2?
« Reply #30 on: May 01, 2011, 07:09:40 PM »
This plugin does not work in .5.2.  Is there an upgrade available?

Offline lacri

  • Full Member
  • ***
  • Posts: 179
    • http://www.php-lexikon.de
Recipient To Contacts Plugin
« Reply #31 on: June 08, 2011, 06:33:14 AM »
i have found the issue
remove this two lines in recipient_to_contact.php

in function get_contacts()
$this->rcmail->session->regenerate_id();
$this->rcmail->session->set_auth_cookie();
now works in my rc 0.5.3 installation.

i hope this helps ;)

and the second issue is in recipient_to_contact.js
in the save_contacts: function()
search
Code: [Select]
rcmail.display_message(rcmail.gettext('loading'), 'loading', true);and replace with
Code: [Select]
var lock = rcmail.set_busy(true, 'loading');and search
Code: [Select]
rcmail.http_post('plugin.recipient_to_contact_save_contacts', data);and replace with
Code: [Select]
rcmail.http_post('plugin.recipient_to_contact_save_contacts', data, lock);
now works fine for me
« Last Edit: June 08, 2011, 06:46:49 AM by lacri »

Offline billstif

  • Jr. Member
  • **
  • Posts: 37
Recipient To Contacts Plugin
« Reply #32 on: June 08, 2011, 10:22:40 PM »
I made the changes.  The loading message still remained, and the plugin was caught in an endless loop.  Whenver I went to the e-mail page, the dialog box for saving the contact would appear.

Offline billstif

  • Jr. Member
  • **
  • Posts: 37
Recipient To Contacts Plugin
« Reply #33 on: June 09, 2011, 12:50:48 PM »
The version of the plugin that I have did not have the line

$this->rcmail->session->set_auth_cookie();

Would you consider posting your version of the plugin as a zip file here?

Offline projectmyst

  • Jr. Member
  • **
  • Posts: 30
Recipient To Contacts Plugin
« Reply #34 on: June 09, 2011, 07:35:42 PM »
I all so have this problem, i made the changes. The loading message still remained, and the plugin is caught in an endless loop.

Any one know how to fix it?

Offline rosali

  • Hero Member
  • *****
  • Posts: 2,533
Recipient To Contacts Plugin
« Reply #35 on: November 04, 2011, 12:35:25 AM »
A question:

Why is the regenerate_id on line 189?
« Last Edit: November 21, 2011, 12:26:22 AM by rosali »
Regards,
Rosali
__________________
MyRoundcube Project (commercial)

Offline billstif

  • Jr. Member
  • **
  • Posts: 37
Recipient To Contacts Plugin
« Reply #36 on: November 20, 2011, 10:56:30 PM »
Following Rosali's lead, I disabled the regenerated_id line.  The plugin now works, but I still cannot get rid of the Loading message that continues after the dialog box closes.  I made the adjustments Lacri suggested and even tried disabling the loading lines in the js file, but no luck.

Offline cornfeed

  • Newbie
  • *
  • Posts: 8
just noticed this thread
« Reply #37 on: December 13, 2011, 05:43:36 PM »

Offline billstif

  • Jr. Member
  • **
  • Posts: 37
Recipient To Contacts Plugin
« Reply #38 on: December 13, 2011, 08:39:18 PM »
The package I downloaded must be numbered differently.  Line 202 in the php file (regenerate_id) was line 200.

Can you tell me what is in the lines in the js file to remove, and what should precede the new lines to be added so I can be sure of making the correct changes?

Offline cornfeed

  • Newbie
  • *
  • Posts: 8
Recipient To Contacts Plugin
« Reply #39 on: December 13, 2011, 11:04:31 PM »
recipient_to_contact.js diff patch
Code: [Select]
212c212
<             rcmail.display_message(rcmail.gettext('loading'), 'loading', true);
---
>             var msgid = rcmail.set_busy(true, 'loading');
214c214
<             rcmail.http_post('plugin.recipient_to_contact_save_contacts', data);
---
>             rcmail.http_post('plugin.recipient_to_contact_save_contacts', data+'&_unlock='+msgid);
266d265
<
319,320d317
<         // enable the &quot;loading&quot; message
<         rcmail.display_message(rcmail.gettext('loading'), 'loading', true);
345,347d341
<
<         // disable the &quot;loading&quot; message
<         rcmail.display_message(rcmail.gettext('loading'), 'loading', false);


recipient_to_contact.php diff patch
Code: [Select]
202d201
<             $this->rcmail->session->regenerate_id();


If you don't know how to apply/read diff patches, or just don't have access to the shell, read How to read a patch or diff and understand its structure to apply it manually ยป markusbe.com. It will explain the basics of reading patch files.
These patches were made from a fresh download of the plugin.

Offline kionez

  • Newbie
  • *
  • Posts: 2
rouncube 0.7
« Reply #40 on: January 03, 2012, 08:45:58 AM »
Hi all,

is there anyone who use this plugin with the new roundcube (0.7)?

Thanks in advance

k.
« Last Edit: January 03, 2012, 08:55:54 AM by kionez »

Offline cornfeed

  • Newbie
  • *
  • Posts: 8
Re: Recipient To Contacts Plugin
« Reply #41 on: July 18, 2012, 02:13:41 PM »
I do, works fine. but needs updating