Author Topic: [0.6] Roundcube CardDAV Plugin  (Read 42070 times)

Offline huhn_m

  • Newbie
  • *
  • Posts: 7
Re: [0.6] Roundcube CardDAV Plugin
« Reply #60 on: February 04, 2013, 08:42:12 AM »
Thanks for the nice and constructive comment, mbsouth. Really makes you feel your contribution is valued in this community .... not ...

It works for me. With the div presented above and honestly I could care less if it works for others. Which "Methoden in RC0.9" should I look at? I investigated the git head database abstractions and came up with this - for me working - solution. And I don't care for the other 3rd party plugins. I don't want to fix all problems but only mine.

But why bother. Owncloud 5 will have its own mail program and obsolete roundcube for me anyways.
« Last Edit: February 04, 2013, 08:44:26 AM by huhn_m »

Offline mbsouth

  • Full Member
  • ***
  • Posts: 71
Re: [0.6] Roundcube CardDAV Plugin
« Reply #61 on: February 05, 2013, 02:39:49 PM »


Quote
...contribution is valued in this "community"...
As you have already said is this is a "user to user community".

Quote
I don't want to fix all problems but only mine.
You just solves your problems but you want constructive comments ;-)

Quote
...And I don't care for the other 3rd party plugins....
That's right. Changes in source code belongs to the author's code repository - or fork it the right way.

"rcube_contacts" doesn't use num_rows() any more because PDO does not offer a function like "num_rows", it only offers "rowCount()"  which returns the number of affected rows. Just in this case, in MySQL, the effect is the same - "rowCount" returns the number of rows in a select - but this behavior does not necessarily extend to other databases. http://php.net/manual/en/pdostatement.rowcount.php

Instead the code above
Code: [Select]
($rcmail->db->affected_rows($result))you can also use
Code: [Select]
...( 0 == 0 )...it has no effect and isnĀ“t a solution! Other methods and a source code revision are necessary.

The best way in this case:  contact the author.
https://github.com/graviox/Roundcube-CardDAV/issues

just my 2 cents
mbsouth

Offline huhn_m

  • Newbie
  • *
  • Posts: 7
Re: [0.6] Roundcube CardDAV Plugin
« Reply #62 on: February 12, 2013, 10:14:31 AM »
Not sure if trolling ....

My patches REPLACED the affected_rows commands with the correct SQL queries that do return the rowcount in a result. Are you sure you wanted to reply to me? Could you please re-read my posts?

Offline nerbrume

  • Jr. Member
  • **
  • Posts: 11
Re: [0.6] Roundcube CardDAV Plugin
« Reply #63 on: March 07, 2013, 05:48:00 AM »
Hi,
I'm in the same situation as oldschool : huhn_m patches are not working for me, and replacing num_rows with affected_rows (yes, I know it's bad) almost works, except for contact creation. In my logs, I get the following errors : "CardDAV-Server XML-Response is malformed. Synchronization aborted!"(affected_rows method) or "Couldn't delete CardDAV-Contact from the local database with the vCard id" (huhn_m method).
This is happening with davical and owncloud (sabreDav-based).
note : I have applied the patches explained here, since this error was happening to me even on RC 8.4

Oldschool, how did you solved this ?

Does anyone have an idea of where this might come from ?
« Last Edit: March 07, 2013, 05:58:44 AM by nerbrume »

Offline oldschool

  • Sr. Member
  • ****
  • Posts: 406
Re: [0.6] Roundcube CardDAV Plugin
« Reply #64 on: March 08, 2013, 01:13:24 PM »
Hi!

Currently i am testing the 0.9 with this plugin V0.5.1 and with the "affected_rows" patches applied.

And, yes, i tested your experiences creating a new contact one minute ago.
It gives the described error, but without the "CardDAV-Server XML-Response is malformed. Synchronization aborted!".
After synchronising the new contact appears...

As i understand the contact is created locally and then transferred to the davical server...
And, the prob is not solved.


Rgds.
« Last Edit: March 08, 2013, 01:31:43 PM by oldschool »

Offline Accudio

  • Newbie
  • *
  • Posts: 1
Re: [0.6] Roundcube CardDAV Plugin
« Reply #65 on: June 25, 2013, 03:54:02 PM »
Hey, I'm a noob when it comes to SQL databases, and cannot work out what
"Execute SQL statements from /plugins/carddav/SQL/yourDatabase.sql"
wants me to do in the install instructions. Can anyone give me quick helping hand and give me a slightly simpler explanation here?

Offline Happyfeet

  • Newbie
  • *
  • Posts: 6
Re: [0.6] Roundcube CardDAV Plugin
« Reply #66 on: November 01, 2013, 02:31:44 AM »
Good morning. After upgrade the Plugin from 0.8.0 to 0.9.x in Plugin manager I get an error for the database.
The Table roundcubemail.carddav_server doesn't exsist.

How can I fix this?

Gesendet von meinem HTC One X mit Tapatalk


Offline oldschool

  • Sr. Member
  • ****
  • Posts: 406
Re: [0.6] Roundcube CardDAV Plugin
« Reply #67 on: December 09, 2013, 10:46:05 PM »
Hi!

My friend Allan did it! We made a "hardcore" session this night.
;)
Is there any need for the fixed plugin?


Greetz.

Offline oldschool

  • Sr. Member
  • ****
  • Posts: 406
Re: [0.6] Roundcube CardDAV Plugin
« Reply #68 on: December 10, 2013, 06:48:28 PM »
Okay!

Currently i am testing the fixed CardDAV-Plugin with the actual RC 0.95 and it seems to work.
;D
More to come...


Greets.



Update:
There's no num_rows() method in 0.9. Carddav plugin need to be updated to use other method.

Checked -> Bullsh*t!
« Last Edit: December 11, 2013, 08:28:52 PM by oldschool »