Updates Three Column Modification to Default Theme

[Jaime_Pomales]

Here's is the updated 0.7 three column default layout.  I am uploading the two patches for mail.css and templates/mail.html as well as the complete zipped modified theme.  There were a few changes and modifications that I think exposed a couple of layout bugs from previous patches.  This update is tighter and more explicit.  Enjoy.  If you want to see the exact lines changes, just take a look at the patch files to see what is different from the default 0.7 theme.

[ATTACH=CONFIG]1803[/ATTACH]
[ATTACH=CONFIG]1804[/ATTACH]
[ATTACH=CONFIG]1805[/ATTACH]

[Jaime_Pomales]

There were no changes to the default skin from 0.7 to 0.7.1 so these patches and files are completely compatible with 0.7.1.

[JohnDoh]

Hi. I have turned your patch into a plugin, that makes it a bit more update proof. The plugin adds an option to the mailbox setting page so that the user can choose if the preview pane should be below or on the right of the message list. If you set the option in the main RC config file you can set the default (see README). The plugin will work for the default skin in 0.7 or above and also for larry in SVN trunk r5847 or above.

[tborder]

I have some trouble with Google Chrome. If I enter a page with empty box 'show preview', and then check the box 'show preview' - everything is ok. But if I enter the page with already checked box, or refresh the page after checking, it looks at that:

[Jaime_Pomales]

Hi. I have turned your patch into a plugin, that makes it a bit more update proof. The plugin adds an option to the mailbox setting page so that the user can choose if the preview pane should be below or on the right of the message list. If you set the option in the main RC config file you can set the default (see README). The plugin will work for the default skin in 0.7 or above and also for larry in SVN trunk r5847 or above.

That's awesome, John.  For some reason, I didn't get some of these replies as email (as I don't check the boards very often), so sorry for not getting back to you.  I was just updating the skin for the new 0.8.1 version when I came here and saw your post.  I just tried out your plugin and it doesn't seem to be compatible with 0.8.1.  I get a completely blank screen.  I am going to dig into this and see what is going on.  In the meantime, here are the updated patches for the classic skin.

[Jaime_Pomales]

I see what is going on with the threecol plugin.  It seems there's been a structural change to roundcube's ui framework via rcube_utils, no?  This exists in git, but not in 0.8.1.  Can you recommend a threecol plugin that is compatible with the current release?

[JohnDoh]

yea I started working on it after all the rc framework stuff had been added to the git-master so there never was a rc-0.8 version. backporting it is trivial though if you know the rc code so i've made an rc-0.8 branch in the repo now that should work.

[Jaime_Pomales]

Nope, still doesn't work rcube::get_instance is still in there. 

I'll admit, I have only dabbled with the plugin framework thus far, but I have been/and will be going through the docs to get up to speed on all of this. 

I definitely think roundcube is here to stay and worth the effort to contribute more.  I've been burned by other projects in the past, but it seems to me that roundcube is starting to become a killer app in the webmail space.

[JohnDoh]

are you sure you downloaded the files from the correct branch? there is no mention of rcube::get_instance in there

this is the one: https://github.com/JohnDoh/Roundcube-Plugin-Threecol-Layout/tree/rc-0.8

[Jaime_Pomales]

Yeah, weird.  I thought I had selected that branch then clicked on the downloads button, but I guess the tgz button leads back to the main branch.  Anyway, I see that there is a button to a zip file for the current branch one is viewing and I now have the correct files.

Works great even with the new larry theme.   Appreciate the effort. 

[zachol]

Excellent plugin!

Is there a way to set "right" as default value for all NEW accounts, leaving current user settings to whatever they have selected? I don't want to force this setting upon any user.

Regards 

[JohnDoh]

The readme says how to set it as the default but I think that will change it for all users not just new ones please try it and see. Another way might be to use the user_create hook to detected when a user logs in for the first time and set the option there.