Third Party Contributions => API Based Plugins => Topic started by: mfallon on February 28, 2009, 02:18:13 PM
Title: Right Click Functionality
Post by: mfallon on February 28, 2009, 02:18:13 PM
As RoundCube has been developed using AJAX, can I ask if there is any plan to add the ability to right click messages and show a list of functions, such as reply, forward, mark as read, delete, etc. when you right click on a message, or even a folder.
Don't know if anyone has already developed this as a plug-in or if it could only be included in the core build process.
Thanks, Matt
Title: Right Click Functionality
Post by: george2390 on March 05, 2009, 11:36:46 PM
I think thats a great idea :). I hope they decide to add this to RoundCube:)
Title: Right Click Functionality
Post by: JohnDoh on April 27, 2009, 11:19:15 AM
I have made a plugin which adds a context menu to the message list. You need to latest SVN trunk version to use it. take a look here RoundCube Patches & Plugins (http://www.tehinterweb.co.uk/roundcube/#picontextmenu)
Title: Right Click Functionality
Post by: lacri on April 28, 2009, 03:22:08 AM
great work John and works perfect !!!
Can you extend the PlugIn still so far which one several message mark can and if a right click command is given this to all selected messages is applied.
Title: Right Click Functionality
Post by: JohnDoh on April 28, 2009, 07:50:27 AM
lacri: making it work with multiple selection was a good idea, i have modifed the plugin to do this. you can get the new version from the site now.
Title: Right Click Functionality
Post by: lacri on April 28, 2009, 08:03:00 AM
wow John many many thanks !!!
that could be done fast and this works beautifull !!!
Title: Right Click Functionality
Post by: lacri on April 28, 2009, 08:27:06 AM
Another idea would be right click menu for the folder list is however somewhat more complicated as I thinks one only the messages in the background there for loading would have to those the command to be applied is.
E.g. folder emptying/all messages delete, mark all messages as read/unread …
what do you think?
Title: Right Click Functionality
Post by: lacri on April 28, 2009, 09:15:59 AM
hi John
i have found a little Bug, Moving Messages to Trash dont work when selecting more than one message. I dont found why.
Thx in advance
Title: Right Click Functionality
Post by: JohnDoh on April 28, 2009, 09:54:00 AM
D'oh you're quite right. Thats what happens when you do things too quickly! There is a new version with multiple delete working.
I'm not sure about context menu on the folder list. From a quick look at the code empty and compact should be possible, mark all as read/unread would be a bit more tricky as we dont have a message list until the folder is open.
Title: Right Click Functionality
Post by: lacri on April 29, 2009, 02:34:57 AM
Hello John,
a thing has I still discovered if man in the trash folder is should the text in context menu delete messages to have and in all other folder move massage to trash, the ENV Vars be correct and is however not seem set not to be evaluated.
Completely thank you for your assistance and the fantastic Plugin!!!
Title: Right Click Functionality
Post by: lacri on April 29, 2009, 10:12:04 AM
I have found a solution.
add in contextmenu.js after the line rcmail.add_onload('rcm_contextmenu_load()'); this rcmail.addEventListener('listupdate', function(evt, props) { rcm_contextmenu_load(); } ); with the Event listupdate reloads the contextmenu_load function and becomes the correct env.mailbox var to display the correct delete Message in context.
Title: Right Click Functionality
Post by: JohnDoh on April 29, 2009, 01:35:02 PM
thanks lacri, i think the delete function really doesnt like me very much. I have made a fix similar to your suggestion. the new version is available now. hopefully that is all the bugs squished.....
Title: Right Click Functionality
Post by: lacri on April 30, 2009, 02:23:46 AM
Thanks John works realy good, only the Internet Explorer not like this and will not display the context menu after klicking on a folder.
i use the listupdate Event to reinitilize the rcm_contextmenu_init('messagelist tbody tr'); rcmail.addEventListener('listupdate', function(evt, props) { rcm_contextmenu_init('messagelist tbody tr'); } );and after this works fine in all browsers for me :) i hope this is correct
Title: Right Click Functionality
Post by: JohnDoh on April 30, 2009, 12:58:34 PM
thanks again lacri. I have made the change as you suggested. I am not overly happy with it as i think it means the events are added twice in most cases but i dont have time to look for a better solution right now, if any one has any suggestions please let me know.
Title: Great Work!
Post by: mfallon on May 04, 2009, 11:26:28 AM
Really nice to see suggestions being implemented, things like this are what makes Roundcube (IMHO) the best opensource webmail client available.
Keep up the good work guys.
Title: Right Click Functionality
Post by: uberlemurguy on May 04, 2009, 07:01:57 PM
i honestly believe that using jQuery would simplify much of this complex javascript code in roundcube. There would be significantly less code, that is also easier to read. We could need things like: "return rcmail.folder_mouse_up('[Gmail]/All Mail')" on every folder link because we could bind classes with jQuery. jQuery has excellent AJAX methods and it works cross browser. There are hundreds of plugins easily enabling right-click functionality. Also skins could take advantage of jQuery, creating more dynamic and rich themes. I know all of my themes that I am going to make will include jQuery because of its advantages. If this has been discussed before, I am sorry because I am new to the forums (but not to RoundCube).
Title: Right Click Functionality
Post by: JohnDoh on May 05, 2009, 08:25:14 AM
jQuery is being used in the trunk and will be in the next release i think, but there are some things that (at the moment) jQuery is slow at so it cant be used for everything. there is a little bit of discussion here RoundCube Mailing Lists (http://lists.roundcube.net/mail-archive/dev/2009-04/0000077.html)
as for the right click stuff you are correct, that is why i waited until RC was jQueryfied before i did any thing.
i have been tinkering with RC for a long time now and IMO the JS is great and its really easy to understand once you get your head round the basic structure.
Title: Right Click Functionality
Post by: uberlemurguy on May 05, 2009, 11:00:13 PM
I have used jQuery for over a year, and I have never run into a case where jQuery's ajax methods are slower. There must have been some other varible involved as in not using proper jQuery techniques etc.
Also with jQuery even if it is a little slower, I don't think that should put us off of it. The ability to easily bind keys and run animations with ease is rather helpful. It also allows us to do more mundane things that are useful. (adding odd and even classes to the message list can be just 2 or 3 lines) It does look like the devs have done a good job with the rcmail object, but so much code could be elimitated by effectively using jQuery.
Just my two cents.
Title: Right Click Functionality
Post by: uberlemurguy on May 06, 2009, 04:22:14 PM
as an update: i did some tests myself, jQuery is just as fast at ajax after I ran my own tests, which makes sense since the jQuery $.ajax method is just a way to easily do the DOM ajax.
Title: Right Click Functionality
Post by: rosali on May 10, 2009, 04:40:38 AM
Great plugin! Only thing I miss, is the message row is selected (displayed in red colour) on right click.
Title: Right Click Functionality
Post by: JohnDoh on May 10, 2009, 05:28:40 AM
Thanks :D. I wondered about the message highlighting thing. I think it would actually make the code simplier if that was done but I decided not to mainly because I thought it was possible that some one might have message open in the preview pane and want to do something to another message, say one that just arrived while still keeping the current message open. does that make sense?
What do people think? should right clicking select that message or just let you do stuff to it.
I just tried in Outlook and it seems to use the same approach as this, although there is a little dotted box around the right clicked message. May be doing something like that, just altering the border around the right clicked message so it is clear which one was clicked would be a good compromise.
Title: Right Click Functionality
Post by: rosali on May 11, 2009, 12:53:15 PM
Is it necessary to patch lists.js (rc_context_menu.patch ::: lists.js ::: rcm_contextmenu_init)? It seems to work without the patch (at least for IE7). In additon the patch gives me a js error when entering folder administration.
Title: Right Click Functionality
Post by: JohnDoh on May 11, 2009, 02:36:36 PM
That confused me. you are correct the patch is not needed at all any more, it was only a temporary thing until plugin hooks were available. It should have been removed from the tar.gz and zip files, it has been now.
Title: Right Click Functionality
Post by: rosali on May 11, 2009, 03:33:27 PM
OK - shouldn't we move this thread please to plugins? If you disagree, feel free to delete this post.
Title: Right Click Functionality
Post by: JohnDoh on May 12, 2009, 08:03:36 AM
sounds like a plan, i have move it.
Title: Right Click Functionality
Post by: lacri on May 26, 2009, 07:43:34 AM
Hi John,
i found little things the icons unflagged, print and forwardreplyall are not display.
here is my little workaround.
can you fix this with the rcmail.env i have hardcoded the path.
and can you add the new commands from the SVN messagemenu to your plugin for Message download as eml, show source and open in new window :)
Thanks in advance
Title: Right Click Functionality
Post by: JohnDoh on May 26, 2009, 09:14:05 AM
I added the icons and the new actions yesterday but following r2541 it doesnt work right any more so i will have to update it again :/
UPDATE: the updated plugin is going to be a bit delayed until r2541 is fixed, its still very buggy in IE and there is no point in rewriting stuff until the new code is sorted.
Title: Right Click Functionality
Post by: lacri on May 28, 2009, 05:46:55 AM
thanks John yes in the current svn after 2541 dosnt work anymore r2541 breaks completly the context menu in IE FF ...
Title: Right Click Functionality
Post by: marklittle on May 29, 2009, 10:43:20 PM
FYI - Context menu is working 95% fine for me with latest SVN (r2573). Only thing that is broken are the icons for print, save and source, because they were moved to images/buttons with the 3 versions.
Cheers, Mark
Title: Right Click Functionality
Post by: rosali on May 30, 2009, 02:09:36 AM
Please do not include contextmenu.js in "preview pane" or "show message". Both are in task "mail" but don't need the plugin.
If $_GET['_uid'] is not empty, do not trigger things.
Title: Right Click Functionality
Post by: JohnDoh on May 30, 2009, 05:09:12 AM
thats a good idea, i've also added some checks to stop it being loaded on the login screen.
I submitted a patch to trac which fixed the menu issues in IE, assuming that gets applied I will release the new version.
UPDATE: The new version is now available on the website.
Title: Right Click Functionality
Post by: rosali on May 30, 2009, 01:31:53 PM
Perhaps I'm missing something, but the print icon is still not shown.
Title: Right Click Functionality
Post by: JohnDoh on May 30, 2009, 01:34:39 PM
hmmm could it be a caching issue? I have tried in FF3 and IE7 and i can see the print icon in both. are you using the latest svn?
Title: Right Click Functionality
Post by: rosali on May 30, 2009, 02:01:12 PM
Sorry, I missed to check the timestamp of your files. But it looks like you did not update http://www.tehinterweb.co.uk/roundcube/plugins/contextmenu.0_3b.zip ... timestamp of files is 30.05.2009 !
Title: Right Click Functionality
Post by: rosali on May 31, 2009, 12:13:53 AM
IE8: printicon is undefined ...
[Sun May 31 06:12:49 2009] [error] [client 127.0.0.1] File does not exist: D:/xampp/htdocs/webmail/api/trunk/roundcubemail/undefined, referer: http://localhost/webmail/api/trunk/roundcubemail/?_task=mail
Title: Right Click Functionality
Post by: rosali on May 31, 2009, 01:47:43 AM
It works for me with the following modifications now:
class contextmenu extends rcube_plugin { public $task = 'mail';
function load_contextmenu() { $rcmail = rcmail::get_instance(); // rcube_json_output::add_script() does not exist !!! $methods = array_flip(get_class_methods($this->api->output)); if(isset($methods['add_script'])) $this->api->output->add_script('rcmail.env.printicon="skins/' . $rcmail->config->get('skin') . '/images/icons/print.png";'); $this->api->output->add_label('markmessages','markread','markunread','markflagged','markunflagged','replytomessage','replytoallmessage','forwardmessage','printmessage'); $this->include_script('jquery.contextMenu.js'); $this->include_stylesheet('contextmenu.css');
$this->include_script('contextmenu.js');
} }
Title: Right Click Functionality
Post by: JohnDoh on May 31, 2009, 04:43:09 AM
Quote from: rosali;19340
IE8: printicon is undefined ...
You mean in 0.3b? yea thats right, there isnt one. It was added later and is in the latest development release.
Title: Right Click Functionality
Post by: marklittle on June 01, 2009, 03:10:51 PM
Hey dude,
Just a heads up - I am seeing a weird bug with latest SVN and contextmenu. Something that has been updated in trunk between 2588 -> 2591.
U program/include/rcube_template.php U program/include/rcube_shared.inc U program/include/rcube_json_output.php U program/lib/mime.inc U program/js/common.js U program/js/app.js
I backed back to 2588 and its fine now.
The issue is it only displays one message in each folder (the newest). If I hit refresh, it reloads the same folder with all the messages, but if I click on another folder it only shows one again.
I am going to update by revision slowly now and try to isolate the update that breaks it and will let you know.
Edit: Its the changes in 2589
----- r2589 | thomasb | 2009-06-01 11:35:53 -0400 (Mon, 01 Jun 2009) | 1 line Changed paths: M /trunk/roundcubemail/program/include/rcube_json_output.php M /trunk/roundcubemail/program/include/rcube_template.php M /trunk/roundcubemail/program/js/app.js M /trunk/roundcubemail/program/js/common.js
Use event system on the client to handle ajax callbacks -----
Title: Right Click Functionality
Post by: JohnDoh on June 01, 2009, 04:04:33 PM
Thanks for tracking down the chageset that broke everything. looking at what changed I am not 100% sure why but changing:
change from $this->include_stylesheet('skins/'. $this->api->output->config['skin'] .'/contextmenu.css');
to $this->include_stylesheet('skins/default/contextmenu.css');
have you an other idea or a solution
Title: Right Click Functionality
Post by: JohnDoh on June 02, 2009, 07:43:03 AM
It works fine for me in both IE7 and 8. Are you using the default skin? check view source and make sure the CSS file in is there properly, it should be:
Title: Right Click Functionality
Post by: lacri on June 02, 2009, 09:37:29 AM
in the SVN 2589 is a bug i have commitet this to trac see #1485890 (Drag'n'Drop dosnt work in FireFox SVN 2591) ? RoundCube Webmail (http://trac.roundcube.net/ticket/1485890)
after rechance the modification in common.js the context menu works fine with all details and features and no js error in the addEventListener listupdate and insertrow with the evt param.
rcmail.addEventListener('listupdate', function(evt, props) { rcm_contextmenu_load(true); rcm_contextmenu_init('messagelist tbody tr'); } ); rcmail.addEventListener('insertrow', function(evt, props) { rcm_contextmenu_init(props.row.id); } ); and now works perfekt i found this by searching the bug for Drag and Drop in FF dosnt work anymore
Title: Right Click Functionality
Post by: JohnDoh on June 02, 2009, 01:04:00 PM
yep, that just reverses the change i made to work i with r2589. I notice that the bug you just submitted to trac has been fixed now as well. The current version of the code in git will work with the current SVN of RC.
Title: Right Click Functionality
Post by: rosali on June 06, 2009, 02:07:32 AM
Could you please "open in new window". May be we can get rid of opening multiple tabs issue (Ticket #1484913) this way.
Title: Right Click Functionality
Post by: JohnDoh on June 06, 2009, 04:07:02 AM
I'm not sure I understand. there is alread an "open in new window" option in the menu or do you mean you want all the links to open in new windows?
Title: Right Click Functionality
Post by: rosali on June 06, 2009, 03:53:06 PM
Oops, I missed that. I had an outdated version installed. Sorry.
Title: Right Click Functionality
Post by: rosali on June 06, 2009, 04:02:22 PM
Just installed the new version (30-05-2009). Did you test it on Firefox? It does not work for me on FF 3.x. IE7/8 is fine. Contextmenu is not hidden. It shows up on the left top behind the RoundCube Logo. I double checked to clear the cache. My Code Base is SVN trunk 2617.
EDIT1: Found the "bug" ... I would add a fallback to plugins/contextmenu/skins/default ... if another skin is enabled -that was the problem in my case - and there is no stylesheet for it in the contextmenu plugin.
EDIT2: Question: Do you think about a "forward as attachment" and "copy/move to folder" functionality? Also a "add sender to contacts" would be nice ... If these things would be available then it had all what OE does on right click. All in all I have to thank you for this great plugin. Compliments!
Title: Right Click Functionality
Post by: JohnDoh on June 07, 2009, 05:28:00 AM
Quote from: rosali;19509
Found the "bug" ... I would add a fallback to plugins/contextmenu/skins/default ... if another skin is enabled -that was the problem in my case - and there is no stylesheet for it in the contextmenu plugin.
Good idea! I have added a fallback.
Quote from: rosali;19509
Question: Do you think about a "forward as attachment" and "copy/move to folder" functionality? Also a "add sender to contacts" would be nice ... If these things would be available then it had all what OE does on right click. All in all I have to thank you for this great plugin. Compliments!
I don't think forward as attachment exists in the core yet. The menu doesn't do any work for itself it just calls functions from the core. But if it was added to the core I think if could certainly go on the menu.
Copy/move is a bit more tricky, I guess you would need to generate a list of folders on a submenu to let people select the destination, I'm not sure about that, drag and drop is really easy is it really needed on the menu?
Add sender to contacts could get messy I think. Its not on the menu in regular Outlook. Any way I'm not sure it being on the menu in something else is a legit reason to add it to this one. It makes sense that the most common things are on there but we cant just add everything or the menu will be 3miles long and totally useless!
Title: Right Click Functionality
Post by: rosali on June 08, 2009, 03:23:25 AM
OK, I just wondered if it may be on your ToDo's to write a patch for "forward as attachment" and to provide a "copy" functionality in addition to the "move" feature.
Regarding the fallback, I'm not sure if it was intended to package the file with "skins/default1" instead of simply "skins/default".
Title: Right Click Functionality
Post by: JohnDoh on June 08, 2009, 06:47:19 AM
DOH! you are correct, it should have been skins/default i have corrected the typo. Thanks for spotting it so quick.
And yes those things will go on the wish list. I think my next little challenge will be getting a move option in there, once that works copy should be pritty simple (once the operation is in the core) Just need a different version of the JS lib so i can use sub menus.
Title: Right Click Functionality
Post by: rosali on June 08, 2009, 01:39:25 PM
Please check if "row" is an object before executing this or use try/catch.
I get js errors when accessing empty Sent mailbox!
Goto RoundCube Webmail :: Welcome to RoundCube Webmail (http://mail4us.net/dev) and login as demo to cross check what I mean and select folder (Sent / Gesendet).
Title: Right Click Functionality
Post by: rosali on June 08, 2009, 02:49:45 PM
Don't know if it is good style, but this fixed it for me:
... strange, I never got js error on my local test environment. Issues started since uploaded the stuff to RoundCube Webmail :: Welcome to RoundCube Webmail (http://mail4us.net/dev) on my dedicated server.
EDIT: It does not fix it. New rows inserted by a AJAX request are not initialized this way --- :-(
Title: Right Click Functionality
Post by: lacri on June 09, 2009, 02:28:42 AM
by me work this no errors and also ajax calls work
rcmail.addEventListener('listupdate', function(evt, props) { rcm_contextmenu_load(true); rcm_contextmenu_init('messagelist tbody tr'); } ); rcmail.addEventListener('insertrow', function(props) { rcm_contextmenu_init(props.row.id); } ); see attachment the working version
Title: Right Click Functionality
Post by: JohnDoh on June 09, 2009, 08:16:56 AM
Rosali: are you trying to use the 0.3b version of the plugin with a more recent version of RC? Those listeners have changed a little in trunk and I tried with the latest version of both the plugin and RC and i get no errors from empty mailboxes. If it works on one machine and not the other could it be a caching issue?
Title: Right Click Functionality
Post by: Monty on June 21, 2009, 03:41:30 PM
Hello everybody,
This plugin works perfect now! Very handy it is indeed! One question I have though: when I login with a secured connection (HTTPS) the browser ( ie8 ) states that not all content can be delivered securerly. Proberly that is due to some pictures in the context menu.
How can it be changed in a way the browser can deliver everything securely?
Title: Right Click Functionality
Post by: JohnDoh on June 22, 2009, 01:48:42 PM
There should not be any problem with the images, the CSS is almost identical to that for the toolbars. I had a look with IE7 but I didnt get any errors (I dont know, may be I have turned them off somewhere). If you could track down what is causing the message that would be great, then we can get it fixed. Thanks
Title: Right Click Functionality
Post by: rosali on September 02, 2009, 10:35:28 AM
Here is an updated function for contextmenu.js which detects if archivefolder and/or forward_as_attachment plugin is installed/enabled to make to archive/forward as attachment command accessible by right click:
function rcm_contextmenu_load(update) { if (update) { if (rcmail.env.trash_mailbox && rcmail.env.mailbox != rcmail.env.trash_mailbox) $("#rcm_delete").html(rcmail.gettext('movemessagetotrash')); else $("#rcm_delete").html(rcmail.gettext('deletemessage')); } else { var menu = $('
$li .= html::tag('li', array('class' => 'forward'), html::a(array('href' => "#plugin.archive", 'class' => 'active'), Q($this->gettext('archivefolder.buttontitle')))); and to contextmenu.js
case 'plugin.forwardatt': case 'plugin.archive':and i have change the regexp for commands and i have add #plugin.forwardatt to rcmail.contextmenu_disable_multi array in contextmenu.js
can you try to port this to latest version of Johns nice Context Menu
i have no idea whats wrong
Title: Right Click Functionality
Post by: rosali on September 05, 2009, 12:57:11 AM
@ lacri:
I will update and release new RoundCube v0.3 stable plugins on sunday. Please use new "forward_as_attachment" and "archivefolder" plugins. Thanks to JohnDoh's help they now automatically integrate in the contextmenu.
Title: Right Click Functionality
Post by: JohnDoh on September 11, 2009, 04:42:28 PM
I have added a folder menu context menu to the plugin. Its only just been finished so it might be a little buggy still but you can get the latest version from the repo if you want to give it a try.
folder list context menu has the following options: mark all as read compact empty collapse all folders expand all folders open in new window
Title: Right Click Functionality
Post by: rosali on September 13, 2009, 01:31:21 PM
I can't find it ... your page states last updated 04.09.2009 ... Please post link.
Title: Right Click Functionality
Post by: JohnDoh on September 14, 2009, 09:21:29 AM
the development repo is here JohnDoh's RoundCube-Plugin-Context-Menu at master - GitHub (http://github.com/JohnDoh/RoundCube-Plugin-Context-Menu/tree)
I have also started work on adding "move to" to the message list context menu, hopefully it will be done by the weekend.
Title: Right Click Functionality
Post by: JohnDoh on September 18, 2009, 01:01:15 PM
new update: some bug fixes for the folder menu and added "move to" to the message list menu.
PLEASE NOTE: the repo version of the plugin requires RC SVN rev2960 or later.
Title: Right Click Functionality
Post by: rosali on September 18, 2009, 03:19:47 PM
You are awsome! Some more [directly translated] tolerance for the submenues if mouseover is not exactly over the icon ;-)
Title: Right Click Functionality
Post by: lifefarer on September 23, 2009, 12:02:38 PM
Title: Right Click Functionality
Post by: JohnDoh on September 24, 2009, 03:02:46 AM
hmmm its fine for me, does any one else have this problem? are you using a custom skin or anything like that?
What about the mark message and message action menus, do they also have the bullet points?
Title: Right Click Functionality
Post by: lifefarer on September 24, 2009, 06:58:49 AM
Quote from: JohnDoh;21642
hmmm its fine for me, does any one else have this problem? are you using a custom skin or anything like that?
What about the mark message and message action menus, do they also have the bullet points?
Oops.. forgot to mention: I use Mvision 2.2 theme. As for other menus, they are OK.
Title: Right Click Functionality
Post by: ABerglund on September 25, 2009, 12:49:06 PM
Quote from: JohnDoh;21470
new update: some bug fixes for the folder menu and added "move to" to the message list menu.
PLEASE NOTE: the repo version of the plugin requires RC SVN rev2960 or later.
John, this is great. My only question is how hard would it be (or where would I make edits) to expand the number of folders that are shown in the Move-To submenu? On my system it shows 5 folders, more than that requires scrolling. If I wanted to change that to say, 10, where would I do that? Or is it simply a size param for the submenu?
Title: Right Click Functionality
Post by: JohnDoh on September 25, 2009, 02:31:27 PM
To alter the size of the submenu you need to alter the skin. Take a look in skins/default/contextmenu.css and then you need to change the height of #rcmContextMenu ul.scrollable and adjust the top offsets of #rcmContextMenu li div.scroll_down_act and #rcmContextMenu li div.scroll_down_pas to match the change in height.
Title: Right Click Functionality
Post by: ABerglund on September 25, 2009, 02:43:30 PM
Quote from: JohnDoh;21730
To alter the size of the submenu you need to alter the skin. Take a look in skins/default/contextmenu.css and then you need to change the height of #rcmContextMenu ul.scrollable and adjust the top offsets of #rcmContextMenu li div.scroll_down_act and #rcmContextMenu li div.scroll_down_pas to match the change in height.
Perfect. Exactly what I needed. Thanks for the quick reply!
Title: Right Click Functionality
Post by: ABerglund on September 25, 2009, 05:30:35 PM
Another question, John. I just noticed that I get an error banner now when right-clicking a folder to mark all as read. The attached banner displays, and the folder list still shows bold and the number of unread, but if you enter the folder all will indeed have been marked read.
I had a previous version installed which did not do this.
Title: Right Click Functionality
Post by: rosali on September 26, 2009, 12:59:29 AM
Please use recent RoundCube SVN trunk version. 'contextmenu' plugin is using a core function which was recently added to RoundCube.
Title: Add "Copy To" as well
Post by: bigears on December 17, 2009, 04:28:09 PM
Hi John
Is it possible to add a "Copy To" as well, like the "Move To". We have users that can copy archived emails to theirs folders, but we don't want them to delete the emails in the archive.
Title: Right Click Functionality
Post by: JohnDoh on December 18, 2009, 02:54:18 AM
There is no copy function in the RC core, it might be best to write a seperate plugin which intergrates with contextmenu. Making a function to do the actual copy is easy I think, its just the updating the cache bit which I am not sure about. Looking at the move message function I am not sure if any changes need to be made to the cache at all which would make the process much easier.
I know that this request has come up before, I will try playing with the code and see how far I can get.
Title: Right Click Functionality
Post by: JohnDoh on December 20, 2009, 11:54:18 AM
so i had a little play around...
attached is something which intergrates with the context menu (but there is no reason why it cant be extended to add something to the toolbar). You need the latest repo version of the contextmenu plugin and SVN trunk r3141 or later of RC.
I dont plan on adding this to my collection of plugins so if any one wants to take the code and run with it please feel free.
Title: Right Click Functionality
Post by: rosali on December 22, 2009, 12:23:23 AM
Works great! I'll package it with MyRoundcube plugins bundle.
Title: Dont work for me
Post by: mmerlone on February 02, 2010, 12:13:39 PM
I'd love to have contextmenu working, but it does not work at all. Browser's context menu disapears, so something happens, but no menu. I am using roundcubemail-0.3.1, it gets first initialized $rcmail_config['plugins'] = array('contextmenu', ... and nothing happens. Sorry if this is not the rigth channel for support. :)
Thanks and best regards.
-- Marcio Merlone
Title: Right Click Functionality
Post by: JohnDoh on February 02, 2010, 01:59:57 PM
what browser are you using and what version of the plugin do you have (did you download the archive from the website or from the repo)? do you see any JS errors in the browser?
Title: Right Click Functionality
Post by: mmerlone on February 02, 2010, 03:05:13 PM
I am using latest FF (3.6.?), downloaded plugin from RoundCube Plugins & Patches (http://www.tehinterweb.co.uk/roundcube/). I also have Firebug, I am a PHP devel, and nothing goes to console, no error on firebug, browser nor anywhere. Sorry for not providing those info, I am in a hurry at job.
Title: Right Click Functionality
Post by: bagu on February 02, 2010, 03:53:51 PM
noscript or adblock installed ?
Title: Right Click Functionality
Post by: mmerlone on February 02, 2010, 05:15:01 PM
Quote from: bagu;25164
noscript or adblock installed ?
nope, none.
Title: Right Click Functionality
Post by: JohnDoh on February 03, 2010, 03:18:48 AM
you are definatly using rc 0.3.1, not the SVN trunk right? the reason I ask is that since 0.3.1 the version of jQuery used has changed and there was a small change needed to get the contextmenu working with jQuery 1.4 (it fixed in the repo version).
Title: Right Click Functionality
Post by: ABerglund on February 03, 2010, 07:36:30 PM
I've just noticed that my contextmenus are not working properly on any Windows XP browser I test. I've tried Firefox 3.6, Safari 4 and IE 8 on multiple computers. In all cases, the ajax menu is covered by the browser's default contextual menu.
Works fine in all Mac browsers tested.
I'm using the latest version of the plugin from the repo, in SVN 3246.
Title: Right Click Functionality
Post by: JohnDoh on February 04, 2010, 03:09:48 AM
yes, that is was what was caused by the switch to jQuery 1.4. This hack fixed it for me Commit fe6cc21f8e4cc21053f5d15499559711925b3dcf to JohnDoh's RoundCube-Plugin-Context-Menu - GitHub (http://github.com/JohnDoh/RoundCube-Plugin-Context-Menu/commit/fe6cc21f8e4cc21053f5d15499559711925b3dcf) if you have the latest repo version of the plugin may be you need to clear your cache or something.
Title: Right Click Functionality
Post by: mmaraghy on February 04, 2010, 09:16:52 AM
hack works. thanks.
Title: Right Click Functionality
Post by: ABerglund on February 04, 2010, 11:13:09 AM
I can also confirm that this fixed it on my test PCs.
Title: Right Click Functionality
Post by: mmerlone on February 08, 2010, 08:51:16 AM
Quote from: JohnDoh;25174
you are definatly using rc 0.3.1, not the SVN trunk right? the reason I ask is that since 0.3.1 the version of jQuery used has changed and there was a small change needed to get the contextmenu working with jQuery 1.4 (it fixed in the repo version).
I tryied the hack below (adding line 81 on jquery.contextMenu.js) and still no luck. Any plans to release a new package with some fix/workaround or should I get svn?
Title: Right Click Functionality
Post by: JohnDoh on February 08, 2010, 01:34:11 PM
the hack i suggested is only for if you are running jQuery1.4 which comes with the SVN version of RC, 0.3.1 uses JQuery1.3 so again please confirm which version of RC you are using.
there will not be another "released" version of the contextmenu plugin until RC0.4 is released since there have been many changes.
Title: Right Click Functionality
Post by: mmerlone on February 08, 2010, 02:08:23 PM
Quote from: JohnDoh;25324
... so again please confirm which version of RC you are using.
I'm not sure, could not find such information on any file. Latest information on CHANGELOG says:
/** * ContextMenu * * Plugin to add a context menu to the message list * * @version 1.2 * @author Philip Weir * @url http://roundcube.net/plugins/contextmenu */ class contextmenu extends rcube_plugin {
Title: Right Click Functionality
Post by: SKaero on February 09, 2010, 05:05:15 AM
The RoundCube version number its in /index.php
Title: Right Click Functionality
Post by: mmerlone on February 09, 2010, 05:22:28 AM
Quote from: skaero;25354
The RoundCube version number its in /index.php
Ah! Original question was, and I tought still was, about contextmenu version. As I said before, I am using latest stable roundcubemail-0.3.1. Sorry.
Title: Right Click Functionality
Post by: mmerlone on February 09, 2010, 05:30:38 AM
Quote from: skaero;25354
The RoundCube version number its in /index.php
Ah! Original question was, and I tought still was, about contextmenu version. As I said before, I am using latest stable roundcubemail-0.3.1. Sorry.
Title: Right Click Functionality
Post by: JohnDoh on February 09, 2010, 07:23:04 AM
ok so we still need to find out what the problem is then since afaik it works fine for other people (and for myself)
When you right click is the RC contextmenu displayed under the browser one or not at all? Is there anything in your rc error log (rc root/logs/erros)?
Title: Right Click Functionality
Post by: mmerlone on February 10, 2010, 05:26:54 AM
Quote from: JohnDoh;25368
When you right click is the RC contextmenu displayed under the browser one or not at all? Is there anything in your rc error log (rc root/logs/erros)?
Contextmenu is not displayed at all, no sign of it, no browser's context menu either when plugin is enabled. I was using syslog to log errors from rc, then changed to
All other config params where left as defaults. Chmodded +w logs dir, and no error log were created. I tried $rcmail_config['debug_level'] = 4; because 1 did not do anything and I gave it a try. So, to answer your question, no, there is nothing on error log. :(
I have firebug 1.5.0, and nothing goes to console, no network ajax activity, zero.
Title: Right Click Functionality
Post by: JohnDoh on February 11, 2010, 03:34:02 AM
could you pm me login details for a test account and i'll see if i can see what wrong.
Title: Right Click Functionality
Post by: Granada on February 25, 2010, 03:52:48 AM
Hi folks!
Thanks for the great work with RC and the lots of plugins. I've discovered some strange behaviour of the contextmenu plugin that I have installed on two different servers, both running RC 0.3.1 and the same versions of contextmenu.
On the first server, the folder list when selecting "move message to" is limited in it's height and you can scroll through the folders. On the other server, the sizing of the folder list fails, it is enlarged as long as the folder list.
The logs do not show up any errors and as said: both versions of the installed roundcube and plugin are identical.
EDIT:
Found the reason - but the solution needs to be implemented in the script: $idx in $nestLevel == 0 never reaches a value greater than 5, so no scroll_up_pas and scroll_down_act classes are being added.
my range of NestLevels and Indices looks like this. when telling the script to echo it right before the end of the fundction _gen_folder_list():
I do not have dozens of folders inside the main inbox, but subscribtions to several other mail boxes.
Regards Ruediger
Title: Right Click Functionality
Post by: JohnDoh on February 26, 2010, 03:30:00 AM
fixed in the repo.
Title: Right Click Functionality
Post by: Granada on February 26, 2010, 05:16:46 AM
@JohnDoh:
Thanks for the quick fix! It's the same way that I hacked up the script to make it work here after I found out what went wrong - a simple counter for the total numer of folders to be listed. :)
Regards Ruediger
Title: Right Click Functionality
Post by: dakkar on March 01, 2010, 03:00:16 PM
thx 4 the hack, it works fine now.
greetings dakky
Title: Right Click Functionality
Post by: mmerlone on March 03, 2010, 07:58:00 AM
Quote from: JohnDoh;25443
could you pm me login details for a test account and i'll see if i can see what wrong.
Quote from: JohnDoh
great it works now. i logged in and i get the context menu just as expected, i tried making messages as read/unread and it was fine. are you still having a problem?
Well, yes and no. I use FF 3.6 on my machine, don't work. Then tried on another machine with FF 3.5.8 and it did, got back to my machine, tested Chrome 4.0.249.89 (38071) and IE 8.0.6001.18702 both also work.
WTF? Upgraded FF 3.5.8 on that machine were it worked to 3.6, and it did work too!
Conclusion: That is my one and only problem. Sorry to bug you. BTW, could it be some FF addon? I have dozens of it, I work as a PHP programmer, and have Firebug, JSview, Colorzilla, MeasureIT among many others. Any known incompatibility?
For the records if this can help someone, I also have an addon dumper addon :) Those are the addons I currently have:
Aplicativo: Firefox 3.6 (20100115144158) Sistema Operacional: WINNT (x86-msvc)
- All-in-One Gestures 0.20.1 - Auto Copy 1.0 - Bookmark Duplicate Detector 1.0.2 - Boox 2.5 - Cache Status 0.7.9 - CodeBurner for Firefox 1.5.2 - ColorZilla 2.0.2 - Compact Menu 2 3.1.1 - Copy Link Name 1.3.1.1 - Copy Plain Text 0.3.3 - Extension List Dumper 1.14.8 - Firebug 1.5.2 - Firecookie 1.0.2 - Fission 1.0.9 - Forecastbar Enhanced 0.9.6 - FoxyTunes 4.0.5.1 - Free Download Manager plugin 1.3.4 - Go to Selection 1.2.1 - Header Spy 1.3.4 - HighlightAll 1.4 - History Tree 1.2 - Hyperwords 5.6.5 (Desabilitado, Incompatible) - Image Zoom 0.4.4 - Java Console 6.0.11 - Java Console 6.0.17 - Java Console 6.0.16 - Java Quick Starter 1.0 - JSView 2.0.5 - Live HTTP headers 0.16 - Locationbar² 1.0.4 - McAfee SiteAdvisor 3.1 - MeasureIt 0.3.92 - Microsoft .NET Framework Assistant 1.1 - Network Tools (Router Status) 0.2 (Desabilitado, Incompatible) - Nightly Tester Tools 2.0.3 - Omnibar 0.6.8.20100227 - Personas 1.5.1 - Read It Later 2.0.3 - Remove Cookie(s) for Site 0.52 - ScribeFire 3.5 - SkipScreen 0.4.8s (Desabilitado) - Test Pilot 0.4 - Torbutton 1.2.4 (Desabilitado) - United States English Dictionary 4.0.0 - Uppity 1.5.6 - Verificação ortográfica pt-BR 1.4 - Verificação ortográfica pt-BR 1.0.0.1 - Web Developer 1.1.8 - Xmarks 3.5.7
Tks anyway, best regards.
Title: Right Click Functionality
Post by: Granada on March 04, 2010, 11:30:14 AM
I'd like to have the ability to create new folders when right clicking on the left side within the folder list. :)
It should not be too hard to implement these things, isn't it?
Regards Ruediger
Title: Right Click Functionality
Post by: JohnDoh on March 06, 2010, 04:10:29 AM
i thought about adding new/rename/delete folder to the menu but decided against it, for one thing its a little more complicated with restrictions on default folders etc
Title: Right Click Functionality
Post by: lacri on March 25, 2010, 05:44:50 AM
Hi John i found a little Bug in IE7 the folders submenu dont work in IE8 works fine ...
Thanks for your great work
Title: Right Click Functionality
Post by: JohnDoh on March 27, 2010, 04:02:37 AM
thanks Lacri, this should be fixed in the repo now.
Title: Right Click Functionality
Post by: ABerglund on March 27, 2010, 01:26:02 PM
John, I started getting a "Server Error" when attempting to right-click a folder and mark all inside as read. This started happening after I upgraded to SVN 3424, still happening with SVN 3432. I just installed the latest version of contextmenu from the repo with no change, still fails to mark the messages as read. All other functions seem to still work fine.
Perhaps unrelated, about the same time I started getting a warning from svn during an upgrade. The warning is:
Fetching external item into 'plugins' svn: warning: Working copy 'plugins' locked
At revision 3432.
Title: Right Click Functionality
Post by: JohnDoh on March 27, 2010, 02:33:49 PM
the mark all as read funciton is fixed in the repo now, the functions it used to use were removed from the trunk.
Title: Context Menu - Danish translations
Post by: osos on April 24, 2010, 07:20:00 AM
Here is the danish translation for Context Menu.
Title: Right Click Functionality
Post by: JohnDoh on April 25, 2010, 03:58:08 AM
thanks osos
Title: MobileCube Theme
Post by: errormaster on May 25, 2010, 11:10:45 AM
Hi,
does anyone get the extension to work with the mobilecube theme? Attached you can see my problem ..
I tried in Chrome, FF 3, IE 8, IE 7 .. everywhere the same ..
With the default Theme everything works fine :) But would be great if I could it get to work with mobilecube ..
Thanks for your help in advance!
Title: Right Click Functionality
Post by: Prasad1337 on June 02, 2010, 07:55:58 PM
Hmmm... Methinks RC does need a custom right click menu! :)
Title: Right Click Functionality
Post by: ABerglund on June 02, 2010, 08:30:05 PM
Quote from: errormaster;27648
Hi,
does anyone get the extension to work with the mobilecube theme? Attached you can see my problem ..
I tried in Chrome, FF 3, IE 8, IE 7 .. everywhere the same ..
With the default Theme everything works fine :) But would be great if I could it get to work with mobilecube ..
Thanks for your help in advance!
You need to add a Mobilecube skin folder in the skins folder inside the contextmenu plugin folder. You can start by simply making a copy of the default skin folder. The css might not be ideal for Mobilecube, but it'll work.
Title: Right Click Functionality
Post by: errormaster on June 10, 2010, 07:19:41 AM
Hi,
thanks for your help!
Quote from: ABerglund;27820
You can start by simply making a copy of the default skin folder. The css might not be ideal for Mobilecube, but it'll work.
I tried this, but it had no effect .. same problem as before :(
Title: Right Click Functionality
Post by: JohnDoh on June 13, 2010, 12:32:07 PM
If a skin folder for your selected skin doesnt exist in the plugin then the default skin is used, so you haven't really changed anything by just making a copy of the files in a new folder. You need to modify the CSS in the new folder to match your skin.
Title: Right Click Functionality
Post by: bagu on August 09, 2010, 07:49:23 AM
There is a problem with this plugin : Go to your adress book Right click on a group Choose delete
Group is not deleted.
But, if i select the group, an use the normal way (with the bottom button) it work fine.
I have try it on : Roundcube 0.4 stable Firefox 3.6.8 Internet explorer 8 Windows xp pro sp3 32bits Windows 7 pro 64bits
Title: Right Click Functionality
Post by: JohnDoh on August 09, 2010, 08:24:08 AM
Hi, can you confirm please this is only for newly created groups, it works fine for ones which existed before you loaded the page? Its to do with how new groups are added to the list.
Title: Right Click Functionality
Post by: ABerglund on August 09, 2010, 11:06:42 AM
I see the same behavior in 0.4-stable. The context menu appears to be non-functional for groups. I can neither Rename nor Delete - nothing happens when I select a choice. Tested in Safari 5 (Mac) and Firefox (both Mac and Win).
Title: Right Click Functionality
Post by: bagu on August 09, 2010, 11:55:31 AM
Quote from: JohnDoh;29227
Hi, can you confirm please this is only for newly created groups, it works fine for ones which existed before you loaded the page? Its to do with how new groups are added to the list.
Not only, old groups have the same issue
Title: Right Click Functionality
Post by: ABerglund on August 09, 2010, 11:57:38 AM
Same here. Existing groups cannot be renamed or deleted by context menu.
Title: Right Click Functionality
Post by: JohnDoh on August 09, 2010, 12:09:52 PM
thats odd, existing ones definatly work fine for me. any chance either of you would mind giving me a test account on your server so I could try it? thanks.
Title: Right Click Functionality
Post by: ABerglund on August 09, 2010, 12:26:02 PM
Quote from: JohnDoh;29240
thats odd, existing ones definatly work fine for me. any chance either of you would mind giving me a test account on your server so I could try it? thanks.
I can do that. PM coming your way.
Title: Right Click Functionality
Post by: JohnDoh on August 09, 2010, 02:38:00 PM
thanks ABerglund thats alteast solved half the problem. I think you are using the 0.4b version of the plugin, you need to upgrade to the 0.4s version coz of changes in the core. that should solve the problems with existing groups. the problem with new groups its still there, i need to work on that still.
Title: Right Click Functionality
Post by: bagu on August 09, 2010, 02:42:15 PM
I already have the last version of your plugin (picked up juste 15 minutes befor my first post)
I have this in CHANGELOG : 2010 08 01 ========== * Update hooks (r3840)
Title: Right Click Functionality
Post by: ABerglund on August 09, 2010, 02:42:49 PM
Opps! I missed that you had updated it for stable. You are correct, after updating my plugin, it now works fine on existing groups, but fails on new.
Title: Right Click Functionality
Post by: JohnDoh on August 09, 2010, 03:14:03 PM
i'm glad its sorted. the repo version (change just committed) should work with both existing and new groups.
Title: Right Click Functionality
Post by: bagu on August 09, 2010, 04:17:34 PM
With the repository version (github) it work fine. Thanks.
Title: Right Click Functionality
Post by: ABerglund on August 09, 2010, 04:40:36 PM
Confirmed - the latest works fine.
Title: contextmenu and roundcube 4.0-20100807
Post by: tsjolshagen on August 20, 2010, 06:43:54 AM
Hi,
Whenever I enable (latest github version) of the context menu plugin and reload the page, my roundcube UI stops responding and does not display any of the messages in the inbox (so basically the browser draws the UI, the folders but can't populate the messages portion of the inbox). Clicking on anything (right or left) doesn't produce anything either.
I'm seeing any error messages in any logs. Using FF 3.6.7 on Fedora 13.
Help? :)
Title: Right Click Functionality
Post by: JohnDoh on August 20, 2010, 06:51:25 AM
any JS errors? are you using any other plugins?
Title: Re: contextmenu and roundcube 4.0-20100807
Post by: tsjolshagen on August 20, 2010, 07:04:12 AM
Quote from: JohnDoh;29530
any JS errors? are you using any other plugins?
Not seeing any JS errors in the FF error console.
As for plugins, the list from main.inc.php:
// List of active plugins (in plugins/ directory) $rcmail_config['plugins'] = array( "compose_newwindow", "compose_addressbook", // "contextmenu", "calendar", "pw_recovery", // "markasjunk", "markasjunk2", "jqueryui", "forwardattachment", "globaladdressbook", "sendmessage", "message_highlight", "sauserprefs", "sticky_notes", // "vacation", // Need to edit & make it work first! "automatic_addressbook", "keyboard_shortcuts", "emoticons", "session_timeout", "sieverules", "searchbox",
Title: Right Click Functionality
Post by: JohnDoh on August 20, 2010, 01:37:17 PM
hmmm is any one else having the same problem? I'm sorry but without an error message or something I can recreate I really don't know what to suggest.
Title: Right Click Functionality
Post by: dziobak on August 20, 2010, 01:47:19 PM
tsjolshagen: try it with IE. I have two days old version and everythings ok in ff and ie.
Title: Right Click Functionality
Post by: ABerglund on August 20, 2010, 01:49:00 PM
Quote from: JohnDoh;29537
hmmm is any one else having the same problem? I'm sorry but without an error message or something I can recreate I really don't know what to suggest.
No, it's working fine for me. But this sounds suspiciously like a problem I had some time back with a conflict between contextmenu and compose_addressbook, which I see is enabled in the list above. Try disabling compose_addressbook and see if that helps. If so, you may want to verify that compose_addressbook is up to date.
Title: Right Click Functionality
Post by: tsjolshagen on August 21, 2010, 06:24:59 AM
Quote from: dziobak;29538
tsjolshagen: try it with IE. I have two days old version and everythings ok in ff and ie.
Think you may have missed a salient point regarding using IE on these systems; they're running Linux (no IE)
Title: Right Click Functionality
Post by: tsjolshagen on August 21, 2010, 06:47:29 AM
Quote from: ABerglund;29539
No, it's working fine for me. But this sounds suspiciously like a problem I had some time back with a conflict between contextmenu and compose_addressbook, which I see is enabled in the list above. Try disabling compose_addressbook and see if that helps. If so, you may want to verify that compose_addressbook is up to date.
Before I saw this I installed firebug and started disabling plugins in an attempt to locate possible collisions. The plugin that is "colliding" (enabled alongside contextmenu means the UI stalls) is compose_newwindow.
With Firebug installed and compose_newwindow + contextmenu enabled I get one error message:
The bug is in the compose_newwindow please contact the author of that plugin.
Title: Right Click Functionality
Post by: JohnDoh on August 21, 2010, 07:35:23 AM
Quote from: tsjolshagen;29558
When I change the folder and attempt to delete multiple messages from the new folder using right-click, i get the following javascript error:
e is null http://server/directory/program/js/common.js?s=1281197014 Line 339
This has been fixed in the repo.
Title: Right Click Functionality
Post by: mattfox27 on September 21, 2010, 01:04:58 AM
Hello i just installed this in RC .4 and it doesn't work. I tried Firefox and IE i get no right click menu. Does this work for .4?
I'm new to RC this is how its supposed to look in conf file $rcmail_config['plugins'] = array(contextmenu);
Or should it have single quotes ('contextmenu')
I figured it out...im running a plugin called RCguard which opens a Captcha windows after X amount of failed plugins and that kills all my plugins. Anyone run into this issue?
Title: Right Click Functionality
Post by: JohnDoh on September 21, 2010, 03:19:34 AM
You also posted about this here http://www.roundcubeforum.net/7-third-party-contributions/46-api-based-plugins/7282-rcguard-fail2ban-plugin-not-working-together.html. Please do not duplicate posts.
Title: Right Click Functionality
Post by: Cooldown on September 23, 2010, 05:25:26 AM
To all who uses the contextmenu plugin with composenewwindow and got the following error with firebug "uncaught exception: Syntax error, unrecognized expression: Syntax error, unrecognized expression: a" and spend too much time with searching in this forum.
(@offtopic: i hate the captcha and the "answer the question" stuff! This will not prevent the forum from spammers cause the captcha is weak and the questions rotating ... not hard to test against a string. The only thing it does is to prevent users from using the search function with ease)
JohnDoh has given the answer in the following Post http://www.roundcubeforum.net/7-third-party-contributions/46-api-based-plugins/7169-compose-new-window-plugin.html#post29572
To keep Things at one place
Quote from: JohnDoh;29572
[..] The error comes from the JS in the plugin itself, in closewindow.js, this file contains the code which interacts with the context menu. `li.reply :a` and the 3 other similar lines are wrong, take the `:` away and everything works like normal. AFAIK you can’t use selectors like that.
(Jepp there is no :a selector xD)
Btw .. my quick and dirty fix was to replace rcmail.contextmenu_command_handlers = new Object(); with rcmail.contextmenu_command_handlers = ''; in contextmenu.js ^^ works too but as i walked over the source code in contextmenu.js i think this will break the external commands processing.
Just for the record the quick and dirty way seems to work in most cases but i and you should prefer JohnDoh's fix cause this is the source where the error comes from. The Q&D way can cause other problems in other plugins that uses similar functionality.
Regards, Cooldown
Title: Right Click Functionality
Post by: ABerglund on September 01, 2011, 07:46:13 PM
In my test environment, I'm using the latest version of the plugin (20 Aug 2011) in 0.6-beta. I'm seeing an issue I've seen for quite some time with spinning progress wheel during a "mark message" operation. Can anyone else duplicate this? Here are the steps:
Go to any folder with multiple unread messages. Close the Preview Pane if you use it.
Open one message to view it.
While the message is open, right-click the folder that contains the open message, and select "mark all as read".
In my experience, the progress wheel will drop and spin ("markingmessage"), but it never refreshes the folder list, and the dialog never goes away. You need to click into a different folder to escape the hang, at which point all the messages will have been marked as you requested.
Title: Right Click Functionality
Post by: JohnDoh on September 02, 2011, 02:43:01 AM
thanks Arne, that bug has been fixed.
Title: Right Click Functionality
Post by: ABerglund on September 02, 2011, 10:49:48 AM
I can confirm. While all the complete package download links seem to pull the same version I was testing, I could copy and paste the two changed files (contextmenu.js and contextmenu.php) from github into my test instance, and the problem is corrected. Thanks!
Title: Right Click Functionality
Post by: rosali on September 04, 2011, 12:20:01 AM
Yes, it looks like the zip has not been updated. Only the repo version corrects the issue.
Title: Right Click Functionality
Post by: anglebaby on September 04, 2011, 11:50:20 PM
Also applies when attempting to delete a single message in a new folder
Title: Right Click Functionality
Post by: Schmatze on September 11, 2011, 07:03:03 AM
I'm using roundcube 0.5.4 and if I have contextmenu enabled I can't open the addressbook.
Quote
PHP Fatal error: Call to undefined function html_identifier() in /.../plugins/contextmenu/contextmenu.php on line 272
Title: Right Click Functionality
Post by: JohnDoh on September 12, 2011, 03:44:29 AM
Quote
I'm using roundcube 0.5.4 and if I have contextmenu enabled I can't open the addressbook.
Please read the instructions on the website and make sure you have downloaded the correct version of the plugin for your version of rc.
Title: Right Click Functionality
Post by: Backi on January 08, 2012, 06:48:55 AM
Mark all as read doenst work with latest trunk-version. Dont know if its a general issue or only within my installation. Could you please check that? Thanks.
Title: Right Click Functionality
Post by: JohnDoh on January 08, 2012, 08:01:01 AM
it was updated at the start of september, please update to a newer version of the plugin.
Title: Right Click Functionality
Post by: Backi on January 08, 2012, 08:07:08 AM
I already updated both, roundcube to latest svn and december-version of contextmenu! It still doesnt work :(
Title: Right Click Functionality
Post by: JohnDoh on January 08, 2012, 08:38:59 AM
december version? if you are using the svn trunk version of the core then please use the repo version of the plugin. this might be the change you need https://github.com/JohnDoh/Roundcube-Plugin-Context-Menu/commit/434a019ab9153c78f9c28e2e019206e203b6dc97
Title: Right Click Functionality
Post by: Backi on January 08, 2012, 09:16:01 AM
thanks - thats ist. didnt know that theres a repo-version of the plugin. btw: downloading the master or any other version as zip didnt work out (error 502) - i had to copy and paste the modified files.
Title: Right Click Functionality
Post by: tparvais on March 12, 2012, 08:00:21 AM
hello
is it possible to add the option , via right-click on one folder, to create a new IMAP subfolder ? would be great to better manage the imap folders.