Roundcube Community Forum

Release Support => Requests => Topic started by: Scubes13 on September 21, 2006, 04:12:01 PM

Title: Signature Above Quoted Text in a Reply...
Post by: Scubes13 on September 21, 2006, 04:12:01 PM
It would be nice if one could set their preferences to place their signature above the quoted text when replying to an email.

I know it might not be the best Net-ettiquette (think I even spelled it wrong) - but in Thunderbird, I have my sig automatically placed above the quoted text.

In roundcube I have to scroll to the bottom of the message, grab the sig, then cut and paste it to the top of the new message.

Anyone have any suggestions as to how we might make this happen?

Kevin L.
Title: Re: Signature Above Quoted Text in a Reply...
Post by: LeviFig on September 28, 2006, 06:25:24 PM
I hear ya m8 =)
I do the same everywhere... can't stand the idea of someone having to scroll allllll the way down a long quote for ex. just to check my sig (which is something I definetly want people to look at - hence it's purpose :p)

Let's w8 and see if the devs check this =) (it can be a challenge code-wise... I don't know... maybe not:p)


ch33rs,
~Levi F. aka EinZteiN
Title: Re: Signature Above Quoted Text in a Reply...
Post by: yllar on September 29, 2006, 03:20:39 PM
imho top-posting is not very comford to read and therefore cursor should go to the bottom of the mail when replying .. right where the signature is :)
Title: Re: Signature Above Quoted Text in a Reply...
Post by: reefnet on September 29, 2006, 05:32:50 PM
I agree...DOWN [sic] WITH TOP POSTING!! The default should be bottom posting, perhaps with an option to use top-posting if you really must (don't do it!).
Title: Re: Signature Above Quoted Text in a Reply...
Post by: goettler on October 14, 2006, 12:35:52 AM
Seems like this is a question of taste. I personally also prefer the signature above the quoted text...this makes it easier to read for long email chains with different senders.

For all those interested, this is an easy fix in 'app.js'. Simply modify the code as follows:

// add the new signature string
  if (this.env.signatures && this.env.signatures[id])
   {
   sig = this.env.signatures[id];
   if (sig.indexOf('--')!=0)
   sig = '--\n'+sig;
   message += '\n'+sig;
   message = '\n\n'+sig+'\n\n'+message;
   }
Title: Re: Signature Above Quoted Text in a Reply...
Post by: zyzzyvas on October 14, 2006, 09:57:00 AM
Top/bottom posting is partly an issue of taste, but mostly an issue of netiquette. And common sense.

because it breaks the flow of conversation.
The main reason you should NOT top post is...


But there are plenty of other good reasons [http://www.caliburn.nl/topposting.html (http://www.caliburn.nl/topposting.html)]. Basically, remember that your email is written for someone ELSE to read, not you. Make it easy for the recipient to understand and reply to himself.

That also means not quoting the whoooole message in a reply. As a general rule, if the amount of quoted text in your email is more than your own text, you have probably quoted too much.
Title: Re: Signature Above Quoted Text in a Reply...
Post by: DarthNerdus on November 16, 2007, 09:58:48 PM
I agree with the arguments for bottom-posting. But is there a good script that would really make RoundCube set it's compose page up for bottom posting well?

I'd just like to see it maybe move the cursor below the quoted message and above the signature or something. Thanks for any input!

Title: Re: Signature Above Quoted Text in a Reply...
Post by: delsurf on January 16, 2008, 09:20:28 AM
Thanks for this fix, just what I was looking for!
Title: Re: Signature Above Quoted Text in a Reply...
Post by: buglerroller on February 07, 2008, 03:12:16 PM
Quote from: delsurf
Thanks for this fix, just what I was looking for!

are you using v0.1-rc2? if so what did you do. the code on v0.1-rc2 is;
Code: [Select]
// add the new signature string
   if (this.env.signatures && this.env.signatures[id])
    {
    sig = this.env.signatures[id]['text'];
    if (this.env.signatures[id]['is_html'])
     {
     sig = this.env.signatures[id]['plain_text'];
     }
    if (sig.indexOf('-- ')!=0)
     sig = '-- \n'+sig;
    message += '\n'+sig;
    }
   }

when i remove the line message += '\n'+sig; no signature appears.
Title: Re: Signature Above Quoted Text in a Reply...
Post by: buglerroller on February 07, 2008, 03:22:42 PM
ahh i get it now.. replace

message += '\n'+sig;

with
   message = '\n\n'+sig+'\n\n'+message;

Title: Re: Signature Above Quoted Text in a Reply...
Post by: pinhead on March 16, 2008, 06:21:35 AM
Tried this for the current version, 0.1, but it doesn't work. The signature keeps appearing at the bottom.

I have emptied my caches, logged out and back in but to no avail. Any ideas?

Nevermind, I made a typo...
Title: Re: Signature Above Quoted Text in a Reply...
Post by: jimcavoli on March 27, 2008, 12:37:41 AM
I think this should be the out-of-the-box default, especially since a)it reads easier, and b)clients like GMail which collapse quoted text will usually pull the sig into that as well.
Title: Signature Above Quoted Text in a Reply...
Post by: smultronstallet on June 21, 2008, 01:28:19 AM
Quote from: goettler;3200
Seems like this is a question of taste. I personally also prefer the signature above the quoted text...this makes it easier to read for long email chains with different senders.

For all those interested, this is an easy fix in 'app.js'. Simply modify the code as follows:

// add the new signature string
  if (this.env.signatures && this.env.signatures[id])
   {
   sig = this.env.signatures[id];
   if (sig.indexOf('--')!=0)
   sig = '--\n'+sig;
   message += '\n'+sig;
   message = '\n\n'+sig+'\n\n'+message;
   }


This only seem to work in plain-text mode. Is there anyway to get it working with HTML/TinyMCE too? (Using 0.1.1)
Title: HTML signatures appear at the top
Post by: Sam Treadway on October 10, 2008, 10:44:49 PM
To have HTML signatures appear at the top of replies and forwards do the following:
Find the file named: "app.js"

search for the following line:
Code: [Select]
editor.getBody().appendChild(sigElem);

Comment the line out or replace with the following code:
Code: [Select]
editor.getBody().insertBefore(sigElem, editor.getBody().firstChild );

If anyone wants to take a stab at a patch with this as an option (tick box) please post it here, thanks! ;D
Title: For HTML emails
Post by: Sverre on November 10, 2008, 10:51:32 AM
Sam beat me to it! I came here a few days ago, went away and came up with almost the same thing:

editor.getBody().insertBefore(sigElem, editor.getBody().getElementsByTagName("p")[0]);

I missed using firstChild!

Regards,
Sverre :-)
Title: Signature Above Quoted Text in a Reply...
Post by: smultronstallet on November 29, 2008, 06:52:57 AM
Quote from: Sam Treadway;14556
To have HTML signatures appear at the top of replies and forwards do the following:
Find the file named: "app.js"

search for the following line:
Code: [Select]
editor.getBody().appendChild(sigElem);

Comment the line out or replace with the following code:
Code: [Select]
editor.getBody().insertBefore(sigElem, editor.getBody().firstChild );

If anyone wants to take a stab at a patch with this as an option (tick box) please post it here, thanks! ;D


Thanks Sam & Sverre, works for me on SVN 2099.

A few things as a minor follow-up regarding HTML mode:

1) Does anyone know how to make it so when you tab into the main composition box, it places the cursor on the first/top line, rather than below the signature? (it only does this on a reply; when creating a new message, it tabs to the first/top line).

2) Is there a way to add an additional empty space to the first line HTML signature so that there is room to write w/o having to manually add another line. In plain-text I just added an extra '\n'... something similar for HTML?
Title: Signature Above Quoted Text in a Reply...
Post by: minusonebit on December 27, 2008, 09:30:01 PM
Quote from: zyzzyvas;3205
Top/bottom posting is partly an issue of taste, but mostly an issue of netiquette. And common sense.

because it breaks the flow of conversation.
The main reason you should NOT top post is...


But there are plenty of other good reasons [Why is Bottom-posting better than Top-posting (http://www.caliburn.nl/topposting.html)]. Basically, remember that your email is written for someone ELSE to read, not you. Make it easy for the recipient to understand and reply to himself.

That also means not quoting the whoooole message in a reply. As a general rule, if the amount of quoted text in your email is more than your own text, you have probably quoted too much.

E-mail is not a conversation. This whole mindset of e-mail being a "conversation" is what led to the creation of g-mail, the world's worst e-mail service. heh, and if you notice, g-mail even puts the most recent message at the top of the thread - or it tries to, I should say. Usually it starts a new thread like an annoying board troll. E-mail is not a "conversation". Think of it like sending electronic postcards back and forth. You may save all your postcards, but do you read all the previous ones before the one that came in the mail today? Maybe if you have a few screws loose, but most people would read the most recent postcard, then refer to the older ones as, when and if needed.

Having to scroll through previous quoted messages (which can sometimes be pages and pages in length) to get the signature of a message is just goofy, but I realize some people just have to be different, so whatever, I find it very annoying. The idea that I should scroll past all that crap to find the message as well is just plain goofy. Unless that e-mail was from a boss or someone important (i.e. someone who has something I want - i.e. a paying customer), I'd likely delete it rather than read it. Time is too precious to waste it on people who waste it intentionally by being petty.

And the link you rely on for support of your position is written by someone who does not know the difference between Usenet and E-Mail. They are NOT the same thing. Usenet is a conversation, e-mail is not. Netequitte is fine and dandy. Some of it has a purpose and a place (like NOT TYPING IN ALL CAPITAL LETTERS) but most of it is junk that people with way too much time on thier hands and who are way too willing to tell others what to do come up with.
Title: Signature Above Quoted Text in a Reply...
Post by: Julius Caesar on December 29, 2008, 04:52:03 AM
Replying to an email is very simple:

* Delete the unnecessary information.

* Add the answer under each the question asked.

* Add a signature at the bottom.

* Send the email.

This give a small and neat email which has been cleaned and can be read top-down without having to exercise your finger on the scroll wheel.

To extend in the comparison of sending postcards: Repeat the question on the card and add the answer under the question.
Title: Signature Above Quoted Text in a Reply...
Post by: sunside on January 05, 2009, 06:16:40 AM
Quote from: Sam Treadway;14556

Comment the line out or replace with the following code:
Code: [Select]
editor.getBody().insertBefore(sigElem, editor.getBody().firstChild );


May I just ask a naive question - how do I make .js files from the .js.src files which I can edit? There seems to be some compression program being used since version 0.2

Thanks!
Title: Signature Above Quoted Text in a Reply...
Post by: ABerglund on January 07, 2009, 11:18:34 PM
Quote from: sunside;16001
May I just ask a naive question - how do I make .js files from the .js.src files which I can edit? There seems to be some compression program being used since version 0.2

Thanks!
First backup the current compressed app.js file, rename it something like app.js-save. Then rename a copy of app.js.src to app.js. Make your changes to that new uncompressed copy. RC 0.2 stable works fine with an uncompressed app.js.
Title: Compression
Post by: sunside on January 08, 2009, 02:47:47 AM
OK, that's exactly what I did. So I guess then I need to work with an uncompressed file after that.
Title: Signature Above Quoted Text in a Reply...
Post by: Napsty on January 08, 2009, 04:12:00 PM
Quote from: Sam Treadway;14556
To have HTML signatures appear at the top of replies and forwards do the following:
Find the file named: "app.js"

search for the following line:
Code: [Select]
editor.getBody().appendChild(sigElem);

Comment the line out or replace with the following code:
Code: [Select]
editor.getBody().insertBefore(sigElem, editor.getBody().firstChild );

If anyone wants to take a stab at a patch with this as an option (tick box) please post it here, thanks! ;D


Hello... seems to not work anymore in 0.2-stable. Can anyone confirm. Just tried to do exactly this without success :(
Title: Signature Above Quoted Text in a Reply...
Post by: ABerglund on January 08, 2009, 04:33:38 PM
Quote from: Napsty;16158
Hello... seems to not work anymore in 0.2-stable. Can anyone confirm. Just tried to do exactly this without success :(
I've been looking at this as well on 0.2 stable. Here are my results with three different lines of code:

Code: [Select]
editor.getBody().appendChild(sigElem);
This is the default code. Sig is place below the reply. Works fine as long as bottom sig is OK.

Code: [Select]
editor.getBody().insertBefore(sigElem, editor.getBody().getElementsByTagName("p")[0]);
One option for sig above reply. I have not been able to get this one to work with 0.2 stable although it did with previous versions, sig still loads below the reply. Seems to work exactly the same as above.

Code: [Select]
editor.getBody().insertBefore(sigElem, editor.getBody().firstChild );
This code works inconsistently. Sometimes the sig is above the reply, occasionally below, and sometimes the sig is missing completely. In addition, I have noticed that with this code in place, composed messages do not wrap, but each paragraph is a single line, causing both sender and receiver to scroll horizontally.

No answers from me, I don't know enough javascript to be able to debug it.
Title: Solved it for 0.2 Stable!
Post by: a_magoon on February 16, 2009, 10:45:42 PM
http://www.roundcubeforum.net/general-discussion/4263-roundcube-0-2-stable-signature-fix.html

check out my post here guys.
Title: That is one cool projection clock!
Post by: llf1213 on February 16, 2009, 10:59:03 PM
This clock projects the time, date, or temp on the wall or ceiling Wholesale Clocks Shipped To You Direct From Chinese Wholesaler (http://www.liangdianup.com/clocks_1.htm)  some people call
it a ceiling clock but I call it a digital projection clock. I got the black one because at the time that was the only color
they had. But now they have them in black and also in white.