Roundcube Community Forum
SVN Releases => Issues & Bugs => Topic started by: Andre_E on January 09, 2007, 05:32:19 PM
-
Dear all,
I do have a 'small' issue with my RC install. i'm using the SVN TRUNK #451 'incl advanced addressbook' and i love it.
But when i compose a new mail i always get the lowest priority :? In the 'compose.inc' file it say's:
function rcmail_priority_selector($attrib)
{
list($form_start, $form_end) = get_form_tags($attrib);
unset($attrib['form']);
$attrib['name'] = '_priority';
$selector = new select($attrib);
$selector->add(array(rcube_label('lowest'),
rcube_label('low'),
rcube_label('normal'),
rcube_label('high'),
rcube_label('highest')),
array(5, 4, 0, 2, 1));
$sel = isset($_POST['_priority']) ? $_POST['_priority'] : 0;
$out = $form_start ? "$form_start\n" : '';
$out .= $selector->show($sel);
$out .= $form_end ? "\n$form_end" : '';
return $out;
}
What is wrong?
-
I'm having the same issue.... :-\
-
same here, no ideas...
-
Nothing is wrong there,
The problem comes from "program/include/rcube_shared.inc".
You can use the attached patch to fix this bug.
Dear all,
I do have a 'small' issue with my RC install. i'm using the SVN TRUNK #451 'incl advanced addressbook' and i love it.
But when i compose a new mail i always get the lowest priority :? In the 'compose.inc' file it say's:
What is wrong?
-
Nothing is wrong there,
The problem comes from "program/include/rcube_shared.inc".
You can use the attached patch to fix this bug.
Thanks for your patch, but witch part of the rcube_shared.inc file do i have to replace with your part?
-
Nothing is wrong there,
The problem comes from "program/include/rcube_shared.inc".
You can use the attached patch to fix this bug.
Thanks for your patch, but witch part of the rcube_shared.inc file do i have to replace with your part?
Just untar the pach in the root folder of your installation and apply it with "patch -p0 < fix-prio-v2.patch"
This is the only thing to do :)
Best regards,
Alex R.
-
Alex, your the best :) Thanks, this fixed my problem at ones ::)
Kind regards, Andre
-
How do I apply this patch if i dont got SSL access to my webspace?
-
THANKS so much for posting this, it helped me greatly!
;D
-Rick
Nothing is wrong there,
The problem comes from "program/include/rcube_shared.inc".
You can use the attached patch to fix this bug.
Dear all,
I do have a 'small' issue with my RC install. i'm using the SVN TRUNK #451 'incl advanced addressbook' and i love it.
But when i compose a new mail i always get the lowest priority :? In the 'compose.inc' file it say's:
What is wrong?
-
If you have just source access you can solve this by editing the ./program/includercube_shared.inc
Change the line 1015 which says:
$selected = ((!empty($option['value']) && in_array($option['value'], $select, TRUE)) ||
(in_array($option['text'], $select, TRUE))) ? $this->_conv_case(' selected', 'attrib') : '';
Into:
$selected = ((isset($option['value']) && in_array($option['value'], $select, TRUE)) ||
(in_array($option['text'], $select, TRUE))) ? $this->_conv_case(' selected', 'attrib') : '';
This bug is still in the SVN version.
-
Sorry for the lat response, but here are some tips to apply the patch...
You can download rcube_shared.inc from your webspace on your local machine, open it with your
favorite text editor ( wordpad, pico, vim etc. ) and just replace at line 1012 following :
foreach ($this->options as $option)
{
$selected = ((!empty($option['value']) && in_array($option['value'], $select, TRUE)) ||
(in_array($option['text'], $select, TRUE))) ? $this->_conv_case(' selected', 'attrib') : '';
$options_str .= sprintf("<%s%s%s>%s</%s>\n",
$this->_conv_case('option', 'tag'),
!empty($option['value']) ? sprintf($value_str, $option['value']) : '',
$selected,
Q($option['text'], 'strict', FALSE),
$this->_conv_case('option', 'tag'));
with
foreach ($this->options as $option)
{
$selected = (((isset($option['value']) && ($option['value'] == 0 || !empty($option['value']))) && in_array($option['value'], $select, TRUE)) ||
(in_array($option['text'], $select, TRUE))) ? $this->_conv_case(' selected', 'attrib') : '';
$options_str .= sprintf("<%s%s%s>%s%s>\n",
$this->_conv_case('option', 'tag'),
(isset($option['value']) && ($option['value'] == 0 || !empty($option['value']))) ? sprintf($value_str, $option['value']) : '',
$selected,
Q($option['text'], 'strict', FALSE),
$this->_conv_case('option', 'tag'));
And upload it back to your webspace. That's all :)
How do I apply this patch if i dont got SSL access to my webspace?
-
Sorry to dig this thread out again -- I am having the described problem when replying to mails. Any idea how to fix this?
-
Fixed this problem by editing "program/steps/mail/compose.inc", from line 713:
$sel = isset($_POST['_priority']) ? $_POST['_priority'] : intval($MESSAGE->headers->priority);
$out = $form_start ? "$form_start\n" : '';
… to …
$sel = isset($_POST['_priority']) ? $_POST['_priority'] : intval($MESSAGE->headers->priority);
if ($sel == 3) $sel = 0;
$out = $form_start ? "$form_start\n" : '';
Bye,
qqilihq.