Roundcube Community Forum

SVN Releases => Issues & Bugs => Topic started by: beliy on October 03, 2018, 06:10:36 AM

Title: Change favicon for skin with extends
Post by: beliy on October 03, 2018, 06:10:36 AM
How is it possible to change favicon.ico for skin with using {"extends": "larry"} ?
With next includes/links.html:
Code: [Select]
<meta name="viewport" content="" id="viewport" />
<link rel="shortcut icon" href="/images/favicon.ico"/>
<roundcube:include file="/includes/links.html" skinPath="skins/larry" />
<link rel="stylesheet" type="text/css" href="/styles.css" />

roundcube generate 2 favicon block and use favicon from extends skin. Please help with it.  Thanks.
Title: Re: Change favicon for skin with extends
Post by: JohnDoh on October 04, 2018, 01:09:59 AM
please could you explain what the issue is you are facing a bit more? it sounds like you have done it correctly and it should work - extend the skin, then either just put your own favicon.ico file in there or create your own includes/links.html and change the favicon link to what ever you like.
Title: Re: Change favicon for skin with extends
Post by: beliy on October 04, 2018, 04:23:57 AM
please could you explain what the issue is you are facing a bit more? it sounds like you have done it correctly and it should work - extend the skin, then either just put your own favicon.ico file in there or create your own includes/links.html and change the favicon link to what ever you like.

I tried to do it for skin harry, but it don't work. You can find current source code here - https://github.com/beliys/harry/tree/master/skins/harry
Title: Re: Change favicon for skin with extends
Post by: JohnDoh on October 04, 2018, 04:53:29 AM
in your links.html you include the original version from Larry that is why you get 2 favicons - the one from your file and the one from the original.

BTW this change, included in 1.4-beta might help https://github.com/roundcube/roundcubemail/commit/4ea790ba37ee556db383a7ee48bfac182b2487a7#diff-f7910780eae15da9c450546603cf3e15 amognst other things it will let you define the favicon in meta.json (in the config section)
Title: Re: Change favicon for skin with extends
Post by: beliy on October 04, 2018, 06:30:13 AM
in your links.html you include the original version from Larry that is why you get 2 favicons - the one from your file and the one from the original.

BTW this change, included in 1.4-beta might help https://github.com/roundcube/roundcubemail/commit/4ea790ba37ee556db383a7ee48bfac182b2487a7#diff-f7910780eae15da9c450546603cf3e15 amognst other things it will let you define the favicon in meta.json (in the config section)

Is it possible to show example define the favicon in meta.json? Thanks.
Title: Re: Change favicon for skin with extends
Post by: JohnDoh on October 04, 2018, 01:35:12 PM
assuming that /skins/myskin/images/myfavicon.ico exists then this will work with 1.4-beta:
Code: [Select]
{
"name": "My Skin",
"extends": "larry",
"config": {
"favicon": "/images/myfavicon.ico"
}
}
Title: Re: Change favicon for skin with extends
Post by: beliy on October 05, 2018, 03:50:32 AM
Thanks, than 1.3.x will be with larry favicon)