Roundcube Community Forum

Release Support => Older Versions => 0.1 Beta 1 => Topic started by: brashquido on July 20, 2006, 09:33:44 AM

Title: TinyMCE Intergration
Post by: brashquido on July 20, 2006, 09:33:44 AM
I know there is apparently a patch to enable intergration (not that I've been able to find a live link for it) of TinyMCE with RoundCube, but I think it would be really great if this was taken on board as an official option. With TinyMCE comes a whole range of really nifty plugins which bolster the functionality of RoundCube a great deal. Just my 2c...


P.S - If anyone knows where I can find detailed instruction for intergrating TinyMCE with RoundCube, I'd really appreciate it.
Title: Re: TinyMCE Intergration
Post by: flosoft on July 20, 2006, 09:50:21 AM
TinyMCE isn't working on all browsers.

But it would be nice to have it as user option. So in your profile you can enable / disable it.
Title: Re: TinyMCE Intergration
Post by: EricS on July 20, 2006, 11:50:13 AM
I've been working for a couple months on integrating TinyMCE into RoundCube. TinyMCE has its quirks, but overall it's a nice editor. My working copy is in a fairly stable state right now - you can download it here (it's based on Subversion rev276 plus my changes):

http://stadtherr.bounceme.net/files/roundcubemail_r276.tar.gz (http://stadtherr.bounceme.net/files/roundcubemail_r276.tar.gz)

I've tested it on Firefox and Safari. Firefox support is solid. Safari has some known JavaScript issues, but the TinyMCE developers have an ongoing dialog with Apple to try to resolve some of the issues. I have heard that it works well with Opera 9, but I haven't done much firsthand testing with that browser. I've done no testing with IE.

When I get time, I hope to be able to extend TinyMCE to understand and display pictures that are attachments to an e-mail message. If there are any TinyMCE-savvy developers out there, I would appreciate volunteers... ;)

I appreciate any feedback...

-Eric
Title: Re: TinyMCE Intergration
Post by: nipun_jain on July 20, 2006, 01:35:45 PM
Did googiespell work for you while sending html messages with tinyMCE? I have too integrated tinyMCE with RC and spell check didn't work. I tried your release and it doesn't seem to work on it too.
Title: Re: TinyMCE Intergration
Post by: brashquido on July 20, 2006, 08:17:07 PM
Browser compatibility is always going to be a concern, but 95% of my traffic is either IE or Firefox which don't seem to have a problem with it. Opera is concern for me at around 3%, but that should lessen over time as Opera 9+ becomes the norm for those users. As suggested anyway I think the implementation of any RTE should be only as an option, selectable in preferences or something like that by the user.

Thanks for the link Eric! I'll try and get a look at it over the weekend. Have you tried loading any of the extra TinyMCE plugins, such as the AJAX spellchecker?
Title: Re: TinyMCE Intergration
Post by: EricS on July 21, 2006, 04:33:25 PM
A couple answers:
Thanks for the feedback! Hopefully we can combine forces here...
Title: Re: TinyMCE Intergration
Post by: hanalei on July 27, 2006, 07:36:51 PM
Hi there

I just installed this and it's freakin awesome.

Two questions:
When tyring to remove some text from the responses (say when there's too many replies), I get a wrapper box so to speak around the entire quoted text and I need to double click in order to edit anything in there. Anything off the top of your head as to why?
Do you think it would be hard to patch new SVN releases? I don't expect that you will for every single one, so I may attempt it if a new one isn't posted down the road.

Thanks for the hack!
Title: Re: TinyMCE Integration
Post by: EricS on July 31, 2006, 01:01:04 PM
I created another snapshot using revision 282 from Subversion:

http://stadtherr.bounceme.net/files/roundcubemail_r282.tar.gz (http://stadtherr.bounceme.net/files/roundcubemail_r282.tar.gz)

I'll probably create another one once there's another relatively stable revision.

Enjoy!
-Eric
Title: Re: TinyMCE Intergration
Post by: markg85 on July 31, 2006, 10:47:41 PM
nice :) but what files do you edit to include this?
Title: Re: TinyMCE Intergration
Post by: EricS on August 01, 2006, 10:23:44 AM
This tarball is a full working copy, and not just a patch. You should be able to "overlay" it on an existing install, or treat it as a fresh installation. If you're starting from scratch, you should be able to follow the normal installation instructions and not have to do anything different. The TinyMCE files are included within the program/js/tiny_mce directory.

-Eric
Title: Re: TinyMCE Intergration
Post by: markg85 on August 01, 2006, 11:26:14 AM
i know that it`s a full working copy :) that`s why i asked what files you changed because i want to try it with some other revisions.. mainly the last one (188)
Title: Re: TinyMCE Intergration
Post by: EricS on August 01, 2006, 12:25:21 PM
Sorry, I misunderstood your question. I have made moderately significant changes to numerous files to enable the integration, which makes a patch difficult to manage. Here are the files I've changed/added, beyond the addition of the program/js/tiny_mce directory:
Code: [Select]
M   program/include/bugs.inc
M   program/include/main.inc
M   program/include/rcube_imap.inc
M   program/include/rcube_shared.inc
M   program/lib/Mail/mime.php
M   program/lib/html2text.inc
M   program/localization/en_US/messages.inc
M   program/localization/en_US/labels.inc
A   program/js/editor.js
M   program/js/app.js
M   program/steps/mail/func.inc
M   program/steps/mail/sendmail.inc
M   program/steps/mail/compose.inc
M   skins/default/templates/compose.html
M   index.php
I'll try to make another snapshot with rev288 soon.
Title: Re: TinyMCE Intergration
Post by: markg85 on August 01, 2006, 05:08:46 PM
thanx :) another question.. how did you generated that list? (i never get that working with winmerge... or do you do it in linux.?? anyway.. how?)
Title: Re: TinyMCE Intergration
Post by: EricS on August 01, 2006, 06:21:31 PM
That's the output of the "svn status" command, run from the top level of my Subversion working copy at the command line (in my case, on MacOS X). If you don't have subversion, you could probably still use "diff -r" to compare to another entire installation. If you're on Windows, you can either install cygwin and use its Subversion client, or use something like "TortoiseSVN."
Title: Re: TinyMCE Intergration
Post by: markg85 on August 01, 2006, 06:33:54 PM
i have no idea how to do it with tortoise svn :P
but can you make diff files next time :P that`s probly alot easyer to implant in a next revision..

EDIT:://

i finally got the diff stuff working.. i have a 1.5MB big diff file now that should patch the revision with the tinymce thing..
it`s so big because files that didn`t exist are in the diff... gonna test it now :)
Title: Re: TinyMCE Intergration
Post by: EricS on August 02, 2006, 10:35:46 AM
Yeah, that's why I don't just have a patch - those new files make it almost as big as a full distribution.
Title: Re: TinyMCE Intergration
Post by: EricS on August 02, 2006, 10:45:52 AM
I put together a new distro based on Subversion rev288:

http://stadtherr.bounceme.net/files/roundcubemail_r288.tar.gz (http://stadtherr.bounceme.net/files/roundcubemail_r288.tar.gz)

This also includes the patch for message sorting on IMAP servers that don't support the SORT command.

Enjoy!
-Eric
Title: Re: TinyMCE Intergration
Post by: markg85 on August 03, 2006, 05:37:07 PM
thanx :) i installed it.. you should consider talking with the developer of this client to get this baby in thise webmail client by default.. would be a gread addition in my opinion

edit:://

or you are slow or the dev team is fast :P revision 291 is in svn :) update please :P
Title: Re: TinyMCE Intergration
Post by: EricS on August 08, 2006, 11:08:44 AM
Here you go:

http://stadtherr.bounceme.net/files/roundcubemail_r302.tar.gz (http://stadtherr.bounceme.net/files/roundcubemail_r302.tar.gz)

-Eric
Title: Re: TinyMCE Intergration
Post by: simplistsims on August 09, 2006, 09:07:59 AM
can you update it for 0.1 Beta 2??
Title: Re: TinyMCE Integration
Post by: EricS on August 11, 2006, 11:46:07 AM
Done:

http://stadtherr.bounceme.net/files/roundcubemail_tinymce_v0.1beta2.tar.gz (http://stadtherr.bounceme.net/files/roundcubemail_tinymce_v0.1beta2.tar.gz)

Enjoy!
-Eric
Title: Re: TinyMCE Intergration
Post by: nipun_jain on August 11, 2006, 01:38:26 PM
Spell checking is not working in the above download. :'(
Title: Re: TinyMCE Intergration
Post by: EricS on August 11, 2006, 03:53:08 PM
I didn't touch anything spelling related - does spell checking work in v0.1beta2?
Title: Re: TinyMCE Intergration
Post by: nipun_jain on August 11, 2006, 05:17:55 PM
I guess so, haven't checked. Will test and update you here.
Title: Re: TinyMCE Intergration
Post by: ioannisjt on September 14, 2006, 02:25:02 AM
It doesnt seem to take the signature either.
Title: Re: TinyMCE Integration
Post by: EricS on September 14, 2006, 05:59:00 PM
TinyMCE has been integrated into the RoundCube trunk, as of Subversion rev 346. Signatures are now supported (both HTML and plain).
Title: Re: TinyMCE Intergration
Post by: ioannisjt on September 14, 2006, 07:27:35 PM
Pardon the ignorance but how do i go about getting this version ("Subversion rev 346")?
Title: Re: TinyMCE Intergration
Post by: nipun_jain on September 15, 2006, 01:25:21 AM
You need a subversion client. If you are on linux, it's natively supported in most distros, if you are on windows, then add a third party utility like tortoise svn. You can have a detailed info from the roundcube wiki.
Title: Re: TinyMCE Intergration
Post by: adamcraig on September 26, 2006, 03:16:15 PM
Hello!

Could you point me to the location where I might change the url that points to the tiny_mce install. I would like to utilize the same installation of tinymce that I am already using for my drupal CMS.

Thanks.
Title: Re: TinyMCE Integration
Post by: Chadi on October 17, 2006, 06:15:46 PM
Quote from: EricS
TinyMCE has been integrated into the RoundCube trunk, as of Subversion rev 346. Signatures are now supported (both HTML and plain).


Just curious, I do not see any option to insert HTML signature in Personal Settings. Please clarify.
Title: Re: TinyMCE Intergration
Post by: EricS on December 25, 2006, 05:22:29 PM
Sorry for the late response, but the HTML signature feature didn't make it into the "beta2" release. You'll either have to grab an SVN version, or wait for the next release.
-Eric