Roundcube Community Forum

Release Support => Requests => Topic started by: bozhe on August 11, 2006, 10:05:23 AM

Title: Expanding/Collapsing folders and HTML Editor
Post by: bozhe on August 11, 2006, 10:05:23 AM
I am switching a town government network to RoundCube. I love your project and I appreciate the great work that you all are doing!
My immediate supervisor is going nuts over the expanding/collapsing folders issue as he has a lot of folders. Sometimes "little" things like this can make or break the implementation of a project. I also think that an HTML Editor in the mail compose form would be great. In the 21st century most users expect these features and one sees HTML Editors everywhere nowadays. Not having one makes RoundCube seem a little behind the times, unfortunately.

Thanks again,

bozhe
Title: Re: Expanding/Collapsing folders and HTML Editor
Post by: xoqez on August 12, 2006, 03:01:40 AM
The folders i do not know about but the html editor i do

take a look at http://roundcubeforum.net/forum/index.php?topic=378.0

this may help

Thanks
Title: Re: Expanding/Collapsing folders and HTML Editor
Post by: hobbes on August 12, 2006, 04:56:52 PM
I have to say that upgrading a government network to use a BETA product is probably the worst idea in the world. Sometimes little things like that can lose you your job.
Title: Re: Expanding/Collapsing folders and HTML Editor
Post by: SKaero on August 23, 2006, 01:58:42 AM
Well, I think there was someing with the Collapsing folders some were, but I can't find it, I think it was on the forum before it crashed, as for the HTML Editor you have the code to put it in, but It need to be put into the svn
Title: Re: Expanding/Collapsing folders and HTML Editor
Post by: NaiosKae on January 04, 2007, 01:45:29 AM
Hi

I have started some work tohave folders expansind/collapsing

try this if you want http://hypercube.dynalias.org/~naios/rcmaillist.tgz

it only works with javascript and css

Title: Re: Expanding/Collapsing folders and HTML Editor
Post by: seansan on January 04, 2007, 07:46:18 AM

NaiosKae, it looks good.

Though I receive an error - line 123 -> rcube_list_widget undefined (IE7).

Furthermore the folderlist is showing a little strange. Too much to the left and the + sign seems to have alot of space around it. See attachment

Quote from: NaiosKae
Hi

I have started some work tohave folders expansind/collapsing

try this if you want http://hypercube.dynalias.org/~naios/rcmaillist.tgz

it only works with javascript and css


Title: Re: Expanding/Collapsing folders and HTML Editor
Post by: NaiosKae on January 04, 2007, 09:21:13 AM
Ok, I have made some more changes.

it 's now a little bit nicer

and can be tested here : https://hypercube.dynalias.org/roundcube/ (log in as demo/demo)
files are still downloadable at http://hypercube.dynalias.org/~naios/rcmaillist.tgz

And now folder are defaultly collapsed

My code is not really clean but can be used by the dev team to be integrated in your way (wich is nicer than mine)

note that I have only tested it with Firefox 1.5 and 2.0 so behavior could be different using other browsers (like IE due to css2 integration I have no windows to test with IE so I let someone else do this part of the job ;))

I will next look to alternate plus and minus symbols but I think that's not the easiest part of the thing

A thing that I have absolutly no idea how to do, is expanding folders when dragging mail over (perhaps am I not clear)
Title: Re: Expanding/Collapsing folders and HTML Editor
Post by: daashag on January 04, 2007, 10:21:16 AM
What version of RC did you implement this on?
Title: Re: Expanding/Collapsing folders and HTML Editor
Post by: NaiosKae on January 04, 2007, 10:23:46 AM
I made those changes in rc 0.1 beta 2 tarball

Note that generated code is not fully w3c compliant (in fact it uses an tag before the
  • tag and that shouldn't be done, but I don't know how to avoid this).
  • Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: daashag on January 04, 2007, 10:40:07 AM
    It doesn't seem to work with the latest svn. The folders expand and collapse but you can't click on any of the folders to open them.


    edit: Looks very nice though. Nice addition to RC.
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 04, 2007, 10:51:35 AM
    Few reason can be imagined

    First one, as I said before, It behavior can be affected from one browser to an other, I can only test with Firefox (2.0 at home and 1.5 at work, both running on debian system).

    Second one, func.inc has been modified from beta to SVN version.

    I only modify the beta, because, today, the source code of this version is fixed. If the dev team includes it in the project, then it may work in the SVN version, and considered in source code changes.


    what behavior do you have with my own server (using demo user?)
    Is there the same problem? what browser/system are you running on ?


    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: daashag on January 04, 2007, 11:03:27 AM
    It works on both Firefox2.0 and IE6 using the beta on my server as well as yours. However the plus signs are positioned better with Firefox2.0.
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: seansan on January 04, 2007, 11:33:48 AM
      Good update - I would recommend though to try and incorporate the code in the latest SVN. this would avoid later retesting. (
    PS. I tried diffing against SVN 445 - but the differences are vast. I dont know what was added/changed for these folder actions)

    My feedback (also see attachment - in IE7)
    • Folders are still aligned to far to the left, or at least different from my own RC
    • Plus sign doesnt turn into a minus (-) when expanded
    • Sub - sub folders are not recognizable as such and treated (in view) as folders under demo
    • What happens when the subfolder list is so large that it will not be viewable anymore in the left window?
    example.
    + folder 1
    + folder 2
    + folder 2.1
    + folder 2.1.1
    + folder 2.2

    instead of
    + folder 1
    + folder 2
     + folder 2.1
      + folder 2.1.1
     + folder 2.2
    [/list]
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 04, 2007, 12:00:55 PM
    As I said before, The plus placement problem is due to css2 interpretaion with browsers, I can't test with IE so I can't correct this. If someone could, it would be a nice Idea.

    To make this fully w3c compliant, we have to move the Anchor tag inside the list item tag and force placement with css in the outside left of the list Item (don't now if it will work, I will try at a later time)

    plus/minux toggle, I 'll try to make it later cause I don't know if background images defined in css are accessible in javascript and if it is a writable object.

    Quote
    What happens when the subfolder list is so large that it will not be viewable anymore in the left window?
    I'm not sure but it should not affect the default behavior (in FF2.0) because when placing the plus symbol, css move the Li margin on the left to put it back in the right place.
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: seansan on January 04, 2007, 12:04:09 PM
    Good update - I would recommend though to try and incorporate the code in the latest SVN. this would avoid later retesting.
    (PS. I tried diffing against SVN 445 - but the differences are vast. I dont know what was added/changed for these folder actions)

    please find screenie of test results in opera
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 04, 2007, 12:44:56 PM
    changes appears in bold text here:

    ** cutted due to global modification, code was extremly boggy so don't use it anymore **
    try http://hypercube.dynalias.org/~naios/rcmaillist.tgz which is replace at each change.
    I'll tell you in this topic for any change

    modification are prefix by comment like "addition to implement folders expanding/collapsing"

    or some thing like this


    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 05, 2007, 03:00:40 AM
    new version available, should be a better one

    could you please try it with your different browser

    Changes have been applied to my demo site
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: seansan on January 05, 2007, 03:29:54 AM

    Browser = IE7

    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 05, 2007, 03:33:42 AM
    Ok, thanks, we're now approaching the result we want.

    I don't know how to correct this on IE, perhaps someone could help

    source code on the top of the page is not the good one
    (but is now commented look for text addition) and is now w3c compliant

    see next what it looks like in FF1.5
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: seansan on January 05, 2007, 05:28:59 AM

    Looks better - in Opera it looks better now too.

    Seen both attachments for OPERA and IE7.

    OPERA - see strange select of a mailbox
    IE7 looks boggy - due to spaces,  's etc... I dont know what the CSS \* tag is for IE7
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: daashag on January 05, 2007, 05:36:58 AM
    Quote from: NaiosKae
    Ok, thanks, we're now approaching the result we want.

    I don't know how to correct this on IE, perhaps someone could help

    source code on the top of the page is not the good one
    (but is now commented look for text addition) and is now w3c compliant

    see next what it looks like in FF1.5


    Do you have a link for the updated code. Does the code at the top of this page work on svn?  Thanks
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 05, 2007, 05:41:02 AM
    link is http://hypercube.dynalias.org/~naios/rcmaillist.tgz

    I update the tarball for every change

    I haven't tested for SVN version but you can (just be sur to backup the 2 files)

    Opera behavior seems to be the same as FF1.5, was it different in the original version ?

    does anyone know the hooks I need for IE7 ?

    (Ok, I have installed putty on my game machine so I don't have to reboot the system to make tests on IE7)
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: seansan on January 05, 2007, 06:49:32 AM
    < !--[if lte IE 7]> CODE < ![endif]-->
    < !--[if lte IE 6]> CODE < ![endif]-->
    < !--[if lte IE 5.5]> CODE < ![endif]-->


    ??
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: seansan on January 05, 2007, 06:56:41 AM
    hmmmm found something little bad.

    When opening a message for reading - the folderlist is still there (should be upload section). It also creates errors as it is referencing mail list items - that dont exist now
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 05, 2007, 07:04:17 AM
    I'm sorry but I don't uderstand what you mean (probably due to a wrong translation). Do you have a sample?

    EDIT:
    If errors you talk about are that folders mentionned in the cron mail are not shown in the maillist, it's not an error, this mail just indicates that imap tree is regenerated each hours.

    Maildir is the root of the user IMAP box corresponding to INBOX

    folders like .demo.test.sub2 are user folders in imap box

    cur, tmp, courierimapacl,maildirfolder,courierimapkeywords,new,courierimapuiddb are here for the server to administrate the imap folder.


    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: seansan on January 05, 2007, 07:41:00 AM

    See attachment - normally the folderbox is not there. Otherwise see RC demo on site
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 05, 2007, 07:47:59 AM
    I always had the folder tree, even before I made any changes... perhaps different in the svn version

    EDIt:
    look at this http://www.roundcube.net/?p=screens
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: daashag on January 05, 2007, 07:57:52 AM
    Hey Naio, this is a really cool feature. Right now I have to scroll up and down the folder box to see all my folders. It would be nice to have this feature working in the svn, since the svn also has some really nice features that the beta doesn't. I have been trying to get this work on the svn and I am not having much luck. If you get a chance can you look at making this work on the svn? Thanks
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 05, 2007, 08:04:01 AM
    I'll try, no promise on the result but I'll try

    EDIT 1 :
    Ok, its done for svn trunk (still have IE troubleshooting)

    look at http://hypercube.dynalias.org/roundcube-svnhttps://hypercube.dynalias.org/roundcube-svn log in as demo/demo

    EDIT 2 : les codes sources respectifs sont disponibles dans la section downloads de  sources codes are available in download section http://hypercube.dynalias.org
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: daashag on January 05, 2007, 08:37:15 AM
    The
    Quote from: NaiosKae
    I'll try, no promise on the result but I'll try

    EDIT 1 :
    Ok, its done (still have IE troubleshooting)

    look at http://hypercube.dynalias.org/roundcube-svn log in as demo/demo

    EDIT 2 : les codes sources respectifs sont disponibles dans la section downloads de http://hypercube.dynalias.org

    The link doesn't work and I don't understand what your saying on EDIT 2 as I only speak english
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 05, 2007, 08:40:54 AM
    Sorry for speaking french (english is not really natural for me ::) and sometimes, I'm quiet away)

    I gave you a wrong link, roundcube is in the https area so https://hypercube.dynalias.org/roundcube-svn or use communication link on the http main page

    Edit: You're right there are some good enhancement in the svn version. Users at work will enjoy the preview pane.
    Edit 2 : svn version 445
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: daashag on January 05, 2007, 09:11:44 AM
    Works like a charm... Very nice  Thanks :D
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 05, 2007, 09:13:29 AM
    You're welcome
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: seansan on January 05, 2007, 02:35:02 PM
    Looks good - also nice to see it in the SVN

    See attachment for IE7 - still something wrong here. Wonder if we have a CSS expert that can help out?

    Furthermore. The mailbox listing stays there when I open a message to view. This is not normal behavior. Although I see it on the regular demo too. Hmm maybe log a new issue
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 05, 2007, 02:47:42 PM
    That was the default behavior of the svn version

    Could someone test and post a result using opera
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: daashag on January 05, 2007, 03:08:42 PM
    The svn Looks good in Opera. How do you make and post a print screen?
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: seansan on January 05, 2007, 04:15:00 PM

    Did you see the IE7 attachment - and the issue? (see post above)

    ps. Screen cap can be best made with zapgrab -> http://masterzap.is-a-geek.com/~zap/zapgrab.html then paste in empty image (or some systems -> to desktop and image is created)

    ps. YOur site : look at http://hypercube.dynalias.org/roundcube-svn log in as demo/demo
     seems to be down
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 05, 2007, 05:48:20 PM
    No it's not down, As I've said in a previous post, I made a mistake adress is https://hypercube.dynalias.org/roundcube-svn/
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: daashag on January 06, 2007, 05:55:29 AM
    Quote from: NaiosKae
    That was the default behavior of the svn version

    Could someone test and post a result using opera

    Figured out how to do a screen print. Little program called gadwin   http://www.gadwin.com/printscreen/

    Here is a shot of it in Opera. Looks pretty sweet
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 06, 2007, 06:31:13 AM
    Cool It works well. Just have to find how to make it works with IE
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: limubay on January 07, 2007, 03:12:13 PM
    Hi all,

    I experienced the same behaviour with Firefox 2.0, I just deleted cookie and so on and after that all works fine !! ;-) I don't think it could be help you for IE !!

    I have a request for you, when you jump from the email tab' to the Address book' tab for example, and after that come back to the emails' tab, all folders come back collapsed !! There is a possiblity to avoid this ??

    Thx and congratulation for you work !

    Limubay
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 08, 2007, 02:17:05 AM
    There are some posiblities to do this.
    But that needs a storage of each node status, this I'm fear it could be very long for long lists of folders (about 30 for me at work : 15 in Inbox and 15 in sent-mail).
    You can try, I won't for the moment (I won't have lot of time in the following weeks)


    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on January 20, 2007, 05:11:55 AM
    Hi every body, I tried with the new svn trunk. It still works (files concerned haven't been changed)

    May it be integrated in the svn version ?
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: mrjaguar on February 05, 2007, 11:58:50 PM
    Hello,
     this is probably a relatively easy thing to change, but is there a way to remember the expanded/collapsed state when changing pages or logging in/out?

    thanks,
    pat.
    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on February 06, 2007, 02:11:57 AM
    Hi I don't have any time for the moment, I'll take a look later even if I can't say when...

    I'm sorry to inform you that due to excessive hack tries on the demo user on my web site, this one as been volontary deleted, so you won't be able to try it anymore there.

    Title: Re: Expanding/Collapsing folders and HTML Editor
    Post by: NaiosKae on April 16, 2007, 05:45:33 AM
    If you look on the general discussion of svn version, someone has done it.

    The way he made it is nicer than mine, I can only suggest you to use his one.