When I try to delete a email after reading the email by pushing the trash can I get the following error from IE 6 / 7
Line: 1304
Char: 5
Error: 'this.message_list'is null or not an object
Code: 0
URL: http://webmail.domain.com/?_task=mail&_action=show&_uid=14470&_mbox=INBOX
When I go back to the default view where I can see al the emails I'm able to delete the email....??
I'm seeing the same behavior, I'm not sure what caused the change. I'm currently running revision 359.
Ack. Same here.
I, too, am seeing the same error in IE. On top of this, Firefox, while not reporting an error, also produces the same symptom (cannot delete an email while reading it).
I am not sure if it is related, but after selecting "Empty" while on the Trash folder screen, I receive the confirmation dialogue, but none of the emails in the Trash are deleted. This, too, happens in both IE and Firefox.
Quote from: Reload When I try to delete a email after reading the email by pushing the trash can I get the following error from IE 6 / 7
Line: 1304
Char: 5
Error: 'this.message_list'is null or not an object
Code: 0
URL: http://webmail.domain.com/?_task=mail&_action=show&_uid=14470&_mbox=INBOX
When I go back to the default view where I can see al the emails I'm able to delete the email....??
On firefox, while reading the message, i can't delete it by using the delete icon...
Then if i go to my inbox, i can delete it from there...
Does anybody know how can i solve this problem?
To workaround this problem run "svn -r353 update". This reverts the code to before the "Partial client re-write with a common list class" commit which seemed to break deleting messages.
I too find I can not do a select all, delete and various other things unless I'm on revision 353 or before.
You can then check if there have been any updates to fix this with "svn -u status" to see if there are aany new revisions, and then see what the log entry for them is with something like "svn -354:HEAD log".
Hope this helps till it's fixed!
Quote from: yakuza I'm seeing the same behavior, I'm not sure what caused the change. I'm currently running revision 359.
i'm running svn 360, still the same behavior, can't delete the mail when you're reading it
Revision 360 - i can't move messages too. Maybe someone have a solution, how to change the code?
I gave a solution! run svn -r353 update to revert to working code.
Well, i'm running 360, and i managed to patch the js script to make the delete button work.
Although it works for me, i don't guarantee anything:
you have to edit program/js/app.js
line 1236: replace
var selection = this.message_list.get_selection();
if (!mbox || !(selection.length || this.env.uid) || mbox==this.env.mailbox)
return;by
if (!(this.env.uid)){
var selection = this.message_list.get_selection();
if (!mbox || !(selection.length) || mbox==this.env.mailbox)
return;
}
line 1273: replace
var selection = this.message_list.get_selection();
if (!(selection.length || this.env.uid))
return;by
if (!(this.env.uid)){
var selection = this.message_list.get_selection();
if (!(selection.length))
return;
}And at line 1303, replace:
var selection = this.message_list.get_selection();
if (!(selection.length || this.env.uid))
return;by
if (!(this.env.uid)){
var selection = this.message_list.get_selection();
if (!(selection.length))
return;
}
Hope that helps :)
THanks a lot. That works for me! :)
I still say it would be better to revert to the working revision than manually apply code updates. It's good that there is a solution (and hopefully somebody notices and commits it to make it official), but the problem with manual updates is svn will now merge your local updates to the repo updates. You will either end up with source code that's not the same as it should be, or conflicts where further updates need manual merging.
Admittedly you can just delete and re-checkout those files as and when but still....
Nice work writing a solution though! :)
I totally agree with you taz, it was just to say "there is a solution keeping new features", it is not an official patch or whatever else, it is not meant to be keeped in a future release.
It is for testing purposes, only trying to fix r360.
So if you want to use rev360, go with the patch, but if you just want to see what's new in the svn and don't want to mess up the code on svn updates or force checkout next time don't patch anything guys :)
tnx madz, the solution works for me ! :)
I committed a fix to Subversion (rev 364) that fixes this issue.
-Eric
When using 364 I'm unable to delete selected emails from my spam folder... :'(
Madz version is working much better... ;D