One thing in address book

[wisekaa03]

Hello!
In program/steps/addressbook/func.inc:rcmail_get_cids ldap database (AD) I cannot see most of my AD contacts.
Now I fixed this little bug, but it is necessary to adopt.

(pts/1)[root@mail:/usr/local/www/roundcubemail/program/steps/addressbook]# diff func.inc func.inc.bak
778d777
< /*
787d785
< */
789c787
< /*        } */
---
>         }

[JohnDoh]

just out of interest what version of rc what that diff made against? i had a quick look in 0.9 and 0.8 and i dont think its either of them....

[wisekaa03]

I use GIT version...

[JohnDoh]

are you sure? unless i'm reading it wrong the lines in your diff do not match the file at all...... https://github.com/roundcube/roundcubemail/blob/master/program/steps/addressbook/func.inc#L778

[wisekaa03]

(pts/1)[root@mail:/usr/local/www/roundcubemail/program/steps/addressbook]# diff func.inc func.inc.bak
778c778
< /*        if ($sep = strrpos($id, '-')) {
---
>         if ($sep = strrpos($id, '-')) {
785c785
<         else { */
---
>         else {
787c787
< /*        } */
---
>         }

[JohnDoh]

if RC is using contact IDs with `-` in them other than to delimit between the source and the contact ID then I would guess there is a problem with the LDAP code somewhere. if you use the built in LDAP address book then i think may be you should open a ticket at trac.roundcube.net and detail a bit more about your setup and add some example contact IDs and see what the devs think.

sorry to the devs if i'm wrong but I know that code in func.inc is correct its the ID which seems to be wrong.

[wisekaa03]

Ok, I will open a ticket. Thank you.