Roundcube Community Forum

 

[0.6] Roundcube CardDAV Plugin

Started by EdMolf, October 02, 2011, 04:23:32 PM

Previous topic - Next topic

huhn_m

#60
Thanks for the nice and constructive comment, mbsouth. Really makes you feel your contribution is valued in this community .... not ...

It works for me. With the div presented above and honestly I could care less if it works for others. Which "Methoden in RC0.9" should I look at? I investigated the git head database abstractions and came up with this - for me working - solution. And I don't care for the other 3rd party plugins. I don't want to fix all problems but only mine.

But why bother. Owncloud 5 will have its own mail program and obsolete roundcube for me anyways.

mbsouth



Quote...contribution is valued in this "community"...
As you have already said is this is a "user to user community".

QuoteI don't want to fix all problems but only mine.
You just solves your problems but you want constructive comments ;-)

Quote...And I don't care for the other 3rd party plugins....
That's right. Changes in source code belongs to the author's code repository - or fork it the right way.

"rcube_contacts" doesn't use num_rows() any more because PDO does not offer a function like "num_rows", it only offers "rowCount()"  which returns the number of affected rows. Just in this case, in MySQL, the effect is the same - "rowCount" returns the number of rows in a select - but this behavior does not necessarily extend to other databases. http://php.net/manual/en/pdostatement.rowcount.php

Instead the code above
($rcmail->db->affected_rows($result))
you can also use
...( 0 == 0 )...
it has no effect and isn“t a solution! Other methods and a source code revision are necessary.

The best way in this case:  contact the author.
https://github.com/graviox/Roundcube-CardDAV/issues

just my 2 cents
mbsouth

huhn_m

Not sure if trolling ....

My patches REPLACED the affected_rows commands with the correct SQL queries that do return the rowcount in a result. Are you sure you wanted to reply to me? Could you please re-read my posts?

nerbrume

#63
Hi,
I'm in the same situation as oldschool : huhn_m patches are not working for me, and replacing num_rows with affected_rows (yes, I know it's bad) almost works, except for contact creation. In my logs, I get the following errors : "CardDAV-Server XML-Response is malformed. Synchronization aborted!"(affected_rows method) or "Couldn't delete CardDAV-Contact from the local database with the vCard id" (huhn_m method).
This is happening with davical and owncloud (sabreDav-based).
note : I have applied the patches explained here, since this error was happening to me even on RC 8.4

Oldschool, how did you solved this ?

Does anyone have an idea of where this might come from ?

oldschool

#64
Hi!

Currently i am testing the 0.9 with this plugin V0.5.1 and with the "affected_rows" patches applied.

And, yes, i tested your experiences creating a new contact one minute ago.
It gives the described error, but without the "CardDAV-Server XML-Response is malformed. Synchronization aborted!".
After synchronising the new contact appears...

As i understand the contact is created locally and then transferred to the davical server...
And, the prob is not solved.


Rgds.

Accudio

Hey, I'm a noob when it comes to SQL databases, and cannot work out what
"Execute SQL statements from /plugins/carddav/SQL/yourDatabase.sql"
wants me to do in the install instructions. Can anyone give me quick helping hand and give me a slightly simpler explanation here?

Happyfeet

Good morning. After upgrade the Plugin from 0.8.0 to 0.9.x in Plugin manager I get an error for the database.
The Table roundcubemail.carddav_server doesn't exsist.

How can I fix this?

Gesendet von meinem HTC One X mit Tapatalk


oldschool

Hi!

My friend Allan did it! We made a "hardcore" session this night.
;)
Is there any need for the fixed plugin?


Greetz.

oldschool

#68
Okay!

Currently i am testing the fixed CardDAV-Plugin with the actual RC 0.95 and it seems to work.
;D
More to come...


Greets.



Update:
Quote from: alec on January 18, 2013, 11:49:42 AM
There's no num_rows() method in 0.9. Carddav plugin need to be updated to use other method.

Checked -> Bullsh*t!