Roundcube Community Forum

 

Managesieve patch

Started by JohnDoh, November 30, 2008, 06:00:56 AM

Previous topic - Next topic

JohnDoh

#30
hmm it definatly loads for me, which SVN version is it? can you attach the actual roundcube.sieve file? may be i am loosing something in copy/paste.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more...

oscar

Hi JohnDoe!

Patched my RC with your patchset (are you collaborating with Alec btw?) without problems. I'm running Dovecot 1.0 with pysieved. Everything works okay, except when trying to use "setflag". I just get a server error. I haven't tried everything else, but it seems the other functions work.. Any ideas?

JohnDoh

Hi,

This patch is based on Alec's work but i am not actually colaborating with him. Could you send me any example of the rule you are trying to create and i will try it. I havent had any problems myself but i am testing using Dovecot Managesieve, may be there is something in the syntax pysieved doesnt like.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more...

oscar

Ok, it's always good to colaborate ;)

To reproduce for me:
"Match all messages"
"Mark message as" "whatever"

Would want to run ManageSieve for Dovecot, but I don't want to compile it myself just because of that.. So I'm using cmusieve, and it says that it supports a draft version of imapflags and notify (haven't tried notify myself):
LDA/Sieve - Dovecot Wiki

Please let me know if you want me to test anything.

JohnDoh

ah you are quite right. setflag doesnt work when you select all messages. It works fine with the other 2 options :/ I will look into it.

colaboration is good but i think Alec is busy at the moment, he hasnt made a lot of updates to his patch recently.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more...

oscar

Using cmusieve/pysieved I can't get any setflag to work (the filtering itself works if I create the rule manually, it's just when I use the web interface).

So, setting "match all/any"  "Subject contains 'aa'" -> "setflag read"  doesn't work here either.

Let me know if I need to test anything directly against sieve or sievec (I'm guessing that's how pysieve checks and rejects stuff?)

JohnDoh

Please try this: in plugins/sieverules/rcube_sieve_script.php, line 44, change 'imapflags' to 'setflag'.

I found a few JS bugs just now as well so I will release an updated version in the next few days any way.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more...

oscar

Nope sorry, still the same.

roe1234

I would like to use sieve to give users the ability to build a vacation message.  The MDA is ideal for this so people can choose *not* to automatically respond to spam and mailing-lists etc.  Keeping this in mind, is there a way to extend this plug-in to allow users to build a rudimentary body message with a "reply" option?

JohnDoh

I'm sorry I dont understand.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more...

roe1234


vejoun

With this config all is ok. I can see the rules and add rules.
$sieverules_config['managesieve_host'] = 'ssl.foo.de';
$sieverules_config['managesieve_port'] = 2000;
$sieverules_config['usetls'] = false;
$sieverules_config['folder_delimiter'] = null;
$sieverules_config['include_imap_root'] = FALSE;
$sieverules_config['ruleset_name'] = 'roundcube';
$sieverules_config['multiple_actions'] = TRUE;

If I change the conf to
$sieverules_config['usetls'] = true;
I see no rules. No error. I can create a rule which will be saved with an ok, but the rules list stays empty.

If I switch back to non-TLS the new rule appears.

The server is an dovecot 1.1.8 with build-in ManageSieve. I tested the managesieve port with telnet and with  gnutls-cli --starttls -p 2000 ssl.foo.de.
It behave the same with non-TLS and TLS.

Mike

JohnDoh

This is a bug in the PEAR::Net_Sieve class (see PEAR :: Bug #14205 :: fetch the CAPABILITY string send after STARTTLS). There is a patch which fixes it so I will apply that in the next release.
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more...

oscar

JohnDoh, did you have any further suggestions for the SetFlag issue?

JohnDoh

oscar: please check your private messages. :)
Roundcube Plugins: Contextmenu, SpamAssassin Prefs, and more...