Roundcube Community Forum

 

addressbook in compose window

Started by corbosman, October 28, 2009, 03:42:19 PM

Previous topic - Next topic

haocheng

Dear corbosman :

i according to your instruction , Add global on config  ,

$rcmail_config['compose_addressbooks'] = array('sql','global');

"global address book" is correct display is in compose _ addressbook

corbosman


haocheng


corbosman

Good to hear. I thought it would work as it's just a normal addressbook.

epinter

Quote from: corbosman;24164Hi, again thanks for your patch! Im not sure though I agree with some of the changes you made. I incorporated the visual changes as they're nice, but the main issue, LDAP support, is imho not the right way to do it.

I think by far the most people will not be using LDAP, but just the default SQL. Your changes now force them, and everyone else, to always have to enter a search to find any address. Originally, this wasnt necessary as you'd immediately get a list of all addresses and you could immediately double click one. Very fast, unlike your version imho.

Also, i think there must be a way to make it work with list_records. See, if you go to the normal addressbook task, top-right, it also shows a list with all your contacts without having to search right? This uses the list_records method as well. Id rather find out why this isnt working for you. For me it actually is, im using FreeLDAP.org to test, and im seeing all my contacts.

Maybe you can put some debug calls in the code and find out whats going on.

Regards,

Cor

Good to know, you are open to suggestions. :)

I've done the search this way because I have a large email infrastructure (ISP). I have some domains with 2000/3000 email accounts (all accounts using LDAP). Imagine a large number of users getting 3000 addresses from LDAP to compose a message... I agree with you about the search, but only for small addressbooks... I don't think I'm the only using large addressbooks.

You can create an configuration option to control de behavior ...

When I click in my normal addressbook, I get a list of all records when I go to the SQL addressbook. But when I click in LDAP addressbook I need to search. My "filter" option in LDAP configuration is empty.


Cheers.

corbosman

Yeah, initially I also wondered about what to do about large addressbooks. I guess I could make it an option. Either you get your whole addressbook, or you have to search. I'll have to think about how to combine those 2.

ABerglund

I've been using this plugin for quite some time, but just added a global LDAP book over the weekend. I have not been able to get the LDAP book to show up in the compose window as the normal SQL book does. Any ideas?
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

corbosman

Ive had reports that LDAP doesnt work. Unfortunately I dont have access to LDAP except for a very basic free one that does work for me.

If you read the thread you'll see that there is a solution, but i havent been able to implement it. You could ask epinter to send you the patch he made, which will probably work for you.

ABerglund

OK, after playing with the config file parameter a bit, I got it working. I don't care for how the LDAP search returns entries that have matches in the middle of the string, but that's how RC does LDAP searches, even in the main address book. Has nothing to do with this plugin.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

corbosman

Could you elaborate on what you changed? It might help others.

ABerglund

Might not help others, depending on their LDAP setup. I could not specify the LDAP directory by name, or by 'ldap'. A had to use:

$rcmail_config['compose_addressbooks'] = array('public_ldap');
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

corbosman

Hmm, interesting. Thats a new one for me. Wonder why it had to be called that. How did you found out?

ABerglund

Quote from: corbosman;24944Hmm, interesting. Thats a new one for me. Wonder why it had to be called that. How did you found out?
Has to do with how I had to define the various LDAP directories I'm adding to my system, I suspect. Although it seems to me that I had to define it differently in your plugin than I did to put it in the main addressbook page.

I'll play around with it when I get time and confirm what it's doing.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

bagu

Hello,

Nice plugin.
Here is the french translation :
<?php

$labels 
= array();
$labels['compose_addressbook_buttontitle'] = 'Afficher le carnet d\'adresse';
$labels['compose_addressbook_title'] = 'Carnet d\'adresse';
$labels['compose_addressbook_close'] = 'Fermer';
$labels['compose_addressbook_noselect'] = 'Vous n\'avez pas sélectionné d\'adresse';
$labels['compose_addressbook_added'] = 'Adresses ajoutées';

?>


corbosman

Thank you, i will update it when I get home. Im currently on an expedition photographing Sperm Whales in Dominica.