Recipient To Contacts Plugin

[billstif]

This plugin does not work in .5.2.  Is there an upgrade available?

[lacri]

i have found the issue
remove this two lines in recipient_to_contact.php

in function get_contacts()
$this->rcmail->session->regenerate_id();
$this->rcmail->session->set_auth_cookie();now works in my rc 0.5.3 installation.

i hope this helps

and the second issue is in recipient_to_contact.js
in the save_contacts: function()
search

Code Select Expand

rcmail.display_message(rcmail.gettext('loading'), 'loading', true);and replace with

Code Select Expand

var lock = rcmail.set_busy(true, 'loading');and search

Code Select Expand

rcmail.http_post('plugin.recipient_to_contact_save_contacts', data);and replace with

Code Select Expand

rcmail.http_post('plugin.recipient_to_contact_save_contacts', data, lock);
now works fine for me

[billstif]

I made the changes.  The loading message still remained, and the plugin was caught in an endless loop.  Whenver I went to the e-mail page, the dialog box for saving the contact would appear.

[billstif]

The version of the plugin that I have did not have the line

$this->rcmail->session->set_auth_cookie();

Would you consider posting your version of the plugin as a zip file here?

[projectmyst]

I all so have this problem, i made the changes. The loading message still remained, and the plugin is caught in an endless loop.

Any one know how to fix it?

[rosali]

A question:

Why is the regenerate_id on line 189?

[billstif]

Following Rosali's lead, I disabled the regenerated_id line.  The plugin now works, but I still cannot get rid of the Loading message that continues after the dialog box closes.  I made the adjustments Lacri suggested and even tried disabling the loading lines in the js file, but no luck.

[cornfeed]

I solved it for me at least: https://github.com/namesco/Roundcube-Plugin-Recipient-To-Contact/issues/9

[billstif]

The package I downloaded must be numbered differently.  Line 202 in the php file (regenerate_id) was line 200.

Can you tell me what is in the lines in the js file to remove, and what should precede the new lines to be added so I can be sure of making the correct changes?

[cornfeed]

recipient_to_contact.js diff patch

Code Select Expand

212c212
<             rcmail.display_message(rcmail.gettext('loading'), 'loading', true);
---
>             var msgid = rcmail.set_busy(true, 'loading');
214c214
<             rcmail.http_post('plugin.recipient_to_contact_save_contacts', data);
---
>             rcmail.http_post('plugin.recipient_to_contact_save_contacts', data+'&_unlock='+msgid);
266d265
<
319,320d317
<         // enable the &quot;loading&quot; message
<         rcmail.display_message(rcmail.gettext('loading'), 'loading', true);
345,347d341
<
<         // disable the &quot;loading&quot; message
<         rcmail.display_message(rcmail.gettext('loading'), 'loading', false);

recipient_to_contact.php diff patch

Code Select Expand

202d201
<             $this->rcmail->session->regenerate_id();

If you don't know how to apply/read diff patches, or just don't have access to the shell, read How to read a patch or diff and understand its structure to apply it manually » markusbe.com. It will explain the basics of reading patch files.
These patches were made from a fresh download of the plugin.

[kionez]

Hi all,

is there anyone who use this plugin with the new roundcube (0.7)?

Thanks in advance

k.

[cornfeed]

I do, works fine. but needs updating