New plugin: Shared Address Books (more than one!)

[imente]

Today I create a simple plugin based on Philipp Weir's Global Address Book [GPL Licence]

It's the SharedAddressBooks 0.9 plugin for RC 0.3-stable
[download ZIP file 3kb]


*FEATURE*
- all the GlobalAddressBook feature and...
- one or more SQL address books
- elastic visibility rules (performs username matching)
- autocompletion (joining all the address books the user can view)
- read only flag with a defined admin (who can manage the address book even if readonly is TRUE)

(In the config file there are all the information about configuration.
if you find a bug or any other problem please contact me)

This plugin is very useful for me and so, I hope, for someone else

Bye from Italy (sorry for my english )

[rosali]

@ JohnDoh,

Could you please review this plugin? If this extensions looks fine to you, please merge them into your plugin. We should avoid forking. Also please make the 'Global Addressbook' localized.

$this->add_texts('localization/');
$this->name = $this->gettext($rcmail->config->get('globaladdressbook_name'));

$labels['Global Addresses'] = 'Global Addresses';

[JohnDoh]

rosali, imente....

rosali is right, having 2 almost identical coppies of the same plugin is pointless. The only really difference I can see between yours and mine is that yours allows for multiple address books where as mine only allows for 1. Would you be interested in working together?

[imente]

absolutely yes.

let me explain: I did this because I needed a more flexible global adbook that I could't find. So when it was ready I published because I like to share.
I understand why you want to avoid forking and I agree.

I accept your propose to work together.
If you like how i coded that, I can merge in your global address and present it to you so you can review it.

sorry if it seemed that I wanted to bypass you and I wanted to create a parallel version, simply I do not know if the development was active.

let me know
bye

[JohnDoh]

excelent, i'll send you a PM with more information.

rosali: about localising the address book name. The problem is that i think different people will want to call it different things in their setup so localising it becomes a little pointless. Also if we draw a parallel with the ldap address book, the name for this is set in the config, not in the localisation and it does not appear to cause any problems. I'm not sure which is better.

[rosali]

I really would like to see it to localized. I think it does not hurt to provide a default en_US with...

$labels['Global Addresses'] = 'Global Addresses';

...but it is your decision.

I don't think you should consider the LDAP behaviour. I use LDAP for dedicated LDAP servers (e.g. UNI Hamburg). The global addresses are local things which are not associated with real external addressbooks. At least I use it that way. You understand what I mean/expect?

[imente]

sorry, maybe I do not understand but

why create a localization of a plugin name?
I'm Italian and I have no problem with this plugin.

Where will that string appear?
And, this is a name, and names are not translated.

"Adobe Photoshop" is "Adobe Photoshop" in other languages

If I misunderstood the topic I sorry in advance.

[JohnDoh]

As I said I think it depends very much on exactly what people want to use the plugin for. I have changed the repo version so it uses a localised string, my thinking was this:

If someone wants to have the name localised, like the "Personal Addresses" title then they can, if some one wants it called something else then they can still do this, they just have to change it in the localisation file rather than the cofig AND they can still have their new name in multiple languages if they want - or just one - change in the en_US and delete all the other files.

[dziobak]

Is this plugin working? Is there a newer version?

[jmeander]

Is this plugin active?