addressbook in compose window

[corbosman]

I wonder what happens if multiple plugins use different versions of jquery-ui

[SKaero]

I wonder what happens if multiple plugins use different versions of jquery-ui

Firebug hell, good luck

[corbosman]

I really think RC should provide jquery-ui from core, because plugins are starting to use jquery-ui and who knows what kind of weird interaction that gives if people end up using multiple (ancient) versions with badly managed plugins.

Maybe some hook where you can tell the core to load jquery-ui. Possibly even specifically for each sub library.

ps: in some other project I massively use jquery-ui and especially dialog, so I know it rocks, but at the time I wrote compose_addressbook I just happened to be using the one I use now in another project. so i'll just be moving it to jquery-ui and be done with it.

[SKaero]

I'm not a fan of JQuery UI but I agree with you that it should be part of the core because so many plugins do use it.

[rosali]

Why not to have a plugin for that?

On startup hook:

      $rcmail = rcmail::get_instance();
      $skin = $rcmail->config->get('skin');
      $this->include_stylesheet('skins/' . $skin . '/jquery-ui-1.8.2.custom.css');
      $this->include_script('jquery-ui-1.8.2.custom.min.js');

[corbosman]

Heh, I was just thinking the same rosali. Would be nice if the plugin had hooks to load specific sub elements of jquery-ui, but i suppose it's not a big deal.

You do it or shall i do it?

[corbosman]

I just released a new version 2.1 of compose_addressbook. I have moved from jqmodal to jquery-ui dialog. This meant quite a few changes, so some testing would be nice. I have tested it on FF, safari, chrome, IE and it seems to all work fine.

Also a small bugfix for search mode. It always added address groups even in search mode. Fixed.

You can get it here:  http://underwa.ter.net/roundcube-plugins/

[rosali]

It would be great if you code the plugin to include jquery stuff. Do you really think it makes a big performance difference not to include the whole bundle?

[corbosman]

I think i wont worry too much about what to include. Im just going to include the whole bundle, effects and all.

[ABerglund]

I just released a new version 2.1 of compose_addressbook. I have moved from jqmodal to jquery-ui dialog. This meant quite a few changes, so some testing would be nice. I have tested it on FF, safari, chrome, IE and it seems to all work fine.

Also a small bugfix for search mode. It always added address groups even in search mode. Fixed.

You can get it here:  Roundcube Plugins | Underwater World

Seems fine in my pre-production test environment, set for Search mode on a 2000 user LDAP. I like the appearance better, too.

[rosali]

It does not work nice for me (IE8, FF3.6.3). Jquery dialog buttons overlap search box. Also there are scrollbars in the dialog div.

[corbosman]

I noticed that as well, but only if I had set IE8 in IE7 compatibility mode. If I set it to be normal IE8, it worked for me. I'll play with it some more later to see whats going on with that mode.

[corbosman]

Would it be strange if the search box was on top of the div instead of the bottom?

[ABerglund]

Would it be strange if the search box was on top of the div instead of the bottom?

I think I would prefer it that way.

[corbosman]

Rosali, im surprised you have a problem with FF. Although I dont have 3.6.3, but 3.6.4/5/6 work ok it seems.

Anyways, could you try if this fixes the scrollbar?

#compose_addressbook_container {
  height: 365px;
  overflow: auto;
  overflow-x: hidden;
}

Should be changed in skins/default/compose_addressbook.css , i added the overflow-x.

I cant reproduce the overlap  Hmm, maybe a font issue?