Roundcube Community Forum

 

addressbook in compose window

Started by corbosman, October 28, 2009, 03:42:19 PM

Previous topic - Next topic

corbosman

Just to see if this works, is this any better. Has search on top, and some css changes.

http://wa.ter.net/download/compose_addressbook-2.11.tgz

ABerglund

#121
Quote from: corbosman;28492Just to see if this works, is this any better. Has search on top, and some css changes.

http://wa.ter.net/download/compose_addressbook-2.11.tgz
The Copy and BCC buttons don't work for me - Safari 5 on Mac.

Edit - Just retested 2.1 - same there, no Copy or BCC function.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

rosali

#122
v2.11 looks fine to me.

Edit: I got cs_CZ translation from a user:


<?php
$labels 
= array();
$labels['compose_addressbook_buttontitle'] = 'Zobrazit adresář';
$labels['compose_addressbook_title'] = 'Adresář';
$labels['compose_addressbook_close'] = 'Zavřít';
$labels['compose_addressbook_noselect'] = 'Nevybral(a) jste adresu';
$labels['compose_addressbook_added'] = 'Adresy byly přidány';
?>
Regards,
Rosali

corbosman

Arne, let me guess, thats the latest SVN?  There is something around 3798 that seems to mess things up. At 3797 it works fine for me on safari 5 on mac.

corbosman

Actually Arne, I cant reproduce this. I have Safari on a mac as well, and for me it works fine with latest SVN.  What version of RC are you using?

corbosman

Rosali, I think something simple like this would work. Since you also use it for your calendar plugins, just want to make sure this would work for you. This includes the whole jquery UI package, and im using the smoothness theme since I think it looks almost identical to the roundcube default theme.


class jqueryui extends rcube_plugin
{
  
  public function 
init() 
  {    
    
$this->add_hook('render_page', array($this'add_jqueryui')); 
  }
  
  function 
add_jqueryui($args)
  {
    
$skin_path $this->local_skin_path();
    
    
// jquery UI
    
$this->include_script('js/jquery-ui-1.8.2.custom.min.js');
  
    
// jquery UI stylesheet
    
$this->include_stylesheet("$skin_path/css/smoothness/jquery-ui-1.8.2.custom.css"); 
  }
}

rosali

#126
Thanks, this will do the job.

Do you have any idea how to solve css conflicts on a top level way? F.e. keyboard_shortcuts uses the darkness theme and I like that. Your compose_addressbook and my calendar plugin use smoothness theme.

I have no idea how to solve it on a top level. Currently I decide what css is included by checking _task / _action. There must be a way to change the css on the client side by js. But I'm not very skilled in js ...
Regards,
Rosali

corbosman

I think we should pick a default theme as the general theme. I think that should be smoothness as it's very very close to default RC theme.

If a plugin wants to use a different theme, I think it's possible by overriding the theme with their own, like this:



They can download their theme, and in advanced settings provide a scope. In this example I added the scope '.keyboard_shortcuts'. Then, the plugin would need to add the class .keyboard_shortcuts' to all their UI elements. Then they add that css from their own plugin.

I havent tested this, but this is how you should do this according to the jquery site.

corbosman

Ok, I have tested this at it seems to work at least for my specific test. I downloaded a jquery-ui theme with scope 'compose_addressbook_ui', and then added this to the dialog javascript:

dialogClass'compose_addressbook_ui'

And now my dialog uses the ui-lightness theme instead of smoothness, even though both themes are loaded. I can see in firebug that my dialogs are using the lightness scope (.compose_addressbook_ui .ui_dialog ... ) and are overriding the smoothness theme.

Im not sure about other jquery-UI elements, but as long as you can provide a class to your UI elements, you can use this method.



ABerglund

Quote from: corbosman;28502Arne, let me guess, thats the latest SVN?  There is something around 3798 that seems to mess things up. At 3797 it works fine for me on safari 5 on mac.

Quote from: corbosman;28503Actually Arne, I cant reproduce this. I have Safari on a mac as well, and for me it works fine with latest SVN.  What version of RC are you using?
Actually, I'm holding my almost-production system at r3786, until the compose window/attachment bug in the newer releases (Safari5 on Windows) is corrected. I do have a later SVN I can test on, but I'm having some problems today VPNing into the network core. I'll try on the newer version when I get a chance.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

ABerglund

#131
Duplicate post deleted.
Arne Berglund
SysAdmin, Internet Services
Lane Education Service District
Eugene, OR, USA

corbosman

rosali, can you mail me the cs_CZ translation? I cant cut/paste those characters. I dont want to run the risk that they get mangled in copying.

cor at in.ter.net

corbosman

#133
I just released version 2.2 of this plugin with some layout changes.  IMPORTANT: this version depends on the jqueryui plugin, which you can get at the same download link

Roundcube Plugins | Underwater World

rosali

Sure, I'll mail you the file.
Regards,
Rosali