When using intermediate 'authenticator': invalid request no data was saved

[twisterbr]

Hi.

I implemented a php script that authenticate the mail account in my local mysql and do some checkings to redirect the user to the scpecific web server where the account is hosted (i have roundcube installed in 3 servers)... I used this script in 0.5 and was working well... but after I migrate to 0.6, when I try to login I receive the message:
invalid request! no data was saved.

I guess this has to do with some vars not being called by my script... So I ask: what were the changes made in 0.6 related to the form variables, that I'm probably forgetting to call?

I use the following to authenticate:
echo "";
  echo "";
  echo "";
  echo "";
  echo "";


sorry for my english..

[SKaero]

It sounds like your missing your $args['cookiecheck'] = false; or $args['valid'] = true; in your authenticate function.

[twisterbr]

It sounds like your missing your $args['cookiecheck'] = false; or $args['valid'] = true; in your authenticate function.

You mean like this for example?



it didn't work =(


Actually I don't remember using these 2 vars when I was with the v0.5.... don't know if it's different on 0.6

[SKaero]

No that needs to be in the auto login plugin.

[twisterbr]

Just to add something...

I am passing the vars (_user, _pass, _action, _task) from my html authenticator so the roundcube's index.php can authenticate. It gets the vars from the POST I sent and authenticate... so the only thing I need is to pass the correct variables for authentication... i'm missing something... any ideas??

[SKaero]

You need to have a RoundCube plugin in order for it to except that data, there is an example here: autologon.php in trunk/plugins/autologon

[twisterbr]

You need to have a RoundCube plugin in order for it to except that data, there is an example here: autologon.php in trunk/plugins/autologon

Thank you for your help. But I didn't changed the plugin, I'm still using it without any modification... I just pass the vars through an alternative file, which is my php authenticator that has the form action pointing to the index.php (untouched) in roundcube's root.... So my authenticator only have the job of sending the vars so the index.php can actually log the user in.


sorry if i'm 'misexpressing' my issue...

[twisterbr]

Basically my script is just like this:

[SKaero]

I understand the problem but you can't just post the username and password to RoundCube anymore. For security you have to have an auto login plugin with $args['cookiecheck'] = false; and $args['valid'] = true; in the authenticate function to allow RoundCube to use the post data.

[rluch]

I am having this issue as well. My setup/files is described here: [PHP] RoundCube 0.6 - Pastebin.com

I am including the http_authentication as plugin in my main.inc.php.
The http_authentication.php-script has:
 $args['cookiecheck'] = false; and $args['valid'] = true;

Still, I get this "invalid request no data was saved" error when logging in from the remote form.
This exact setup worked with the previous install (0.5.4, I think!).

Hope someone can help me out!

[rosali]

I think you have to remove the following code from the authenticate hook:


40         // Allow entering other user data in login form,
41       // e.g. after log out (#1487953)
42       if (!empty($args['user'])) {
43           return $args;
44       }

EDIT:

Alternativeliy you could move ...

51         $args['cookiecheck'] = false;
52       $args['valid'] = true;

... to top of authenticate hook.

[rluch]

Moving the checks to the top worked perfectly! Thanks a bunch rosali!

AFAIK, this change defeats the CSRF protection.
Is there a way to keep CSRF active for all domains/referrers expect the one we use for the external login forms?

[rosali]

You could pass a variable from the external login form (f.e. ) and check this in the authenticate hook:

40      // Allow entering other user data in login form,
41    // e.g. after log out (#1487953)
42    if (!empty($args['user']) && isset($_POST['_external']) {
43        $args['cookiecheck'] = false;
44      $args['valid'] = true;
45      return $args;
46    }

[rluch]

You could pass a variable from the external login form (f.e. ) and check this in the authenticate hook:

40      // Allow entering other user data in login form,
41    // e.g. after log out (#1487953)
42    if (!empty($args['user']) && isset($_POST['_external']) {
43        $args['cookiecheck'] = false;
44      $args['valid'] = true;
45      return $args;
46    }

Once again thank you for your awesome answer, Rosali.
After some brainstorming, I have concluded that no matter how you try to implement CSRF protection in this example, it can either be spoofed (fx. referrer validation) or otherwise bypassed (hidden inputs, can just be copied) by a potential attacker.
Hope this helps someone! Also, please correct me if this conclusion is straight up wrong

[rosali]

The conclusion is wrong. Roundcube processes only forms and AJAX requests which contain a unique token which is generated by Roundcube.